From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.0.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A56CE20A1E for ; Thu, 13 Dec 2018 15:38:19 +0000 (UTC) Received: from localhost ([::1]:53339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXT46-0001dx-Gf for normalperson@yhbt.net; Thu, 13 Dec 2018 10:38:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXT0S-0006qZ-TV for bug-gnulib@gnu.org; Thu, 13 Dec 2018 10:34:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXT0O-0005xk-P4 for bug-gnulib@gnu.org; Thu, 13 Dec 2018 10:34:32 -0500 Received: from mta-01.yadro.com ([89.207.88.251]:46618) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXT0O-0005wq-Ew for bug-gnulib@gnu.org; Thu, 13 Dec 2018 10:34:28 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id CBB4D41984 for ; Thu, 13 Dec 2018 15:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= content-type:content-type:mime-version:x-mailer:message-id:date :date:subject:subject:from:from:received:received:received; s= mta-01; t=1544715265; x=1546529666; bh=tqsb6PmzZ0SH4Ir95DoDedN4h YoIKyu6dO0zn7Y0OMs=; b=PZtZyqXu9qp+CfJR1c5QdEWelNSkoVnTMslGOTKRT 3n0h9zRFBxc2L+oEc1aFDUGSzTD2gPH2yBtwPKQ0dkm8alq35XoqMsSEzV4aj5Bd GoWJPcNIFt18IJwJjh55VotTo9uqVmagQhOKcEEfoUYdhctE1e49Je8+zGLWVEif Oo= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jiqLECPYTiBM for ; Thu, 13 Dec 2018 18:34:25 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 8A01C4197E for ; Thu, 13 Dec 2018 18:34:25 +0300 (MSK) Received: from localhost (172.17.128.60) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Thu, 13 Dec 2018 18:34:25 +0300 From: Roman Bolshakov To: Subject: [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD Date: Thu, 13 Dec 2018 18:34:51 +0300 Message-ID: <20181213153453.38123-1-r.bolshakov@yadro.com> X-Mailer: git-send-email 2.17.2 (Apple Git-113) MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.17.128.60] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 89.207.88.251 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Bolshakov Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hello, There was an issue with syntax-check on FreeBSD reported a few years ago: https://www.redhat.com/archives/libvir-list/2015-August/msg00758.html http://lists.gnu.org/archive/html/bug-gnulib/2015-08/msg00019.html The patch series attempts to resolve the issue on gnulib side. With related changes on libvirt side I can run make syntax-check on macOS. * modules/maintainer-makefile (configure.ac): Look for the best available ggrep or grep with AC_PROG_GREP. * top/maint.mk: Split long argument lists with xargs. Replace grep invocations with $(GREP). v2: http://lists.gnu.org/archive/html/bug-gnulib/2018-12/msg00026.html Changes since v2: - removed /dev/null argument for grep invocations with "-l" flag - reformatted all affected multi-line commands to be more consistent with the style of the code around with regards to &&, || and | - removed dependency on mkdir in sc_prohibit_always-defined_macros - rewrote sc_po_check to avoid running perl with $(generated_files) multiple times - rewrote sc_cross_check_PATH_usage_in_tests to simplify indentation v1: http://lists.gnu.org/archive/html/bug-gnulib/2018-11/msg00069.html Changes since v1: - removed VC_ARG_MAX - removed "-n" flag in xargs invocations - added /dev/null as an extra file for uniform grep output regardless of number of files. The file isn't added if grep invocation has "-L" flag - added dependency on AC_PROG_GREP to modules/maintainer-makefile -- Best regards, Roman Roman Bolshakov (2): maint.mk: Split long argument lists maint.mk: Replace grep with $(GREP) modules/maintainer-makefile | 1 + top/maint.mk | 207 +++++++++++++++++++++--------------- 2 files changed, 123 insertions(+), 85 deletions(-) -- 2.17.2 (Apple Git-113)