From: Bruno Haible <bruno@clisp.org>
To: Eric Blake <eblake@redhat.com>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>, bug-gnulib@gnu.org
Subject: Re: [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD
Date: Sun, 06 Jan 2019 22:36:36 +0100 [thread overview]
Message-ID: <9434231.ZYlTdXgCy9@omega> (raw)
In-Reply-To: <da690c4e-88ea-0f8c-482e-a7636e1cd351@redhat.com>
Eric Blake wrote:
> I've now applied the patches, with tweaks as discussed on 1/2.
In GNU gettext, I now see this message when using the top-level GNUmakefile:
/bin/bash: rsyncable: command not found
The reason is that GNU gettext imports the relevant files directly (via
'gnulib-tool --copy-file'), ignoring the module description. This is a
reasonable thing to do, since GNU gettext does not ship GNUmakefile nor
maint.mk in the tarballs; it uses them only in the git checkouts.
This patch fixes it for me.
2019-01-06 Bruno Haible <bruno@clisp.org>
maintainer-makefile: Make the configure.ac section optional.
* top/maint.mk (GREP, SED): Define if not defined.
diff --git a/top/maint.mk b/top/maint.mk
index 4b57410..4e37efe 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -21,6 +21,12 @@
# ME := $(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST))
ME := maint.mk
+# These variables ought to be defined through the configure.ac section
+# of the module description. But some packages import this file directly,
+# ignoring the module description.
+GREP ?= grep
+SED ?= sed
+
# Helper variables.
_empty =
_sp = $(_empty) $(_empty)
prev parent reply other threads:[~2019-01-06 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:34 [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD Roman Bolshakov
2018-12-13 15:34 ` [PATCH v3 1/2] maint.mk: Split long argument lists Roman Bolshakov
2019-01-02 19:31 ` Eric Blake
2018-12-13 15:34 ` [PATCH v3 2/2] maint.mk: Replace grep with $(GREP) Roman Bolshakov
2018-12-20 13:06 ` [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD Roman Bolshakov
2019-01-02 20:14 ` Eric Blake
2019-01-03 14:44 ` Eric Blake
2019-01-03 15:28 ` Eric Blake
2019-01-06 21:36 ` Bruno Haible [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9434231.ZYlTdXgCy9@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eblake@redhat.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).