bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: bug-gnulib@gnu.org, eggert@cs.ucla.edu, keith@users.osdn.me
Subject: Re: Gnulib's alloca.h used even when there is a system header
Date: Sun, 10 Mar 2019 20:54:20 +0100	[thread overview]
Message-ID: <1849053.XMJie2GYLO@omega> (raw)
In-Reply-To: <83k1h65xjg.fsf@gnu.org>

Eli Zaretskii wrote:
> It LGTM, since I already succeeded to build that package with this:

Thanks for the confirmation.

> > +#  if (defined _WIN32 && ! defined __CYGWIN__) && @HAVE_ALLOCA_H@
> 
> replaced by just "#if HAVE_ALLOCA_H"

Right, AC_FUNC_ALLOCA already defines HAVE_ALLOCA_H as a preprocessor
macro, under the same conditions. But we have the habit, when we
create a .h file from a .in.h file, to substitute values found at
configure time directly. This
  - makes it possible to reference the same variables in the
    module description,
  - increases the probability that the .h file works even when the
    user has forgotten to #include <config.h> or adds or removes
    a macro definition through #define or #undef,
  - increases transparency in case of a compilation error.

Pushed.

Bruno



  reply	other threads:[~2019-03-10 19:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17 17:20 Gnulib's alloca.h used even when there is a system header Eli Zaretskii
2019-02-17 20:06 ` Paul Eggert
2019-02-17 20:24   ` Eli Zaretskii
2019-02-17 21:09     ` Paul Eggert
2019-02-17 23:32       ` Bruno Haible
2019-02-18 16:59       ` Eli Zaretskii
2019-02-18 23:32         ` Bruno Haible
2019-02-19 17:18           ` Eli Zaretskii
2019-02-28 18:40             ` Eli Zaretskii
2019-03-09 19:25             ` Keith Marshall
2019-03-10 19:03               ` Bruno Haible
2019-03-10 19:39                 ` Eli Zaretskii
2019-03-10 19:54                   ` Bruno Haible [this message]
2019-03-10 20:00                     ` Eli Zaretskii
2019-02-17 23:28 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1849053.XMJie2GYLO@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=keith@users.osdn.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).