From: Eli Zaretskii <eliz@gnu.org>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org, eggert@cs.ucla.edu, keith@users.osdn.me
Subject: Re: Gnulib's alloca.h used even when there is a system header
Date: Sun, 10 Mar 2019 21:39:31 +0200 [thread overview]
Message-ID: <83k1h65xjg.fsf@gnu.org> (raw)
In-Reply-To: <6311558.T2CZKSR39q@omega> (message from Bruno Haible on Sun, 10 Mar 2019 20:03:33 +0100)
> From: Bruno Haible <bruno@clisp.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, bug-gnulib@gnu.org, eggert@cs.ucla.edu
> Date: Sun, 10 Mar 2019 20:03:33 +0100
>
> So, Gnulib's alloca.h and the system's alloca.h are both included, and
> the system's alloca.h comes last. To avoid this kind of trouble, we
> need to make use of '#include_next <alloca.h>'. I think this patch
> should do it. Can you please review it, Eli?
It LGTM, since I already succeeded to build that package with this:
> +# if (defined _WIN32 && ! defined __CYGWIN__) && @HAVE_ALLOCA_H@
replaced by just "#if HAVE_ALLOCA_H", and because the 2 additional
conditions you propose are obviously true for MinGW.
> + if test $ac_cv_working_alloca_h = yes; then
> + HAVE_ALLOCA_H=1
> + else
> + HAVE_ALLOCA_H=0
> + fi
> + AC_SUBST([HAVE_ALLOCA_H])
> ])
This cannot hurt, but in the case in point the package was already
testing for alloca.h, and defined HAVE_ALLOCA_H by itself.
Thanks.
next prev parent reply other threads:[~2019-03-10 19:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 17:20 Gnulib's alloca.h used even when there is a system header Eli Zaretskii
2019-02-17 20:06 ` Paul Eggert
2019-02-17 20:24 ` Eli Zaretskii
2019-02-17 21:09 ` Paul Eggert
2019-02-17 23:32 ` Bruno Haible
2019-02-18 16:59 ` Eli Zaretskii
2019-02-18 23:32 ` Bruno Haible
2019-02-19 17:18 ` Eli Zaretskii
2019-02-28 18:40 ` Eli Zaretskii
2019-03-09 19:25 ` Keith Marshall
2019-03-10 19:03 ` Bruno Haible
2019-03-10 19:39 ` Eli Zaretskii [this message]
2019-03-10 19:54 ` Bruno Haible
2019-03-10 20:00 ` Eli Zaretskii
2019-02-17 23:28 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k1h65xjg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=keith@users.osdn.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).