From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F302E20248 for ; Sun, 10 Mar 2019 19:55:04 +0000 (UTC) Received: from localhost ([127.0.0.1]:49939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h34XG-0003OQ-No for normalperson@yhbt.net; Sun, 10 Mar 2019 15:55:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h34X7-0003Ml-DR for bug-gnulib@gnu.org; Sun, 10 Mar 2019 15:54:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h34X6-0002Be-LG for bug-gnulib@gnu.org; Sun, 10 Mar 2019 15:54:53 -0400 Received: from mo6-p01-ob.smtp.rzone.de ([2a01:238:20a:202:5301::1]:22596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h34Wy-00024j-40; Sun, 10 Mar 2019 15:54:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1552247681; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=UfbX/QoDQb2XD4DCwKZqg3S+b9vYRPL62SRmvT7oSuM=; b=Tf2WNjRcEO/hrQV7dkqH7nKohxcrrCVwRcvHuF+9PnS2v77e3sdNVPA3cd29HTkBLE puFQEqkq/ioo6PL6Olg9uM3B/O1KsA93qG85i/CqHnTTe33utfCxdnXx1jcYC6uwO+JB zXKai8J1N0qpt5TAsX6oJRDc0BFvDthbcYPgjgu0EHOuP4aQhMXgNZmfeT5DQEkRPXIx c4B5Nf9F+bA59Smr1o2fmf3pyT1hu2Hylh7Wzp1uawPWf2hoQ5OlWzEk9IRpjw0qQ9PX QRMThNUzJ6l+vLzqSeQuZgDgRpVJTEQIv0BaQq5A++3emlJAwKMZJdVGKEUj1IB6ZKOf HzOQ== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf0y5BW" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 44.13 DYNA|AUTH) with ESMTPSA id 60865ev2AJsL2bb (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Sun, 10 Mar 2019 20:54:21 +0100 (CET) From: Bruno Haible To: Eli Zaretskii Subject: Re: Gnulib's alloca.h used even when there is a system header Date: Sun, 10 Mar 2019 20:54:20 +0100 Message-ID: <1849053.XMJie2GYLO@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <83k1h65xjg.fsf@gnu.org> References: <83ftsml4bl.fsf@gnu.org> <6311558.T2CZKSR39q@omega> <83k1h65xjg.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5301::1 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org, eggert@cs.ucla.edu, keith@users.osdn.me Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Eli Zaretskii wrote: > It LGTM, since I already succeeded to build that package with this: Thanks for the confirmation. > > +# if (defined _WIN32 && ! defined __CYGWIN__) && @HAVE_ALLOCA_H@ > > replaced by just "#if HAVE_ALLOCA_H" Right, AC_FUNC_ALLOCA already defines HAVE_ALLOCA_H as a preprocessor macro, under the same conditions. But we have the habit, when we create a .h file from a .in.h file, to substitute values found at configure time directly. This - makes it possible to reference the same variables in the module description, - increases the probability that the .h file works even when the user has forgotten to #include or adds or removes a macro definition through #define or #undef, - increases transparency in case of a compilation error. Pushed. Bruno