bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
* configure messages: check for features, not for bugs
@ 2020-07-26 15:02 Bruno Haible
  2020-07-26 18:05 ` Paul Eggert
  0 siblings, 1 reply; 3+ messages in thread
From: Bruno Haible @ 2020-07-26 15:02 UTC (permalink / raw)
  To: bug-gnulib

[-- Attachment #1: Type: text/plain, Size: 3322 bytes --]

Hi,

When running a gnulib testdir on a new platform, or when finding the differences
between different versions of the same OS, one needs to review
  - either the config.cache file,
  - or the configure output.

This is relatively easy because most autoconf tests (> 95%) have the answer
"yes" for successful/good, and "no" for broken/bad.

There are a couple of autoconf tests, however, that catch the attention because
the answer is "no" for successful/good.

It would make reading of the config.cache file and of the configure output
easier if "no" meant broken/bad for _all_ tests.

There are some tests, of course, where both outcomes are good, e.g.
"checking whether // is distinct from /...". Nevertheless, it makes things
easier to be systematic when there is a clearly good and a clearly bad outcome.

Does anyone see a problem with this? Here is a proposed set of patches.


2020-07-26  Bruno Haible  <bruno@clisp.org>

	stdint, wchar, wctype-h: Change configure message.
	* m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large
	enough..." instead of "checking whether wint_t is too small...".

2020-07-26  Bruno Haible  <bruno@clisp.org>

	time_rz: Change configure message.
	* m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even
	near extrema..." instead of "checking whether localtime loops forever
	near extrema...".

2020-07-26  Bruno Haible  <bruno@clisp.org>

	stdint: Change configure message.
	* m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works
	without ISO C predefines..." instead of "checking whether stdint.h
	predates C++11...".

2020-07-26  Bruno Haible  <bruno@clisp.org>

	socketlib: Change configure message.
	* m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..."
	instead of "checking if we need to call WSAStartup in winsock2.h and
	-lws2_32...".

2020-07-26  Bruno Haible  <bruno@clisp.org>

	include_next: Change configure message.
	* m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source
	code line length is unlimited..." instead of "checking whether system
	header files limit the line length...".

2020-07-26  Bruno Haible  <bruno@clisp.org>

	getcwd: Change configure message.
	* m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking
	whether getcwd succeeds when 4k < cwd_length < 16k..." instead of
	"checking whether getcwd aborts when 4k < cwd_length < 16k...".

2020-07-26  Bruno Haible  <bruno@clisp.org>

	chdir-long: Change configure message.
	* m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this
	system supports file names of any length..." instead of "checking
	whether this system has an arbitrary file name length limit...".
	Set gl_cv_have_unlimited_file_name_length instead of
	gl_cv_have_arbitrary_file_name_length_limit.
	* modules/chdir-long (Depends-on, configure.ac): Update accordingly.

2020-07-26  Bruno Haible  <bruno@clisp.org>

	ceill: Change configure message.
	* m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..."
	instead of "checking whether ceill() breaks with small values...".

2020-07-26  Bruno Haible  <bruno@clisp.org>

	iconv: Change configure message.
	* m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible
	with its POSIX signature..." instead of "checking for iconv
	declaration...". Remove K&R C support.




[-- Attachment #2: 0001-iconv-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 3909 bytes --]

From 6d4b69053bdeb5798069fd52cba2807b3f938828 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 12:00:38 +0200
Subject: [PATCH 1/2] iconv: Change configure message.

* m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible
with its POSIX signature..." instead of "checking for iconv
declaration...". Remove K&R C support.
---
 ChangeLog   |  7 +++++++
 m4/iconv.m4 | 44 +++++++++++++++++++++++---------------------
 2 files changed, 30 insertions(+), 21 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fc4b46e..87b873b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	iconv: Change configure message.
+	* m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible
+	with its POSIX signature..." instead of "checking for iconv
+	declaration...". Remove K&R C support.
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	expl: Simplify autoconf test.
 	* m4/expl.m4 (gl_FUNC_EXPL): Merge the "checking whether expl() breaks
 	with small values..." test into the "checking whether expl works..."
diff --git a/m4/iconv.m4 b/m4/iconv.m4
index e593b72..cd2fd23 100644
--- a/m4/iconv.m4
+++ b/m4/iconv.m4
@@ -1,4 +1,4 @@
-# iconv.m4 serial 21
+# iconv.m4 serial 22
 dnl Copyright (C) 2000-2002, 2007-2014, 2016-2020 Free Software Foundation,
 dnl Inc.
 dnl This file is free software; the Free Software Foundation
@@ -7,6 +7,10 @@ dnl with or without modifications, as long as this notice is preserved.
 
 dnl From Bruno Haible.
 
+dnl Note: AM_ICONV is documented in the GNU gettext manual
+dnl <https://www.gnu.org/software/gettext/manual/html_node/AM_005fICONV.html>.
+dnl Don't make changes that are incompatible with that documentation!
+
 AC_DEFUN([AM_ICONV_LINKFLAGS_BODY],
 [
   dnl Prerequisites of AC_LIB_LINKFLAGS_BODY.
@@ -247,41 +251,39 @@ gl_iconv_AC_DEFUN([AM_ICONV],
 [
   AM_ICONV_LINK
   if test "$am_cv_func_iconv" = yes; then
-    AC_MSG_CHECKING([for iconv declaration])
-    AC_CACHE_VAL([am_cv_proto_iconv], [
-      AC_COMPILE_IFELSE(
-        [AC_LANG_PROGRAM(
-           [[
+    AC_CACHE_CHECK([whether iconv is compatible with its POSIX signature],
+      [gl_cv_iconv_nonconst],
+      [AC_COMPILE_IFELSE(
+         [AC_LANG_PROGRAM(
+            [[
 #include <stdlib.h>
 #include <iconv.h>
 extern
 #ifdef __cplusplus
 "C"
 #endif
-#if defined(__STDC__) || defined(_MSC_VER) || defined(__cplusplus)
 size_t iconv (iconv_t cd, char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);
-#else
-size_t iconv();
-#endif
-           ]],
-           [[]])],
-        [am_cv_proto_iconv_arg1=""],
-        [am_cv_proto_iconv_arg1="const"])
-      am_cv_proto_iconv="extern size_t iconv (iconv_t cd, $am_cv_proto_iconv_arg1 char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);"])
-    am_cv_proto_iconv=`echo "[$]am_cv_proto_iconv" | tr -s ' ' | sed -e 's/( /(/'`
-    AC_MSG_RESULT([
-         $am_cv_proto_iconv])
+            ]],
+            [[]])],
+         [gl_cv_iconv_nonconst=yes],
+         [gl_cv_iconv_nonconst=no])
+      ])
   else
     dnl When compiling GNU libiconv on a system that does not have iconv yet,
     dnl pick the POSIX compliant declaration without 'const'.
-    am_cv_proto_iconv_arg1=""
+    gl_cv_iconv_nonconst=yes
+  fi
+  if test $gl_cv_iconv_nonconst = yes; then
+    iconv_arg1=""
+  else
+    iconv_arg1="const"
   fi
-  AC_DEFINE_UNQUOTED([ICONV_CONST], [$am_cv_proto_iconv_arg1],
+  AC_DEFINE_UNQUOTED([ICONV_CONST], [$iconv_arg1],
     [Define as const if the declaration of iconv() needs const.])
   dnl Also substitute ICONV_CONST in the gnulib generated <iconv.h>.
   m4_ifdef([gl_ICONV_H_DEFAULTS],
     [AC_REQUIRE([gl_ICONV_H_DEFAULTS])
-     if test -n "$am_cv_proto_iconv_arg1"; then
+     if test $gl_cv_iconv_nonconst != yes; then
        ICONV_CONST="const"
      fi
     ])
-- 
2.7.4


[-- Attachment #3: 0002-ceill-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 3424 bytes --]

From d8d516c46527eb5a30bda9ceb10720bef41e46db Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 12:07:32 +0200
Subject: [PATCH 2/2] ceill: Change configure message.

* m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..."
instead of "checking whether ceill() breaks with small values...".
---
 ChangeLog   |  6 ++++++
 m4/ceill.m4 | 48 ++++++++++++++++++++++++------------------------
 2 files changed, 30 insertions(+), 24 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 87b873b..ed6127b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	ceill: Change configure message.
+	* m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..."
+	instead of "checking whether ceill() breaks with small values...".
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	iconv: Change configure message.
 	* m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible
 	with its POSIX signature..." instead of "checking for iconv
diff --git a/m4/ceill.m4 b/m4/ceill.m4
index 1add841..78de5a0 100644
--- a/m4/ceill.m4
+++ b/m4/ceill.m4
@@ -1,4 +1,4 @@
-# ceill.m4 serial 20
+# ceill.m4 serial 21
 dnl Copyright (C) 2007, 2009-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -74,31 +74,31 @@ int main (int argc, char *argv[])
     HAVE_DECL_CEILL=0
   fi
   dnl On OpenBSD5.6 the system's native ceill() is buggy:
-  dnl it returns '0' for small values. Test for this anomaly.
+  dnl it returns '0' for small values. Test against this anomaly.
   if test $REPLACE_CEILL = 0 ; then
-    AC_CACHE_CHECK([whether ceill() breaks with small values],
-        [gl_cv_func_ceill_buggy],
-        [
-          save_LIBS="$LIBS"
-          LIBS="$CEILL_LIBM"
-          AC_RUN_IFELSE(
-           [AC_LANG_PROGRAM(
-             [[#include <math.h>
+    AC_CACHE_CHECK([whether ceill() works],
+      [gl_cv_func_ceill_works],
+      [save_LIBS="$LIBS"
+       LIBS="$CEILL_LIBM"
+       AC_RUN_IFELSE(
+         [AC_LANG_PROGRAM(
+            [[#include <math.h>
 long double d = 0.3L;]],
-             [[return (!(ceill (d) == 1)); ]])],
-             [gl_cv_func_ceill_buggy=no], [gl_cv_func_ceill_buggy=yes],
-             [case "$host_os" in
-                openbsd*) gl_cv_func_ceill_buggy="guessing yes" ;;
-                          # Guess no on native Windows.
-                mingw*)   gl_cv_func_ceill_buggy="guessing no" ;;
-                *)        gl_cv_func_ceill_buggy="guessing no" ;;
-              esac
-             ])
-          LIBS="$save_LIBS"
-        ])
-    case "$gl_cv_func_ceill_buggy" in
-      *yes)
-        REPLACE_CEILL=1 ;;
+            [[return (!(ceill (d) == 1)); ]])],
+         [gl_cv_func_ceill_works=yes],
+         [gl_cv_func_ceill_works=no],
+         [case "$host_os" in
+            openbsd*) gl_cv_func_ceill_works="guessing no" ;;
+                      # Guess yes on native Windows.
+            mingw*)   gl_cv_func_ceill_works="guessing yes" ;;
+            *)        gl_cv_func_ceill_works="guessing yes" ;;
+          esac
+         ])
+       LIBS="$save_LIBS"
+      ])
+    case "$gl_cv_func_ceill_works" in
+      *yes) ;;
+      *) REPLACE_CEILL=1 ;;
     esac
   fi
   if test $HAVE_DECL_CEILL = 0 || test $REPLACE_CEILL = 1; then
-- 
2.7.4


[-- Attachment #4: 0003-chdir-long-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 4475 bytes --]

From b05e5043cf8d6bbade2d5131d0f61e1ec9ddc250 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 13:59:47 +0200
Subject: [PATCH 1/3] chdir-long: Change configure message.

* m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this
system supports file names of any length..." instead of "checking
whether this system has an arbitrary file name length limit...".
Set gl_cv_have_unlimited_file_name_length instead of
gl_cv_have_arbitrary_file_name_length_limit.
* modules/chdir-long (Depends-on, configure.ac): Update accordingly.
---
 ChangeLog          | 10 ++++++++++
 m4/chdir-long.m4   | 10 +++++-----
 modules/chdir-long | 22 +++++++++++-----------
 3 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0db1079..f31b16a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	chdir-long: Change configure message.
+	* m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this
+	system supports file names of any length..." instead of "checking
+	whether this system has an arbitrary file name length limit...".
+	Set gl_cv_have_unlimited_file_name_length instead of
+	gl_cv_have_arbitrary_file_name_length_limit.
+	* modules/chdir-long (Depends-on, configure.ac): Update accordingly.
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	inttypes: Remove support for AIX 4.
 	* lib/inttypes.in.h: Assume that PRI_MACROS_BROKEN is 0.
 	* m4/inttypes-pri.m4: Remove file.
diff --git a/m4/chdir-long.m4 b/m4/chdir-long.m4
index a528a5d..a6e67b5 100644
--- a/m4/chdir-long.m4
+++ b/m4/chdir-long.m4
@@ -1,4 +1,4 @@
-#serial 16
+#serial 17
 
 # Use Gnulib's robust chdir function.
 # It can handle arbitrarily long directory names, which means
@@ -16,15 +16,15 @@ dnl with or without modifications, as long as this notice is preserved.
 AC_DEFUN([gl_FUNC_CHDIR_LONG],
 [
   AC_REQUIRE([gl_PATHMAX_SNIPPET_PREREQ])
-  AC_CACHE_CHECK([whether this system has an arbitrary file name length limit],
-    [gl_cv_have_arbitrary_file_name_length_limit],
+  AC_CACHE_CHECK([whether this system supports file names of any length],
+    [gl_cv_have_unlimited_file_name_length],
     [AC_EGREP_CPP([have_arbitrary_file_name_length_limit],
                   gl_PATHMAX_SNIPPET[
 #ifdef PATH_MAX
 have_arbitrary_file_name_length_limit
 #endif],
-    [gl_cv_have_arbitrary_file_name_length_limit=yes],
-    [gl_cv_have_arbitrary_file_name_length_limit=no])])
+    [gl_cv_have_unlimited_file_name_length=no],
+    [gl_cv_have_unlimited_file_name_length=yes])])
 ])
 
 AC_DEFUN([gl_PREREQ_CHDIR_LONG], [:])
diff --git a/modules/chdir-long b/modules/chdir-long
index 82d4e8b..3cab294 100644
--- a/modules/chdir-long
+++ b/modules/chdir-long
@@ -11,20 +11,20 @@ Depends-on:
 unistd
 pathmax
 chdir
-assure          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-atexit          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-fchdir          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-fcntl-h         [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-openat          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-memchr          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-mempcpy         [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-memrchr         [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-stdbool         [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-stdlib          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
+assure          [test $gl_cv_have_unlimited_file_name_length = no]
+atexit          [test $gl_cv_have_unlimited_file_name_length = no]
+fchdir          [test $gl_cv_have_unlimited_file_name_length = no]
+fcntl-h         [test $gl_cv_have_unlimited_file_name_length = no]
+openat          [test $gl_cv_have_unlimited_file_name_length = no]
+memchr          [test $gl_cv_have_unlimited_file_name_length = no]
+mempcpy         [test $gl_cv_have_unlimited_file_name_length = no]
+memrchr         [test $gl_cv_have_unlimited_file_name_length = no]
+stdbool         [test $gl_cv_have_unlimited_file_name_length = no]
+stdlib          [test $gl_cv_have_unlimited_file_name_length = no]
 
 configure.ac:
 gl_FUNC_CHDIR_LONG
-if test $gl_cv_have_arbitrary_file_name_length_limit = yes; then
+if test $gl_cv_have_unlimited_file_name_length = no; then
   AC_LIBOBJ([chdir-long])
   gl_PREREQ_CHDIR_LONG
 fi
-- 
2.7.4


[-- Attachment #5: 0004-getcwd-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 3826 bytes --]

From 005ad2fba399ed226cfd50abb2136d1d3f7deb9e Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 14:26:28 +0200
Subject: [PATCH 2/3] getcwd: Change configure message.

* m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking
whether getcwd succeeds when 4k < cwd_length < 16k..." instead of
"checking whether getcwd aborts when 4k < cwd_length < 16k...".
---
 ChangeLog              |  7 +++++++
 m4/getcwd-abort-bug.m4 | 26 +++++++++++++-------------
 2 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f31b16a..a4312ff 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	getcwd: Change configure message.
+	* m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking
+	whether getcwd succeeds when 4k < cwd_length < 16k..." instead of
+	"checking whether getcwd aborts when 4k < cwd_length < 16k...".
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	chdir-long: Change configure message.
 	* m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this
 	system supports file names of any length..." instead of "checking
diff --git a/m4/getcwd-abort-bug.m4 b/m4/getcwd-abort-bug.m4
index 2715f0a..96c1370 100644
--- a/m4/getcwd-abort-bug.m4
+++ b/m4/getcwd-abort-bug.m4
@@ -1,4 +1,4 @@
-# serial 11
+# serial 12
 # Determine whether getcwd aborts when the length of the working directory
 # name is unusually large.  Any length between 4k and 16k trigger the bug
 # when using glibc-2.4.90-9 or older.
@@ -10,7 +10,7 @@
 
 # From Jim Meyering
 
-# gl_FUNC_GETCWD_ABORT_BUG([ACTION-IF-FOUND[, ACTION-IF-NOT-FOUND]])
+# gl_FUNC_GETCWD_ABORT_BUG([ACTION-IF-BUGGY[, ACTION-IF-WORKS]])
 AC_DEFUN([gl_FUNC_GETCWD_ABORT_BUG],
 [
   AC_REQUIRE([AC_CANONICAL_HOST]) dnl for cross-compiles
@@ -24,8 +24,8 @@ AC_DEFUN([gl_FUNC_GETCWD_ABORT_BUG],
       [Define to 1 if the system has the 'getpagesize' function.])
   fi
 
-  AC_CACHE_CHECK([whether getcwd aborts when 4k < cwd_length < 16k],
-    [gl_cv_func_getcwd_abort_bug],
+  AC_CACHE_CHECK([whether getcwd succeeds when 4k < cwd_length < 16k],
+    [gl_cv_func_getcwd_succeeds_beyond_4k],
     [# Remove any remnants of a previous test.
      rm -rf confdir-14B---
      # Arrange for deletion of the temporary directory this test creates.
@@ -128,7 +128,7 @@ main ()
   return fail;
 }
           ]])],
-       [gl_cv_func_getcwd_abort_bug=no],
+       [gl_cv_func_getcwd_succeeds_beyond_4k=yes],
        [dnl An abort will provoke an exit code of something like 134 (128 + 6).
         dnl An exit code of 4 can also occur (in OpenBSD 4.9, NetBSD 5.1 for
         dnl example): getcwd (NULL, 0) fails rather than returning a string
@@ -137,21 +137,21 @@ main ()
         dnl provide a non-NULL value in this case.
         ret=$?
         if test $ret -ge 128 || test $ret = 4; then
-          gl_cv_func_getcwd_abort_bug=yes
+          gl_cv_func_getcwd_succeeds_beyond_4k=no
         else
-          gl_cv_func_getcwd_abort_bug=no
+          gl_cv_func_getcwd_succeeds_beyond_4k=yes
         fi
        ],
        [case "$host_os" in
-                   # Guess no on musl systems.
-          *-musl*) gl_cv_func_getcwd_abort_bug="guessing no" ;;
-                   # Guess yes otherwise, even on glibc systems.
-          *)       gl_cv_func_getcwd_abort_bug="guessing yes"
+                   # Guess yes on musl systems.
+          *-musl*) gl_cv_func_getcwd_succeeds_beyond_4k="guessing yes" ;;
+                   # Guess no otherwise, even on glibc systems.
+          *)       gl_cv_func_getcwd_succeeds_beyond_4k="guessing no"
         esac
        ])
     ])
-  case "$gl_cv_func_getcwd_abort_bug" in
-    *yes)
+  case "$gl_cv_func_getcwd_succeeds_beyond_4k" in
+    *no)
       $1
       ;;
     *)
-- 
2.7.4


[-- Attachment #6: 0005-include_next-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 2598 bytes --]

From 088335c21cc03f0034feec15fb63a2d8cef71625 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 14:46:42 +0200
Subject: [PATCH 3/3] include_next: Change configure message.

* m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source
code line length is unlimited..." instead of "checking whether system
header files limit the line length...".
---
 ChangeLog          |  7 +++++++
 m4/include_next.m4 | 18 ++++++++++--------
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index a4312ff..4e0cabe 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	include_next: Change configure message.
+	* m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source
+	code line length is unlimited..." instead of "checking whether system
+	header files limit the line length...".
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	getcwd: Change configure message.
 	* m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking
 	whether getcwd succeeds when 4k < cwd_length < 16k..." instead of
diff --git a/m4/include_next.m4 b/m4/include_next.m4
index 9009e29..aea1eb6 100644
--- a/m4/include_next.m4
+++ b/m4/include_next.m4
@@ -1,4 +1,4 @@
-# include_next.m4 serial 24
+# include_next.m4 serial 25
 dnl Copyright (C) 2006-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -106,19 +106,21 @@ dnl We intentionally avoid using AC_LANG_SOURCE here.
   AC_SUBST([INCLUDE_NEXT])
   AC_SUBST([INCLUDE_NEXT_AS_FIRST_DIRECTIVE])
   AC_SUBST([PRAGMA_SYSTEM_HEADER])
-  AC_CACHE_CHECK([whether system header files limit the line length],
-    [gl_cv_pragma_columns],
-    [dnl HP NonStop systems, which define __TANDEM, have this misfeature.
-     AC_EGREP_CPP([choke me],
+
+  dnl HP NonStop systems, which define __TANDEM, limit the line length
+  dnl after including some system header files.
+  AC_CACHE_CHECK([whether source code line length is unlimited],
+    [gl_cv_source_line_length_unlimited],
+    [AC_EGREP_CPP([choke me],
        [
 #ifdef __TANDEM
 choke me
 #endif
        ],
-       [gl_cv_pragma_columns=yes],
-       [gl_cv_pragma_columns=no])
+       [gl_cv_source_line_length_unlimited=no],
+       [gl_cv_source_line_length_unlimited=yes])
     ])
-  if test $gl_cv_pragma_columns = yes; then
+  if test $gl_cv_source_line_length_unlimited = no; then
     PRAGMA_COLUMNS="#pragma COLUMNS 10000"
   else
     PRAGMA_COLUMNS=
-- 
2.7.4


[-- Attachment #7: 0006-socketlib-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 2908 bytes --]

From 9782fc69a45566fe1a12fc464532ac9531c58d5e Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 15:49:17 +0200
Subject: [PATCH 1/4] socketlib: Change configure message.

* m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..."
instead of "checking if we need to call WSAStartup in winsock2.h and
-lws2_32...".
---
 ChangeLog       |  7 +++++++
 m4/socketlib.m4 | 32 +++++++++++++++++++-------------
 2 files changed, 26 insertions(+), 13 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0db1079..af2e20a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	socketlib: Change configure message.
+	* m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..."
+	instead of "checking if we need to call WSAStartup in winsock2.h and
+	-lws2_32...".
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	inttypes: Remove support for AIX 4.
 	* lib/inttypes.in.h: Assume that PRI_MACROS_BROKEN is 0.
 	* m4/inttypes-pri.m4: Remove file.
diff --git a/m4/socketlib.m4 b/m4/socketlib.m4
index 2372a27..48dd7d6 100644
--- a/m4/socketlib.m4
+++ b/m4/socketlib.m4
@@ -1,4 +1,4 @@
-# socketlib.m4 serial 2
+# socketlib.m4 serial 3
 dnl Copyright (C) 2008-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -14,21 +14,27 @@ AC_DEFUN([gl_SOCKETLIB],
   LIBSOCKET=
   if test $HAVE_WINSOCK2_H = 1; then
     dnl Native Windows API (not Cygwin).
-    AC_CACHE_CHECK([if we need to call WSAStartup in winsock2.h and -lws2_32],
-                   [gl_cv_func_wsastartup], [
-      gl_save_LIBS="$LIBS"
-      LIBS="$LIBS -lws2_32"
-      AC_LINK_IFELSE([AC_LANG_PROGRAM([[
+    dnl If the function WSAStartup exists (declared in <winsock2.h> and
+    dnl defined through -lws2_32), we need to call it.
+    AC_CACHE_CHECK([for WSAStartup],
+      [gl_cv_func_wsastartup], [
+       gl_save_LIBS="$LIBS"
+       LIBS="$LIBS -lws2_32"
+       AC_LINK_IFELSE(
+         [AC_LANG_PROGRAM([[
 #ifdef HAVE_WINSOCK2_H
 # include <winsock2.h>
 #endif]], [[
-          WORD wVersionRequested = MAKEWORD(1, 1);
-          WSADATA wsaData;
-          int err = WSAStartup(wVersionRequested, &wsaData);
-          WSACleanup ();]])],
-        gl_cv_func_wsastartup=yes, gl_cv_func_wsastartup=no)
-      LIBS="$gl_save_LIBS"
-    ])
+            WORD wVersionRequested = MAKEWORD(1, 1);
+            WSADATA wsaData;
+            int err = WSAStartup(wVersionRequested, &wsaData);
+            WSACleanup ();
+            ]])
+         ],
+         [gl_cv_func_wsastartup=yes],
+         [gl_cv_func_wsastartup=no])
+       LIBS="$gl_save_LIBS"
+      ])
     if test "$gl_cv_func_wsastartup" = "yes"; then
       AC_DEFINE([WINDOWS_SOCKETS], [1], [Define if WSAStartup is needed.])
       LIBSOCKET='-lws2_32'
-- 
2.7.4


[-- Attachment #8: 0007-stdint-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 3070 bytes --]

From e712b48a4791771a4d22acc68ec39fdbd985d738 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 16:04:03 +0200
Subject: [PATCH 2/4] stdint: Change configure message.

* m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works
without ISO C predefines..." instead of "checking whether stdint.h
predates C++11...".
---
 ChangeLog    |  7 +++++++
 m4/stdint.m4 | 18 ++++++++++--------
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index af2e20a..f9036ac 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	stdint: Change configure message.
+	* m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works
+	without ISO C predefines..." instead of "checking whether stdint.h
+	predates C++11...".
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	socketlib: Change configure message.
 	* m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..."
 	instead of "checking if we need to call WSAStartup in winsock2.h and
diff --git a/m4/stdint.m4 b/m4/stdint.m4
index 29ad826..0aed997 100644
--- a/m4/stdint.m4
+++ b/m4/stdint.m4
@@ -1,4 +1,4 @@
-# stdint.m4 serial 54
+# stdint.m4 serial 55
 dnl Copyright (C) 2001-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -302,9 +302,10 @@ static const char *macro_values[] =
       HAVE_C99_STDINT_H=1
       dnl Now see whether the system <stdint.h> works without
       dnl __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS defined.
-      AC_CACHE_CHECK([whether stdint.h predates C++11],
-        [gl_cv_header_stdint_predates_cxx11_h],
-        [gl_cv_header_stdint_predates_cxx11_h=yes
+      dnl If not, there would be problems when stdint.h is included from C++.
+      AC_CACHE_CHECK([whether stdint.h works without ISO C predefines],
+        [gl_cv_header_stdint_without_STDC_macros],
+        [gl_cv_header_stdint_without_STDC_macros=no
          AC_COMPILE_IFELSE([
            AC_LANG_PROGRAM([[
 #define _GL_JUST_INCLUDE_SYSTEM_STDINT_H 1 /* work if build isn't clean */
@@ -315,13 +316,14 @@ gl_STDINT_INCLUDES
 intmax_t im = INTMAX_MAX;
 int32_t i32 = INT32_C (0x7fffffff);
            ]])],
-           [gl_cv_header_stdint_predates_cxx11_h=no])])
+           [gl_cv_header_stdint_without_STDC_macros=yes])
+        ])
 
-      if test "$gl_cv_header_stdint_predates_cxx11_h" = yes; then
+      if test $gl_cv_header_stdint_without_STDC_macros = no; then
         AC_DEFINE([__STDC_CONSTANT_MACROS], [1],
-                  [Define to 1 if the system <stdint.h> predates C++11.])
+          [Define to 1 if the system <stdint.h> predates C++11.])
         AC_DEFINE([__STDC_LIMIT_MACROS], [1],
-                  [Define to 1 if the system <stdint.h> predates C++11.])
+          [Define to 1 if the system <stdint.h> predates C++11.])
       fi
       AC_CACHE_CHECK([whether stdint.h has UINTMAX_WIDTH etc.],
         [gl_cv_header_stdint_width],
-- 
2.7.4


[-- Attachment #9: 0008-time_rz-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 2545 bytes --]

From 0349dd4e8f7e867a6a03c94661c1ba9a553fd4c4 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 16:42:27 +0200
Subject: [PATCH 3/4] time_rz: Change configure message.

* m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even
near extrema..." instead of "checking whether localtime loops forever
near extrema...".
---
 ChangeLog     |  7 +++++++
 m4/time_rz.m4 | 14 +++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f9036ac..471e716 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	time_rz: Change configure message.
+	* m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even
+	near extrema..." instead of "checking whether localtime loops forever
+	near extrema...".
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	stdint: Change configure message.
 	* m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works
 	without ISO C predefines..." instead of "checking whether stdint.h
diff --git a/m4/time_rz.m4 b/m4/time_rz.m4
index 2dd64b2..30161c0 100644
--- a/m4/time_rz.m4
+++ b/m4/time_rz.m4
@@ -13,12 +13,12 @@ AC_DEFUN([gl_TIME_RZ],
   AC_REQUIRE([gl_HEADER_TIME_H_DEFAULTS])
   AC_REQUIRE([AC_STRUCT_TIMEZONE])
 
-  # Mac OS X 10.6 loops forever with some time_t values.
+  # On Mac OS X 10.6, localtime loops forever with some time_t values.
   # See Bug#27706, Bug#27736, and
   # https://lists.gnu.org/r/bug-gnulib/2017-07/msg00142.html
-  AC_CACHE_CHECK([whether localtime loops forever near extrema],
-    [gl_cv_func_localtime_infloop_bug],
-    [gl_cv_func_localtime_infloop_bug=no
+  AC_CACHE_CHECK([whether localtime works even near extrema],
+    [gl_cv_func_localtime_works],
+    [gl_cv_func_localtime_works=yes
      AC_RUN_IFELSE(
        [AC_LANG_PROGRAM(
           [[#include <stdlib.h>
@@ -37,10 +37,10 @@ AC_DEFUN([gl_TIME_RZ],
             return tm && tm->tm_isdst;
           ]])],
        [(TZ=QQQ0 ./conftest$EXEEXT) >/dev/null 2>&1 ||
-           gl_cv_func_localtime_infloop_bug=yes],
+           gl_cv_func_localtime_works=no],
        [],
-       [gl_cv_func_localtime_infloop_bug="guessing no"])])
-  if test "$gl_cv_func_localtime_infloop_bug" = yes; then
+       [gl_cv_func_localtime_works="guessing yes"])])
+  if test "$gl_cv_func_localtime_works" = no; then
       AC_DEFINE([HAVE_LOCALTIME_INFLOOP_BUG], 1,
         [Define if localtime-like functions can loop forever on
          extreme arguments.])
-- 
2.7.4


[-- Attachment #10: 0009-stdint-wchar-wctype-h-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 2423 bytes --]

From 039706de6b0c006d60b08c72744a6b04cbe4bea3 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sun, 26 Jul 2020 16:46:10 +0200
Subject: [PATCH 4/4] stdint, wchar, wctype-h: Change configure message.

* m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large
enough..." instead of "checking whether wint_t is too small...".
---
 ChangeLog    |  6 ++++++
 m4/wint_t.m4 | 12 ++++++------
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 471e716..5c074c5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2020-07-26  Bruno Haible  <bruno@clisp.org>
 
+	stdint, wchar, wctype-h: Change configure message.
+	* m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large
+	enough..." instead of "checking whether wint_t is too small...".
+
+2020-07-26  Bruno Haible  <bruno@clisp.org>
+
 	time_rz: Change configure message.
 	* m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even
 	near extrema..." instead of "checking whether localtime loops forever
diff --git a/m4/wint_t.m4 b/m4/wint_t.m4
index 5e6c178..cf9764d 100644
--- a/m4/wint_t.m4
+++ b/m4/wint_t.m4
@@ -1,4 +1,4 @@
-# wint_t.m4 serial 8
+# wint_t.m4 serial 9
 dnl Copyright (C) 2003, 2007-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -32,8 +32,8 @@ AC_DEFUN([gt_TYPE_WINT_T],
 
     dnl Determine whether gnulib's <wchar.h> or <wctype.h> would, if present,
     dnl override 'wint_t'.
-    AC_CACHE_CHECK([whether wint_t is too small],
-      [gl_cv_type_wint_t_too_small],
+    AC_CACHE_CHECK([whether wint_t is large enough],
+      [gl_cv_type_wint_t_large_enough],
       [AC_COMPILE_IFELSE(
          [AC_LANG_PROGRAM([[
 /* Tru64 with Desktop Toolkit C has a bug: <stdio.h> must be included before
@@ -48,9 +48,9 @@ AC_DEFUN([gt_TYPE_WINT_T],
 #include <wchar.h>
             int verify[sizeof (wint_t) < sizeof (int) ? -1 : 1];
             ]])],
-         [gl_cv_type_wint_t_too_small=no],
-         [gl_cv_type_wint_t_too_small=yes])])
-    if test $gl_cv_type_wint_t_too_small = yes; then
+         [gl_cv_type_wint_t_large_enough=yes],
+         [gl_cv_type_wint_t_large_enough=no])])
+    if test $gl_cv_type_wint_t_large_enough = no; then
       GNULIB_OVERRIDES_WINT_T=1
     else
       GNULIB_OVERRIDES_WINT_T=0
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: configure messages: check for features, not for bugs
  2020-07-26 15:02 configure messages: check for features, not for bugs Bruno Haible
@ 2020-07-26 18:05 ` Paul Eggert
  2020-08-26 23:32   ` Bruno Haible
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2020-07-26 18:05 UTC (permalink / raw)
  To: Bruno Haible, bug-gnulib

On 7/26/20 8:02 AM, Bruno Haible wrote:
> Does anyone see a problem with this? Here is a proposed set of patches.

I like this change, and don't see a problem with it. Thanks for doing that.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: configure messages: check for features, not for bugs
  2020-07-26 18:05 ` Paul Eggert
@ 2020-08-26 23:32   ` Bruno Haible
  0 siblings, 0 replies; 3+ messages in thread
From: Bruno Haible @ 2020-08-26 23:32 UTC (permalink / raw)
  To: Paul Eggert; +Cc: bug-gnulib

[-- Attachment #1: Type: text/plain, Size: 2679 bytes --]

On 2020-07-26 we discussed:
> > Does anyone see a problem with this? Here is a proposed set of patches.
> 
> I like this change, and don't see a problem with it. Thanks for doing that.

After a bit of testing of these changes, I pushed them.


2020-08-26  Bruno Haible  <bruno@clisp.org>

	stdint, wchar, wctype-h: Change configure message.
	* m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large
	enough..." instead of "checking whether wint_t is too small...".

2020-08-26  Bruno Haible  <bruno@clisp.org>

	time_rz: Change configure message.
	* m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even
	near extrema..." instead of "checking whether localtime loops forever
	near extrema...".

2020-08-26  Bruno Haible  <bruno@clisp.org>

	stdint: Change configure message.
	* m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works
	without ISO C predefines..." instead of "checking whether stdint.h
	predates C++11...".

2020-08-26  Bruno Haible  <bruno@clisp.org>

	socketlib: Change configure message.
	* m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..."
	instead of "checking if we need to call WSAStartup in winsock2.h and
	-lws2_32...".

2020-08-26  Bruno Haible  <bruno@clisp.org>

	include_next: Change configure message.
	* m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source
	code line length is unlimited..." instead of "checking whether system
	header files limit the line length...".

2020-08-26  Bruno Haible  <bruno@clisp.org>

	getcwd: Change configure message.
	* m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking
	whether getcwd succeeds when 4k < cwd_length < 16k..." instead of
	"checking whether getcwd aborts when 4k < cwd_length < 16k...".

2020-08-26  Bruno Haible  <bruno@clisp.org>

	chdir-long: Change configure message.
	* m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this
	system supports file names of any length..." instead of "checking
	whether this system has an arbitrary file name length limit...".
	Set gl_cv_have_unlimited_file_name_length instead of
	gl_cv_have_arbitrary_file_name_length_limit.
	* modules/chdir-long (Depends-on, configure.ac): Update accordingly.

2020-08-26  Bruno Haible  <bruno@clisp.org>

	ceill: Change configure message.
	* m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..."
	instead of "checking whether ceill() breaks with small values...".

2020-08-26  Bruno Haible  <bruno@clisp.org>

	iconv: Change configure message.
	* m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible
	with its POSIX signature..." instead of "checking for iconv
	declaration...". Remove K&R C support.



[-- Attachment #2: 0001-iconv-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 3718 bytes --]

From 9b2c74424c6dc4d1f61e74c668afcbadb717f176 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 00:42:22 +0200
Subject: [PATCH 1/9] iconv: Change configure message.

* m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible
with its POSIX signature..." instead of "checking for iconv
declaration...". Remove K&R C support.
---
 ChangeLog   |  7 +++++++
 m4/iconv.m4 | 44 +++++++++++++++++++++++---------------------
 2 files changed, 30 insertions(+), 21 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ada6bdf..73b7b60 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
+	iconv: Change configure message.
+	* m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible
+	with its POSIX signature..." instead of "checking for iconv
+	declaration...". Remove K&R C support.
+
 2020-08-26  Paul Eggert  <eggert@cs.ucla.edu>
 
 	getcwd: help the merge back into glibc
diff --git a/m4/iconv.m4 b/m4/iconv.m4
index 67dbfed..f8a536b 100644
--- a/m4/iconv.m4
+++ b/m4/iconv.m4
@@ -1,4 +1,4 @@
-# iconv.m4 serial 22
+# iconv.m4 serial 23
 dnl Copyright (C) 2000-2002, 2007-2014, 2016-2020 Free Software Foundation,
 dnl Inc.
 dnl This file is free software; the Free Software Foundation
@@ -9,6 +9,10 @@ dnl From Bruno Haible.
 
 AC_PREREQ([2.64])
 
+dnl Note: AM_ICONV is documented in the GNU gettext manual
+dnl <https://www.gnu.org/software/gettext/manual/html_node/AM_005fICONV.html>.
+dnl Don't make changes that are incompatible with that documentation!
+
 AC_DEFUN([AM_ICONV_LINKFLAGS_BODY],
 [
   dnl Prerequisites of AC_LIB_LINKFLAGS_BODY.
@@ -239,41 +243,39 @@ AC_DEFUN_ONCE([AM_ICONV],
 [
   AM_ICONV_LINK
   if test "$am_cv_func_iconv" = yes; then
-    AC_MSG_CHECKING([for iconv declaration])
-    AC_CACHE_VAL([am_cv_proto_iconv], [
-      AC_COMPILE_IFELSE(
-        [AC_LANG_PROGRAM(
-           [[
+    AC_CACHE_CHECK([whether iconv is compatible with its POSIX signature],
+      [gl_cv_iconv_nonconst],
+      [AC_COMPILE_IFELSE(
+         [AC_LANG_PROGRAM(
+            [[
 #include <stdlib.h>
 #include <iconv.h>
 extern
 #ifdef __cplusplus
 "C"
 #endif
-#if defined(__STDC__) || defined(_MSC_VER) || defined(__cplusplus)
 size_t iconv (iconv_t cd, char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);
-#else
-size_t iconv();
-#endif
-           ]],
-           [[]])],
-        [am_cv_proto_iconv_arg1=""],
-        [am_cv_proto_iconv_arg1="const"])
-      am_cv_proto_iconv="extern size_t iconv (iconv_t cd, $am_cv_proto_iconv_arg1 char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);"])
-    am_cv_proto_iconv=`echo "[$]am_cv_proto_iconv" | tr -s ' ' | sed -e 's/( /(/'`
-    AC_MSG_RESULT([
-         $am_cv_proto_iconv])
+            ]],
+            [[]])],
+         [gl_cv_iconv_nonconst=yes],
+         [gl_cv_iconv_nonconst=no])
+      ])
   else
     dnl When compiling GNU libiconv on a system that does not have iconv yet,
     dnl pick the POSIX compliant declaration without 'const'.
-    am_cv_proto_iconv_arg1=""
+    gl_cv_iconv_nonconst=yes
+  fi
+  if test $gl_cv_iconv_nonconst = yes; then
+    iconv_arg1=""
+  else
+    iconv_arg1="const"
   fi
-  AC_DEFINE_UNQUOTED([ICONV_CONST], [$am_cv_proto_iconv_arg1],
+  AC_DEFINE_UNQUOTED([ICONV_CONST], [$iconv_arg1],
     [Define as const if the declaration of iconv() needs const.])
   dnl Also substitute ICONV_CONST in the gnulib generated <iconv.h>.
   m4_ifdef([gl_ICONV_H_DEFAULTS],
     [AC_REQUIRE([gl_ICONV_H_DEFAULTS])
-     if test -n "$am_cv_proto_iconv_arg1"; then
+     if test $gl_cv_iconv_nonconst != yes; then
        ICONV_CONST="const"
      fi
     ])
-- 
2.7.4


[-- Attachment #3: 0002-ceill-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 3425 bytes --]

From eb699621456971095297e26164a61ad2f4e7c672 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 00:47:22 +0200
Subject: [PATCH 2/9] ceill: Change configure message.

* m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..."
instead of "checking whether ceill() breaks with small values...".
---
 ChangeLog   |  6 ++++++
 m4/ceill.m4 | 48 ++++++++++++++++++++++++------------------------
 2 files changed, 30 insertions(+), 24 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 73b7b60..5d6b852 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2020-08-26  Bruno Haible  <bruno@clisp.org>
 
+	ceill: Change configure message.
+	* m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..."
+	instead of "checking whether ceill() breaks with small values...".
+
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
 	iconv: Change configure message.
 	* m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible
 	with its POSIX signature..." instead of "checking for iconv
diff --git a/m4/ceill.m4 b/m4/ceill.m4
index 806c4e6..3428530 100644
--- a/m4/ceill.m4
+++ b/m4/ceill.m4
@@ -1,4 +1,4 @@
-# ceill.m4 serial 21
+# ceill.m4 serial 22
 dnl Copyright (C) 2007, 2009-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -74,31 +74,31 @@ int main (int argc, char *argv[])
     HAVE_DECL_CEILL=0
   fi
   dnl On OpenBSD 5.6 the system's native ceill() is buggy:
-  dnl it returns '0' for small values. Test for this anomaly.
+  dnl it returns '0' for small values. Test against this anomaly.
   if test $REPLACE_CEILL = 0 ; then
-    AC_CACHE_CHECK([whether ceill() breaks with small values],
-        [gl_cv_func_ceill_buggy],
-        [
-          save_LIBS="$LIBS"
-          LIBS="$CEILL_LIBM"
-          AC_RUN_IFELSE(
-           [AC_LANG_PROGRAM(
-             [[#include <math.h>
+    AC_CACHE_CHECK([whether ceill() works],
+      [gl_cv_func_ceill_works],
+      [save_LIBS="$LIBS"
+       LIBS="$CEILL_LIBM"
+       AC_RUN_IFELSE(
+         [AC_LANG_PROGRAM(
+            [[#include <math.h>
 long double d = 0.3L;]],
-             [[return (!(ceill (d) == 1)); ]])],
-             [gl_cv_func_ceill_buggy=no], [gl_cv_func_ceill_buggy=yes],
-             [case "$host_os" in
-                openbsd*) gl_cv_func_ceill_buggy="guessing yes" ;;
-                          # Guess no on native Windows.
-                mingw*)   gl_cv_func_ceill_buggy="guessing no" ;;
-                *)        gl_cv_func_ceill_buggy="guessing no" ;;
-              esac
-             ])
-          LIBS="$save_LIBS"
-        ])
-    case "$gl_cv_func_ceill_buggy" in
-      *yes)
-        REPLACE_CEILL=1 ;;
+            [[return (!(ceill (d) == 1)); ]])],
+         [gl_cv_func_ceill_works=yes],
+         [gl_cv_func_ceill_works=no],
+         [case "$host_os" in
+            openbsd*) gl_cv_func_ceill_works="guessing no" ;;
+                      # Guess yes on native Windows.
+            mingw*)   gl_cv_func_ceill_works="guessing yes" ;;
+            *)        gl_cv_func_ceill_works="guessing yes" ;;
+          esac
+         ])
+       LIBS="$save_LIBS"
+      ])
+    case "$gl_cv_func_ceill_works" in
+      *yes) ;;
+      *) REPLACE_CEILL=1 ;;
     esac
   fi
   if test $HAVE_DECL_CEILL = 0 || test $REPLACE_CEILL = 1; then
-- 
2.7.4


[-- Attachment #4: 0003-chdir-long-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 4518 bytes --]

From a84b18e48e2384ceeb8e4e2cd3784e18efb1537b Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 00:49:28 +0200
Subject: [PATCH 3/9] chdir-long: Change configure message.

* m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this
system supports file names of any length..." instead of "checking
whether this system has an arbitrary file name length limit...".
Set gl_cv_have_unlimited_file_name_length instead of
gl_cv_have_arbitrary_file_name_length_limit.
* modules/chdir-long (Depends-on, configure.ac): Update accordingly.
---
 ChangeLog          | 10 ++++++++++
 m4/chdir-long.m4   | 10 +++++-----
 modules/chdir-long | 22 +++++++++++-----------
 3 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5d6b852..7ac92db 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
 2020-08-26  Bruno Haible  <bruno@clisp.org>
 
+	chdir-long: Change configure message.
+	* m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this
+	system supports file names of any length..." instead of "checking
+	whether this system has an arbitrary file name length limit...".
+	Set gl_cv_have_unlimited_file_name_length instead of
+	gl_cv_have_arbitrary_file_name_length_limit.
+	* modules/chdir-long (Depends-on, configure.ac): Update accordingly.
+
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
 	ceill: Change configure message.
 	* m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..."
 	instead of "checking whether ceill() breaks with small values...".
diff --git a/m4/chdir-long.m4 b/m4/chdir-long.m4
index a528a5d..a6e67b5 100644
--- a/m4/chdir-long.m4
+++ b/m4/chdir-long.m4
@@ -1,4 +1,4 @@
-#serial 16
+#serial 17
 
 # Use Gnulib's robust chdir function.
 # It can handle arbitrarily long directory names, which means
@@ -16,15 +16,15 @@ dnl with or without modifications, as long as this notice is preserved.
 AC_DEFUN([gl_FUNC_CHDIR_LONG],
 [
   AC_REQUIRE([gl_PATHMAX_SNIPPET_PREREQ])
-  AC_CACHE_CHECK([whether this system has an arbitrary file name length limit],
-    [gl_cv_have_arbitrary_file_name_length_limit],
+  AC_CACHE_CHECK([whether this system supports file names of any length],
+    [gl_cv_have_unlimited_file_name_length],
     [AC_EGREP_CPP([have_arbitrary_file_name_length_limit],
                   gl_PATHMAX_SNIPPET[
 #ifdef PATH_MAX
 have_arbitrary_file_name_length_limit
 #endif],
-    [gl_cv_have_arbitrary_file_name_length_limit=yes],
-    [gl_cv_have_arbitrary_file_name_length_limit=no])])
+    [gl_cv_have_unlimited_file_name_length=no],
+    [gl_cv_have_unlimited_file_name_length=yes])])
 ])
 
 AC_DEFUN([gl_PREREQ_CHDIR_LONG], [:])
diff --git a/modules/chdir-long b/modules/chdir-long
index 82d4e8b..3cab294 100644
--- a/modules/chdir-long
+++ b/modules/chdir-long
@@ -11,20 +11,20 @@ Depends-on:
 unistd
 pathmax
 chdir
-assure          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-atexit          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-fchdir          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-fcntl-h         [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-openat          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-memchr          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-mempcpy         [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-memrchr         [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-stdbool         [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
-stdlib          [test $gl_cv_have_arbitrary_file_name_length_limit = yes]
+assure          [test $gl_cv_have_unlimited_file_name_length = no]
+atexit          [test $gl_cv_have_unlimited_file_name_length = no]
+fchdir          [test $gl_cv_have_unlimited_file_name_length = no]
+fcntl-h         [test $gl_cv_have_unlimited_file_name_length = no]
+openat          [test $gl_cv_have_unlimited_file_name_length = no]
+memchr          [test $gl_cv_have_unlimited_file_name_length = no]
+mempcpy         [test $gl_cv_have_unlimited_file_name_length = no]
+memrchr         [test $gl_cv_have_unlimited_file_name_length = no]
+stdbool         [test $gl_cv_have_unlimited_file_name_length = no]
+stdlib          [test $gl_cv_have_unlimited_file_name_length = no]
 
 configure.ac:
 gl_FUNC_CHDIR_LONG
-if test $gl_cv_have_arbitrary_file_name_length_limit = yes; then
+if test $gl_cv_have_unlimited_file_name_length = no; then
   AC_LIBOBJ([chdir-long])
   gl_PREREQ_CHDIR_LONG
 fi
-- 
2.7.4


[-- Attachment #5: 0004-getcwd-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 3826 bytes --]

From fadf8937474ce0faa0cd2e446ce6b3677ff900e2 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 00:56:09 +0200
Subject: [PATCH 4/9] getcwd: Change configure message.

* m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking
whether getcwd succeeds when 4k < cwd_length < 16k..." instead of
"checking whether getcwd aborts when 4k < cwd_length < 16k...".
---
 ChangeLog              |  7 +++++++
 m4/getcwd-abort-bug.m4 | 26 +++++++++++++-------------
 2 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 7ac92db..eb7ef9b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-08-26  Bruno Haible  <bruno@clisp.org>
 
+	getcwd: Change configure message.
+	* m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking
+	whether getcwd succeeds when 4k < cwd_length < 16k..." instead of
+	"checking whether getcwd aborts when 4k < cwd_length < 16k...".
+
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
 	chdir-long: Change configure message.
 	* m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this
 	system supports file names of any length..." instead of "checking
diff --git a/m4/getcwd-abort-bug.m4 b/m4/getcwd-abort-bug.m4
index 9817912..b5cf86e 100644
--- a/m4/getcwd-abort-bug.m4
+++ b/m4/getcwd-abort-bug.m4
@@ -1,4 +1,4 @@
-# serial 14
+# serial 15
 # Determine whether getcwd aborts when the length of the working directory
 # name is unusually large.  Any length between 4k and 16k trigger the bug
 # when using glibc-2.4.90-9 or older.
@@ -10,7 +10,7 @@
 
 # From Jim Meyering
 
-# gl_FUNC_GETCWD_ABORT_BUG([ACTION-IF-FOUND[, ACTION-IF-NOT-FOUND]])
+# gl_FUNC_GETCWD_ABORT_BUG([ACTION-IF-BUGGY[, ACTION-IF-WORKS]])
 AC_DEFUN([gl_FUNC_GETCWD_ABORT_BUG],
 [
   AC_REQUIRE([AC_CANONICAL_HOST]) dnl for cross-compiles
@@ -24,8 +24,8 @@ AC_DEFUN([gl_FUNC_GETCWD_ABORT_BUG],
       [Define to 1 if the system has the 'getpagesize' function.])
   fi
 
-  AC_CACHE_CHECK([whether getcwd aborts when 4k < cwd_length < 16k],
-    [gl_cv_func_getcwd_abort_bug],
+  AC_CACHE_CHECK([whether getcwd succeeds when 4k < cwd_length < 16k],
+    [gl_cv_func_getcwd_succeeds_beyond_4k],
     [# Remove any remnants of a previous test.
      rm -rf confdir-14B---
      # Arrange for deletion of the temporary directory this test creates.
@@ -126,7 +126,7 @@ main ()
   return fail;
 }
           ]])],
-       [gl_cv_func_getcwd_abort_bug=no],
+       [gl_cv_func_getcwd_succeeds_beyond_4k=yes],
        [dnl An abort will provoke an exit code of something like 134 (128 + 6).
         dnl An exit code of 4 can also occur (in OpenBSD 6.7, NetBSD 5.1 for
         dnl example): getcwd (NULL, 0) fails rather than returning a string
@@ -135,21 +135,21 @@ main ()
         dnl provide a non-NULL value in this case.
         ret=$?
         if test $ret -ge 128 || test $ret = 4; then
-          gl_cv_func_getcwd_abort_bug=yes
+          gl_cv_func_getcwd_succeeds_beyond_4k=no
         else
-          gl_cv_func_getcwd_abort_bug=no
+          gl_cv_func_getcwd_succeeds_beyond_4k=yes
         fi
        ],
        [case "$host_os" in
-                   # Guess no on musl systems.
-          *-musl*) gl_cv_func_getcwd_abort_bug="guessing no" ;;
-                   # Guess yes otherwise, even on glibc systems.
-          *)       gl_cv_func_getcwd_abort_bug="guessing yes"
+                   # Guess yes on musl systems.
+          *-musl*) gl_cv_func_getcwd_succeeds_beyond_4k="guessing yes" ;;
+                   # Guess no otherwise, even on glibc systems.
+          *)       gl_cv_func_getcwd_succeeds_beyond_4k="guessing no"
         esac
        ])
     ])
-  case "$gl_cv_func_getcwd_abort_bug" in
-    *yes)
+  case "$gl_cv_func_getcwd_succeeds_beyond_4k" in
+    *no)
       $1
       ;;
     *)
-- 
2.7.4


[-- Attachment #6: 0005-include_next-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 2598 bytes --]

From a7bdbd1d4cdca3c7f3b951f0ce551040a90cf5cd Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 01:04:36 +0200
Subject: [PATCH 5/9] include_next: Change configure message.

* m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source
code line length is unlimited..." instead of "checking whether system
header files limit the line length...".
---
 ChangeLog          |  7 +++++++
 m4/include_next.m4 | 18 ++++++++++--------
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index eb7ef9b..6f32743 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-08-26  Bruno Haible  <bruno@clisp.org>
 
+	include_next: Change configure message.
+	* m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source
+	code line length is unlimited..." instead of "checking whether system
+	header files limit the line length...".
+
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
 	getcwd: Change configure message.
 	* m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking
 	whether getcwd succeeds when 4k < cwd_length < 16k..." instead of
diff --git a/m4/include_next.m4 b/m4/include_next.m4
index 33601aa..9221d9f 100644
--- a/m4/include_next.m4
+++ b/m4/include_next.m4
@@ -1,4 +1,4 @@
-# include_next.m4 serial 25
+# include_next.m4 serial 26
 dnl Copyright (C) 2006-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -106,19 +106,21 @@ dnl We intentionally avoid using AC_LANG_SOURCE here.
   AC_SUBST([INCLUDE_NEXT])
   AC_SUBST([INCLUDE_NEXT_AS_FIRST_DIRECTIVE])
   AC_SUBST([PRAGMA_SYSTEM_HEADER])
-  AC_CACHE_CHECK([whether system header files limit the line length],
-    [gl_cv_pragma_columns],
-    [dnl HP NonStop systems, which define __TANDEM, have this misfeature.
-     AC_EGREP_CPP([choke me],
+
+  dnl HP NonStop systems, which define __TANDEM, limit the line length
+  dnl after including some system header files.
+  AC_CACHE_CHECK([whether source code line length is unlimited],
+    [gl_cv_source_line_length_unlimited],
+    [AC_EGREP_CPP([choke me],
        [
 #ifdef __TANDEM
 choke me
 #endif
        ],
-       [gl_cv_pragma_columns=yes],
-       [gl_cv_pragma_columns=no])
+       [gl_cv_source_line_length_unlimited=no],
+       [gl_cv_source_line_length_unlimited=yes])
     ])
-  if test $gl_cv_pragma_columns = yes; then
+  if test $gl_cv_source_line_length_unlimited = no; then
     PRAGMA_COLUMNS="#pragma COLUMNS 10000"
   else
     PRAGMA_COLUMNS=
-- 
2.7.4


[-- Attachment #7: 0006-socketlib-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 2959 bytes --]

From f7a517ac04e5186da5d0b3c0727a0cb8dc5cb214 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 01:09:20 +0200
Subject: [PATCH 6/9] socketlib: Change configure message.

* m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..."
instead of "checking if we need to call WSAStartup in winsock2.h and
-lws2_32...".
---
 ChangeLog       |  7 +++++++
 m4/socketlib.m4 | 32 +++++++++++++++++++-------------
 2 files changed, 26 insertions(+), 13 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6f32743..47846b6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-08-26  Bruno Haible  <bruno@clisp.org>
 
+	socketlib: Change configure message.
+	* m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..."
+	instead of "checking if we need to call WSAStartup in winsock2.h and
+	-lws2_32...".
+
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
 	include_next: Change configure message.
 	* m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source
 	code line length is unlimited..." instead of "checking whether system
diff --git a/m4/socketlib.m4 b/m4/socketlib.m4
index 2372a27..48dd7d6 100644
--- a/m4/socketlib.m4
+++ b/m4/socketlib.m4
@@ -1,4 +1,4 @@
-# socketlib.m4 serial 2
+# socketlib.m4 serial 3
 dnl Copyright (C) 2008-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -14,21 +14,27 @@ AC_DEFUN([gl_SOCKETLIB],
   LIBSOCKET=
   if test $HAVE_WINSOCK2_H = 1; then
     dnl Native Windows API (not Cygwin).
-    AC_CACHE_CHECK([if we need to call WSAStartup in winsock2.h and -lws2_32],
-                   [gl_cv_func_wsastartup], [
-      gl_save_LIBS="$LIBS"
-      LIBS="$LIBS -lws2_32"
-      AC_LINK_IFELSE([AC_LANG_PROGRAM([[
+    dnl If the function WSAStartup exists (declared in <winsock2.h> and
+    dnl defined through -lws2_32), we need to call it.
+    AC_CACHE_CHECK([for WSAStartup],
+      [gl_cv_func_wsastartup], [
+       gl_save_LIBS="$LIBS"
+       LIBS="$LIBS -lws2_32"
+       AC_LINK_IFELSE(
+         [AC_LANG_PROGRAM([[
 #ifdef HAVE_WINSOCK2_H
 # include <winsock2.h>
 #endif]], [[
-          WORD wVersionRequested = MAKEWORD(1, 1);
-          WSADATA wsaData;
-          int err = WSAStartup(wVersionRequested, &wsaData);
-          WSACleanup ();]])],
-        gl_cv_func_wsastartup=yes, gl_cv_func_wsastartup=no)
-      LIBS="$gl_save_LIBS"
-    ])
+            WORD wVersionRequested = MAKEWORD(1, 1);
+            WSADATA wsaData;
+            int err = WSAStartup(wVersionRequested, &wsaData);
+            WSACleanup ();
+            ]])
+         ],
+         [gl_cv_func_wsastartup=yes],
+         [gl_cv_func_wsastartup=no])
+       LIBS="$gl_save_LIBS"
+      ])
     if test "$gl_cv_func_wsastartup" = "yes"; then
       AC_DEFINE([WINDOWS_SOCKETS], [1], [Define if WSAStartup is needed.])
       LIBSOCKET='-lws2_32'
-- 
2.7.4


[-- Attachment #8: 0007-stdint-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 3070 bytes --]

From 5ed052320923259225ba80b41f1840b46b713501 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 01:21:27 +0200
Subject: [PATCH 7/9] stdint: Change configure message.

* m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works
without ISO C predefines..." instead of "checking whether stdint.h
predates C++11...".
---
 ChangeLog    |  7 +++++++
 m4/stdint.m4 | 18 ++++++++++--------
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 47846b6..06a9514 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-08-26  Bruno Haible  <bruno@clisp.org>
 
+	stdint: Change configure message.
+	* m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works
+	without ISO C predefines..." instead of "checking whether stdint.h
+	predates C++11...".
+
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
 	socketlib: Change configure message.
 	* m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..."
 	instead of "checking if we need to call WSAStartup in winsock2.h and
diff --git a/m4/stdint.m4 b/m4/stdint.m4
index e0fa8a5..d5f5d61 100644
--- a/m4/stdint.m4
+++ b/m4/stdint.m4
@@ -1,4 +1,4 @@
-# stdint.m4 serial 55
+# stdint.m4 serial 56
 dnl Copyright (C) 2001-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -302,9 +302,10 @@ static const char *macro_values[] =
       HAVE_C99_STDINT_H=1
       dnl Now see whether the system <stdint.h> works without
       dnl __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS defined.
-      AC_CACHE_CHECK([whether stdint.h predates C++11],
-        [gl_cv_header_stdint_predates_cxx11_h],
-        [gl_cv_header_stdint_predates_cxx11_h=yes
+      dnl If not, there would be problems when stdint.h is included from C++.
+      AC_CACHE_CHECK([whether stdint.h works without ISO C predefines],
+        [gl_cv_header_stdint_without_STDC_macros],
+        [gl_cv_header_stdint_without_STDC_macros=no
          AC_COMPILE_IFELSE([
            AC_LANG_PROGRAM([[
 #define _GL_JUST_INCLUDE_SYSTEM_STDINT_H 1 /* work if build isn't clean */
@@ -315,13 +316,14 @@ gl_STDINT_INCLUDES
 intmax_t im = INTMAX_MAX;
 int32_t i32 = INT32_C (0x7fffffff);
            ]])],
-           [gl_cv_header_stdint_predates_cxx11_h=no])])
+           [gl_cv_header_stdint_without_STDC_macros=yes])
+        ])
 
-      if test "$gl_cv_header_stdint_predates_cxx11_h" = yes; then
+      if test $gl_cv_header_stdint_without_STDC_macros = no; then
         AC_DEFINE([__STDC_CONSTANT_MACROS], [1],
-                  [Define to 1 if the system <stdint.h> predates C++11.])
+          [Define to 1 if the system <stdint.h> predates C++11.])
         AC_DEFINE([__STDC_LIMIT_MACROS], [1],
-                  [Define to 1 if the system <stdint.h> predates C++11.])
+          [Define to 1 if the system <stdint.h> predates C++11.])
       fi
       AC_CACHE_CHECK([whether stdint.h has UINTMAX_WIDTH etc.],
         [gl_cv_header_stdint_width],
-- 
2.7.4


[-- Attachment #9: 0008-time_rz-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 2545 bytes --]

From a1e10e28d2fcc16f8fdcefd26ad2b325f90aff93 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 01:23:55 +0200
Subject: [PATCH 8/9] time_rz: Change configure message.

* m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even
near extrema..." instead of "checking whether localtime loops forever
near extrema...".
---
 ChangeLog     |  7 +++++++
 m4/time_rz.m4 | 14 +++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 06a9514..b832520 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2020-08-26  Bruno Haible  <bruno@clisp.org>
 
+	time_rz: Change configure message.
+	* m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even
+	near extrema..." instead of "checking whether localtime loops forever
+	near extrema...".
+
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
 	stdint: Change configure message.
 	* m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works
 	without ISO C predefines..." instead of "checking whether stdint.h
diff --git a/m4/time_rz.m4 b/m4/time_rz.m4
index 2dd64b2..30161c0 100644
--- a/m4/time_rz.m4
+++ b/m4/time_rz.m4
@@ -13,12 +13,12 @@ AC_DEFUN([gl_TIME_RZ],
   AC_REQUIRE([gl_HEADER_TIME_H_DEFAULTS])
   AC_REQUIRE([AC_STRUCT_TIMEZONE])
 
-  # Mac OS X 10.6 loops forever with some time_t values.
+  # On Mac OS X 10.6, localtime loops forever with some time_t values.
   # See Bug#27706, Bug#27736, and
   # https://lists.gnu.org/r/bug-gnulib/2017-07/msg00142.html
-  AC_CACHE_CHECK([whether localtime loops forever near extrema],
-    [gl_cv_func_localtime_infloop_bug],
-    [gl_cv_func_localtime_infloop_bug=no
+  AC_CACHE_CHECK([whether localtime works even near extrema],
+    [gl_cv_func_localtime_works],
+    [gl_cv_func_localtime_works=yes
      AC_RUN_IFELSE(
        [AC_LANG_PROGRAM(
           [[#include <stdlib.h>
@@ -37,10 +37,10 @@ AC_DEFUN([gl_TIME_RZ],
             return tm && tm->tm_isdst;
           ]])],
        [(TZ=QQQ0 ./conftest$EXEEXT) >/dev/null 2>&1 ||
-           gl_cv_func_localtime_infloop_bug=yes],
+           gl_cv_func_localtime_works=no],
        [],
-       [gl_cv_func_localtime_infloop_bug="guessing no"])])
-  if test "$gl_cv_func_localtime_infloop_bug" = yes; then
+       [gl_cv_func_localtime_works="guessing yes"])])
+  if test "$gl_cv_func_localtime_works" = no; then
       AC_DEFINE([HAVE_LOCALTIME_INFLOOP_BUG], 1,
         [Define if localtime-like functions can loop forever on
          extreme arguments.])
-- 
2.7.4


[-- Attachment #10: 0009-stdint-wchar-wctype-h-Change-configure-message.patch --]
[-- Type: text/x-patch, Size: 2423 bytes --]

From 37ccbbb9018e2c366ed0b01fba805915a64cc8d9 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 27 Aug 2020 01:27:21 +0200
Subject: [PATCH 9/9] stdint, wchar, wctype-h: Change configure message.

* m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large
enough..." instead of "checking whether wint_t is too small...".
---
 ChangeLog    |  6 ++++++
 m4/wint_t.m4 | 12 ++++++------
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index b832520..309f0cf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2020-08-26  Bruno Haible  <bruno@clisp.org>
 
+	stdint, wchar, wctype-h: Change configure message.
+	* m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large
+	enough..." instead of "checking whether wint_t is too small...".
+
+2020-08-26  Bruno Haible  <bruno@clisp.org>
+
 	time_rz: Change configure message.
 	* m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even
 	near extrema..." instead of "checking whether localtime loops forever
diff --git a/m4/wint_t.m4 b/m4/wint_t.m4
index 5e6c178..cf9764d 100644
--- a/m4/wint_t.m4
+++ b/m4/wint_t.m4
@@ -1,4 +1,4 @@
-# wint_t.m4 serial 8
+# wint_t.m4 serial 9
 dnl Copyright (C) 2003, 2007-2020 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -32,8 +32,8 @@ AC_DEFUN([gt_TYPE_WINT_T],
 
     dnl Determine whether gnulib's <wchar.h> or <wctype.h> would, if present,
     dnl override 'wint_t'.
-    AC_CACHE_CHECK([whether wint_t is too small],
-      [gl_cv_type_wint_t_too_small],
+    AC_CACHE_CHECK([whether wint_t is large enough],
+      [gl_cv_type_wint_t_large_enough],
       [AC_COMPILE_IFELSE(
          [AC_LANG_PROGRAM([[
 /* Tru64 with Desktop Toolkit C has a bug: <stdio.h> must be included before
@@ -48,9 +48,9 @@ AC_DEFUN([gt_TYPE_WINT_T],
 #include <wchar.h>
             int verify[sizeof (wint_t) < sizeof (int) ? -1 : 1];
             ]])],
-         [gl_cv_type_wint_t_too_small=no],
-         [gl_cv_type_wint_t_too_small=yes])])
-    if test $gl_cv_type_wint_t_too_small = yes; then
+         [gl_cv_type_wint_t_large_enough=yes],
+         [gl_cv_type_wint_t_large_enough=no])])
+    if test $gl_cv_type_wint_t_large_enough = no; then
       GNULIB_OVERRIDES_WINT_T=1
     else
       GNULIB_OVERRIDES_WINT_T=0
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-26 23:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-26 15:02 configure messages: check for features, not for bugs Bruno Haible
2020-07-26 18:05 ` Paul Eggert
2020-08-26 23:32   ` Bruno Haible

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).