From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D08FB1F66E for ; Wed, 26 Aug 2020 23:33:04 +0000 (UTC) Received: from localhost ([::1]:53644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kB4ud-0000We-NY for normalperson@yhbt.net; Wed, 26 Aug 2020 19:33:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB4ua-0000Uy-Nz for bug-gnulib@gnu.org; Wed, 26 Aug 2020 19:33:00 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:20693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB4uW-0001Dl-NJ for bug-gnulib@gnu.org; Wed, 26 Aug 2020 19:33:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1598484772; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=tu/RU/IL+TVs+Jt0lHEeGfyjtfJOrMWYmVkMGIyPahw=; b=g4vx+AZrVbE5mmK1YSZ2vGNPQ7qh+MIiD/PShkgMwHivG2HGYaXyYF9ErgsKtlNxTX AKJOTMCoSMks/RC2OfxlUlVtzH6xpRi+5B9KynAY8tIvkgp1Bs54foj2eimyiQHM1JSu 7+jVO5R+laqT43rXWKTH2V492SRR/ZUL1fd4wbusBupr3KbK6XLVvJ3SIPS+2q67i/S1 kGX0M1uzPNqlehhNWZYsMZbVM3UpduMExm6y6rRc0IBA/bQDKY7VPAbtA5xD/rvtXNAi njA47b6xbLdIuEk38YMoKkTJESDBPeJ9WYxnYmLQv8MrzkopAPLjFvnfCyJ+dgpofOkg 83qg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOHqfyyPs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.10.7 DYNA|AUTH) with ESMTPSA id z05f0fw7QNWoX9B (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 27 Aug 2020 01:32:50 +0200 (CEST) From: Bruno Haible To: Paul Eggert Subject: Re: configure messages: check for features, not for bugs Date: Thu, 27 Aug 2020 01:32:50 +0200 Message-ID: <1713069.aSLdWSBKO5@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-186-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <3b36de33-d55e-fb1e-571d-fe62b6e3659c@cs.ucla.edu> References: <3182581.7oEx4UWm9q@omega> <3b36de33-d55e-fb1e-571d-fe62b6e3659c@cs.ucla.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2152122.udYZP7iYJq" Content-Transfer-Encoding: 7Bit Received-SPF: none client-ip=81.169.146.220; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/26 19:32:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.239, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" This is a multi-part message in MIME format. --nextPart2152122.udYZP7iYJq Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On 2020-07-26 we discussed: > > Does anyone see a problem with this? Here is a proposed set of patches. > > I like this change, and don't see a problem with it. Thanks for doing that. After a bit of testing of these changes, I pushed them. 2020-08-26 Bruno Haible stdint, wchar, wctype-h: Change configure message. * m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large enough..." instead of "checking whether wint_t is too small...". 2020-08-26 Bruno Haible time_rz: Change configure message. * m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even near extrema..." instead of "checking whether localtime loops forever near extrema...". 2020-08-26 Bruno Haible stdint: Change configure message. * m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works without ISO C predefines..." instead of "checking whether stdint.h predates C++11...". 2020-08-26 Bruno Haible socketlib: Change configure message. * m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..." instead of "checking if we need to call WSAStartup in winsock2.h and -lws2_32...". 2020-08-26 Bruno Haible include_next: Change configure message. * m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source code line length is unlimited..." instead of "checking whether system header files limit the line length...". 2020-08-26 Bruno Haible getcwd: Change configure message. * m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking whether getcwd succeeds when 4k < cwd_length < 16k..." instead of "checking whether getcwd aborts when 4k < cwd_length < 16k...". 2020-08-26 Bruno Haible chdir-long: Change configure message. * m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this system supports file names of any length..." instead of "checking whether this system has an arbitrary file name length limit...". Set gl_cv_have_unlimited_file_name_length instead of gl_cv_have_arbitrary_file_name_length_limit. * modules/chdir-long (Depends-on, configure.ac): Update accordingly. 2020-08-26 Bruno Haible ceill: Change configure message. * m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..." instead of "checking whether ceill() breaks with small values...". 2020-08-26 Bruno Haible iconv: Change configure message. * m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible with its POSIX signature..." instead of "checking for iconv declaration...". Remove K&R C support. --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0001-iconv-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-iconv-Change-configure-message.patch" >From 9b2c74424c6dc4d1f61e74c668afcbadb717f176 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 00:42:22 +0200 Subject: [PATCH 1/9] iconv: Change configure message. * m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible with its POSIX signature..." instead of "checking for iconv declaration...". Remove K&R C support. --- ChangeLog | 7 +++++++ m4/iconv.m4 | 44 +++++++++++++++++++++++--------------------- 2 files changed, 30 insertions(+), 21 deletions(-) diff --git a/ChangeLog b/ChangeLog index ada6bdf..73b7b60 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2020-08-26 Bruno Haible + + iconv: Change configure message. + * m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible + with its POSIX signature..." instead of "checking for iconv + declaration...". Remove K&R C support. + 2020-08-26 Paul Eggert getcwd: help the merge back into glibc diff --git a/m4/iconv.m4 b/m4/iconv.m4 index 67dbfed..f8a536b 100644 --- a/m4/iconv.m4 +++ b/m4/iconv.m4 @@ -1,4 +1,4 @@ -# iconv.m4 serial 22 +# iconv.m4 serial 23 dnl Copyright (C) 2000-2002, 2007-2014, 2016-2020 Free Software Foundation, dnl Inc. dnl This file is free software; the Free Software Foundation @@ -9,6 +9,10 @@ dnl From Bruno Haible. AC_PREREQ([2.64]) +dnl Note: AM_ICONV is documented in the GNU gettext manual +dnl . +dnl Don't make changes that are incompatible with that documentation! + AC_DEFUN([AM_ICONV_LINKFLAGS_BODY], [ dnl Prerequisites of AC_LIB_LINKFLAGS_BODY. @@ -239,41 +243,39 @@ AC_DEFUN_ONCE([AM_ICONV], [ AM_ICONV_LINK if test "$am_cv_func_iconv" = yes; then - AC_MSG_CHECKING([for iconv declaration]) - AC_CACHE_VAL([am_cv_proto_iconv], [ - AC_COMPILE_IFELSE( - [AC_LANG_PROGRAM( - [[ + AC_CACHE_CHECK([whether iconv is compatible with its POSIX signature], + [gl_cv_iconv_nonconst], + [AC_COMPILE_IFELSE( + [AC_LANG_PROGRAM( + [[ #include #include extern #ifdef __cplusplus "C" #endif -#if defined(__STDC__) || defined(_MSC_VER) || defined(__cplusplus) size_t iconv (iconv_t cd, char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft); -#else -size_t iconv(); -#endif - ]], - [[]])], - [am_cv_proto_iconv_arg1=""], - [am_cv_proto_iconv_arg1="const"]) - am_cv_proto_iconv="extern size_t iconv (iconv_t cd, $am_cv_proto_iconv_arg1 char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);"]) - am_cv_proto_iconv=`echo "[$]am_cv_proto_iconv" | tr -s ' ' | sed -e 's/( /(/'` - AC_MSG_RESULT([ - $am_cv_proto_iconv]) + ]], + [[]])], + [gl_cv_iconv_nonconst=yes], + [gl_cv_iconv_nonconst=no]) + ]) else dnl When compiling GNU libiconv on a system that does not have iconv yet, dnl pick the POSIX compliant declaration without 'const'. - am_cv_proto_iconv_arg1="" + gl_cv_iconv_nonconst=yes + fi + if test $gl_cv_iconv_nonconst = yes; then + iconv_arg1="" + else + iconv_arg1="const" fi - AC_DEFINE_UNQUOTED([ICONV_CONST], [$am_cv_proto_iconv_arg1], + AC_DEFINE_UNQUOTED([ICONV_CONST], [$iconv_arg1], [Define as const if the declaration of iconv() needs const.]) dnl Also substitute ICONV_CONST in the gnulib generated . m4_ifdef([gl_ICONV_H_DEFAULTS], [AC_REQUIRE([gl_ICONV_H_DEFAULTS]) - if test -n "$am_cv_proto_iconv_arg1"; then + if test $gl_cv_iconv_nonconst != yes; then ICONV_CONST="const" fi ]) -- 2.7.4 --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0002-ceill-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0002-ceill-Change-configure-message.patch" >From eb699621456971095297e26164a61ad2f4e7c672 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 00:47:22 +0200 Subject: [PATCH 2/9] ceill: Change configure message. * m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..." instead of "checking whether ceill() breaks with small values...". --- ChangeLog | 6 ++++++ m4/ceill.m4 | 48 ++++++++++++++++++++++++------------------------ 2 files changed, 30 insertions(+), 24 deletions(-) diff --git a/ChangeLog b/ChangeLog index 73b7b60..5d6b852 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2020-08-26 Bruno Haible + ceill: Change configure message. + * m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..." + instead of "checking whether ceill() breaks with small values...". + +2020-08-26 Bruno Haible + iconv: Change configure message. * m4/iconv.m4 (AM_ICONV): Say "checking whether iconv is compatible with its POSIX signature..." instead of "checking for iconv diff --git a/m4/ceill.m4 b/m4/ceill.m4 index 806c4e6..3428530 100644 --- a/m4/ceill.m4 +++ b/m4/ceill.m4 @@ -1,4 +1,4 @@ -# ceill.m4 serial 21 +# ceill.m4 serial 22 dnl Copyright (C) 2007, 2009-2020 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -74,31 +74,31 @@ int main (int argc, char *argv[]) HAVE_DECL_CEILL=0 fi dnl On OpenBSD 5.6 the system's native ceill() is buggy: - dnl it returns '0' for small values. Test for this anomaly. + dnl it returns '0' for small values. Test against this anomaly. if test $REPLACE_CEILL = 0 ; then - AC_CACHE_CHECK([whether ceill() breaks with small values], - [gl_cv_func_ceill_buggy], - [ - save_LIBS="$LIBS" - LIBS="$CEILL_LIBM" - AC_RUN_IFELSE( - [AC_LANG_PROGRAM( - [[#include + AC_CACHE_CHECK([whether ceill() works], + [gl_cv_func_ceill_works], + [save_LIBS="$LIBS" + LIBS="$CEILL_LIBM" + AC_RUN_IFELSE( + [AC_LANG_PROGRAM( + [[#include long double d = 0.3L;]], - [[return (!(ceill (d) == 1)); ]])], - [gl_cv_func_ceill_buggy=no], [gl_cv_func_ceill_buggy=yes], - [case "$host_os" in - openbsd*) gl_cv_func_ceill_buggy="guessing yes" ;; - # Guess no on native Windows. - mingw*) gl_cv_func_ceill_buggy="guessing no" ;; - *) gl_cv_func_ceill_buggy="guessing no" ;; - esac - ]) - LIBS="$save_LIBS" - ]) - case "$gl_cv_func_ceill_buggy" in - *yes) - REPLACE_CEILL=1 ;; + [[return (!(ceill (d) == 1)); ]])], + [gl_cv_func_ceill_works=yes], + [gl_cv_func_ceill_works=no], + [case "$host_os" in + openbsd*) gl_cv_func_ceill_works="guessing no" ;; + # Guess yes on native Windows. + mingw*) gl_cv_func_ceill_works="guessing yes" ;; + *) gl_cv_func_ceill_works="guessing yes" ;; + esac + ]) + LIBS="$save_LIBS" + ]) + case "$gl_cv_func_ceill_works" in + *yes) ;; + *) REPLACE_CEILL=1 ;; esac fi if test $HAVE_DECL_CEILL = 0 || test $REPLACE_CEILL = 1; then -- 2.7.4 --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0003-chdir-long-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0003-chdir-long-Change-configure-message.patch" >From a84b18e48e2384ceeb8e4e2cd3784e18efb1537b Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 00:49:28 +0200 Subject: [PATCH 3/9] chdir-long: Change configure message. * m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this system supports file names of any length..." instead of "checking whether this system has an arbitrary file name length limit...". Set gl_cv_have_unlimited_file_name_length instead of gl_cv_have_arbitrary_file_name_length_limit. * modules/chdir-long (Depends-on, configure.ac): Update accordingly. --- ChangeLog | 10 ++++++++++ m4/chdir-long.m4 | 10 +++++----- modules/chdir-long | 22 +++++++++++----------- 3 files changed, 26 insertions(+), 16 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5d6b852..7ac92db 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,15 @@ 2020-08-26 Bruno Haible + chdir-long: Change configure message. + * m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this + system supports file names of any length..." instead of "checking + whether this system has an arbitrary file name length limit...". + Set gl_cv_have_unlimited_file_name_length instead of + gl_cv_have_arbitrary_file_name_length_limit. + * modules/chdir-long (Depends-on, configure.ac): Update accordingly. + +2020-08-26 Bruno Haible + ceill: Change configure message. * m4/ceill.m4 (gl_FUNC_CEILL): Say "checking whether ceill() works..." instead of "checking whether ceill() breaks with small values...". diff --git a/m4/chdir-long.m4 b/m4/chdir-long.m4 index a528a5d..a6e67b5 100644 --- a/m4/chdir-long.m4 +++ b/m4/chdir-long.m4 @@ -1,4 +1,4 @@ -#serial 16 +#serial 17 # Use Gnulib's robust chdir function. # It can handle arbitrarily long directory names, which means @@ -16,15 +16,15 @@ dnl with or without modifications, as long as this notice is preserved. AC_DEFUN([gl_FUNC_CHDIR_LONG], [ AC_REQUIRE([gl_PATHMAX_SNIPPET_PREREQ]) - AC_CACHE_CHECK([whether this system has an arbitrary file name length limit], - [gl_cv_have_arbitrary_file_name_length_limit], + AC_CACHE_CHECK([whether this system supports file names of any length], + [gl_cv_have_unlimited_file_name_length], [AC_EGREP_CPP([have_arbitrary_file_name_length_limit], gl_PATHMAX_SNIPPET[ #ifdef PATH_MAX have_arbitrary_file_name_length_limit #endif], - [gl_cv_have_arbitrary_file_name_length_limit=yes], - [gl_cv_have_arbitrary_file_name_length_limit=no])]) + [gl_cv_have_unlimited_file_name_length=no], + [gl_cv_have_unlimited_file_name_length=yes])]) ]) AC_DEFUN([gl_PREREQ_CHDIR_LONG], [:]) diff --git a/modules/chdir-long b/modules/chdir-long index 82d4e8b..3cab294 100644 --- a/modules/chdir-long +++ b/modules/chdir-long @@ -11,20 +11,20 @@ Depends-on: unistd pathmax chdir -assure [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -atexit [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -fchdir [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -fcntl-h [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -openat [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -memchr [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -mempcpy [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -memrchr [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -stdbool [test $gl_cv_have_arbitrary_file_name_length_limit = yes] -stdlib [test $gl_cv_have_arbitrary_file_name_length_limit = yes] +assure [test $gl_cv_have_unlimited_file_name_length = no] +atexit [test $gl_cv_have_unlimited_file_name_length = no] +fchdir [test $gl_cv_have_unlimited_file_name_length = no] +fcntl-h [test $gl_cv_have_unlimited_file_name_length = no] +openat [test $gl_cv_have_unlimited_file_name_length = no] +memchr [test $gl_cv_have_unlimited_file_name_length = no] +mempcpy [test $gl_cv_have_unlimited_file_name_length = no] +memrchr [test $gl_cv_have_unlimited_file_name_length = no] +stdbool [test $gl_cv_have_unlimited_file_name_length = no] +stdlib [test $gl_cv_have_unlimited_file_name_length = no] configure.ac: gl_FUNC_CHDIR_LONG -if test $gl_cv_have_arbitrary_file_name_length_limit = yes; then +if test $gl_cv_have_unlimited_file_name_length = no; then AC_LIBOBJ([chdir-long]) gl_PREREQ_CHDIR_LONG fi -- 2.7.4 --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0004-getcwd-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0004-getcwd-Change-configure-message.patch" >From fadf8937474ce0faa0cd2e446ce6b3677ff900e2 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 00:56:09 +0200 Subject: [PATCH 4/9] getcwd: Change configure message. * m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking whether getcwd succeeds when 4k < cwd_length < 16k..." instead of "checking whether getcwd aborts when 4k < cwd_length < 16k...". --- ChangeLog | 7 +++++++ m4/getcwd-abort-bug.m4 | 26 +++++++++++++------------- 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7ac92db..eb7ef9b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2020-08-26 Bruno Haible + getcwd: Change configure message. + * m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking + whether getcwd succeeds when 4k < cwd_length < 16k..." instead of + "checking whether getcwd aborts when 4k < cwd_length < 16k...". + +2020-08-26 Bruno Haible + chdir-long: Change configure message. * m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Say "checking whether this system supports file names of any length..." instead of "checking diff --git a/m4/getcwd-abort-bug.m4 b/m4/getcwd-abort-bug.m4 index 9817912..b5cf86e 100644 --- a/m4/getcwd-abort-bug.m4 +++ b/m4/getcwd-abort-bug.m4 @@ -1,4 +1,4 @@ -# serial 14 +# serial 15 # Determine whether getcwd aborts when the length of the working directory # name is unusually large. Any length between 4k and 16k trigger the bug # when using glibc-2.4.90-9 or older. @@ -10,7 +10,7 @@ # From Jim Meyering -# gl_FUNC_GETCWD_ABORT_BUG([ACTION-IF-FOUND[, ACTION-IF-NOT-FOUND]]) +# gl_FUNC_GETCWD_ABORT_BUG([ACTION-IF-BUGGY[, ACTION-IF-WORKS]]) AC_DEFUN([gl_FUNC_GETCWD_ABORT_BUG], [ AC_REQUIRE([AC_CANONICAL_HOST]) dnl for cross-compiles @@ -24,8 +24,8 @@ AC_DEFUN([gl_FUNC_GETCWD_ABORT_BUG], [Define to 1 if the system has the 'getpagesize' function.]) fi - AC_CACHE_CHECK([whether getcwd aborts when 4k < cwd_length < 16k], - [gl_cv_func_getcwd_abort_bug], + AC_CACHE_CHECK([whether getcwd succeeds when 4k < cwd_length < 16k], + [gl_cv_func_getcwd_succeeds_beyond_4k], [# Remove any remnants of a previous test. rm -rf confdir-14B--- # Arrange for deletion of the temporary directory this test creates. @@ -126,7 +126,7 @@ main () return fail; } ]])], - [gl_cv_func_getcwd_abort_bug=no], + [gl_cv_func_getcwd_succeeds_beyond_4k=yes], [dnl An abort will provoke an exit code of something like 134 (128 + 6). dnl An exit code of 4 can also occur (in OpenBSD 6.7, NetBSD 5.1 for dnl example): getcwd (NULL, 0) fails rather than returning a string @@ -135,21 +135,21 @@ main () dnl provide a non-NULL value in this case. ret=$? if test $ret -ge 128 || test $ret = 4; then - gl_cv_func_getcwd_abort_bug=yes + gl_cv_func_getcwd_succeeds_beyond_4k=no else - gl_cv_func_getcwd_abort_bug=no + gl_cv_func_getcwd_succeeds_beyond_4k=yes fi ], [case "$host_os" in - # Guess no on musl systems. - *-musl*) gl_cv_func_getcwd_abort_bug="guessing no" ;; - # Guess yes otherwise, even on glibc systems. - *) gl_cv_func_getcwd_abort_bug="guessing yes" + # Guess yes on musl systems. + *-musl*) gl_cv_func_getcwd_succeeds_beyond_4k="guessing yes" ;; + # Guess no otherwise, even on glibc systems. + *) gl_cv_func_getcwd_succeeds_beyond_4k="guessing no" esac ]) ]) - case "$gl_cv_func_getcwd_abort_bug" in - *yes) + case "$gl_cv_func_getcwd_succeeds_beyond_4k" in + *no) $1 ;; *) -- 2.7.4 --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0005-include_next-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0005-include_next-Change-configure-message.patch" >From a7bdbd1d4cdca3c7f3b951f0ce551040a90cf5cd Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 01:04:36 +0200 Subject: [PATCH 5/9] include_next: Change configure message. * m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source code line length is unlimited..." instead of "checking whether system header files limit the line length...". --- ChangeLog | 7 +++++++ m4/include_next.m4 | 18 ++++++++++-------- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index eb7ef9b..6f32743 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2020-08-26 Bruno Haible + include_next: Change configure message. + * m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source + code line length is unlimited..." instead of "checking whether system + header files limit the line length...". + +2020-08-26 Bruno Haible + getcwd: Change configure message. * m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Say "checking whether getcwd succeeds when 4k < cwd_length < 16k..." instead of diff --git a/m4/include_next.m4 b/m4/include_next.m4 index 33601aa..9221d9f 100644 --- a/m4/include_next.m4 +++ b/m4/include_next.m4 @@ -1,4 +1,4 @@ -# include_next.m4 serial 25 +# include_next.m4 serial 26 dnl Copyright (C) 2006-2020 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -106,19 +106,21 @@ dnl We intentionally avoid using AC_LANG_SOURCE here. AC_SUBST([INCLUDE_NEXT]) AC_SUBST([INCLUDE_NEXT_AS_FIRST_DIRECTIVE]) AC_SUBST([PRAGMA_SYSTEM_HEADER]) - AC_CACHE_CHECK([whether system header files limit the line length], - [gl_cv_pragma_columns], - [dnl HP NonStop systems, which define __TANDEM, have this misfeature. - AC_EGREP_CPP([choke me], + + dnl HP NonStop systems, which define __TANDEM, limit the line length + dnl after including some system header files. + AC_CACHE_CHECK([whether source code line length is unlimited], + [gl_cv_source_line_length_unlimited], + [AC_EGREP_CPP([choke me], [ #ifdef __TANDEM choke me #endif ], - [gl_cv_pragma_columns=yes], - [gl_cv_pragma_columns=no]) + [gl_cv_source_line_length_unlimited=no], + [gl_cv_source_line_length_unlimited=yes]) ]) - if test $gl_cv_pragma_columns = yes; then + if test $gl_cv_source_line_length_unlimited = no; then PRAGMA_COLUMNS="#pragma COLUMNS 10000" else PRAGMA_COLUMNS= -- 2.7.4 --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0006-socketlib-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0006-socketlib-Change-configure-message.patch" >From f7a517ac04e5186da5d0b3c0727a0cb8dc5cb214 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 01:09:20 +0200 Subject: [PATCH 6/9] socketlib: Change configure message. * m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..." instead of "checking if we need to call WSAStartup in winsock2.h and -lws2_32...". --- ChangeLog | 7 +++++++ m4/socketlib.m4 | 32 +++++++++++++++++++------------- 2 files changed, 26 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6f32743..47846b6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2020-08-26 Bruno Haible + socketlib: Change configure message. + * m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..." + instead of "checking if we need to call WSAStartup in winsock2.h and + -lws2_32...". + +2020-08-26 Bruno Haible + include_next: Change configure message. * m4/include_next.m4 (gl_INCLUDE_NEXT): Say "checking whether source code line length is unlimited..." instead of "checking whether system diff --git a/m4/socketlib.m4 b/m4/socketlib.m4 index 2372a27..48dd7d6 100644 --- a/m4/socketlib.m4 +++ b/m4/socketlib.m4 @@ -1,4 +1,4 @@ -# socketlib.m4 serial 2 +# socketlib.m4 serial 3 dnl Copyright (C) 2008-2020 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -14,21 +14,27 @@ AC_DEFUN([gl_SOCKETLIB], LIBSOCKET= if test $HAVE_WINSOCK2_H = 1; then dnl Native Windows API (not Cygwin). - AC_CACHE_CHECK([if we need to call WSAStartup in winsock2.h and -lws2_32], - [gl_cv_func_wsastartup], [ - gl_save_LIBS="$LIBS" - LIBS="$LIBS -lws2_32" - AC_LINK_IFELSE([AC_LANG_PROGRAM([[ + dnl If the function WSAStartup exists (declared in and + dnl defined through -lws2_32), we need to call it. + AC_CACHE_CHECK([for WSAStartup], + [gl_cv_func_wsastartup], [ + gl_save_LIBS="$LIBS" + LIBS="$LIBS -lws2_32" + AC_LINK_IFELSE( + [AC_LANG_PROGRAM([[ #ifdef HAVE_WINSOCK2_H # include #endif]], [[ - WORD wVersionRequested = MAKEWORD(1, 1); - WSADATA wsaData; - int err = WSAStartup(wVersionRequested, &wsaData); - WSACleanup ();]])], - gl_cv_func_wsastartup=yes, gl_cv_func_wsastartup=no) - LIBS="$gl_save_LIBS" - ]) + WORD wVersionRequested = MAKEWORD(1, 1); + WSADATA wsaData; + int err = WSAStartup(wVersionRequested, &wsaData); + WSACleanup (); + ]]) + ], + [gl_cv_func_wsastartup=yes], + [gl_cv_func_wsastartup=no]) + LIBS="$gl_save_LIBS" + ]) if test "$gl_cv_func_wsastartup" = "yes"; then AC_DEFINE([WINDOWS_SOCKETS], [1], [Define if WSAStartup is needed.]) LIBSOCKET='-lws2_32' -- 2.7.4 --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0007-stdint-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0007-stdint-Change-configure-message.patch" >From 5ed052320923259225ba80b41f1840b46b713501 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 01:21:27 +0200 Subject: [PATCH 7/9] stdint: Change configure message. * m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works without ISO C predefines..." instead of "checking whether stdint.h predates C++11...". --- ChangeLog | 7 +++++++ m4/stdint.m4 | 18 ++++++++++-------- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 47846b6..06a9514 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2020-08-26 Bruno Haible + stdint: Change configure message. + * m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works + without ISO C predefines..." instead of "checking whether stdint.h + predates C++11...". + +2020-08-26 Bruno Haible + socketlib: Change configure message. * m4/socketlib.m4 (gl_SOCKETLIB): Say "checking for WSAStartup..." instead of "checking if we need to call WSAStartup in winsock2.h and diff --git a/m4/stdint.m4 b/m4/stdint.m4 index e0fa8a5..d5f5d61 100644 --- a/m4/stdint.m4 +++ b/m4/stdint.m4 @@ -1,4 +1,4 @@ -# stdint.m4 serial 55 +# stdint.m4 serial 56 dnl Copyright (C) 2001-2020 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -302,9 +302,10 @@ static const char *macro_values[] = HAVE_C99_STDINT_H=1 dnl Now see whether the system works without dnl __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS defined. - AC_CACHE_CHECK([whether stdint.h predates C++11], - [gl_cv_header_stdint_predates_cxx11_h], - [gl_cv_header_stdint_predates_cxx11_h=yes + dnl If not, there would be problems when stdint.h is included from C++. + AC_CACHE_CHECK([whether stdint.h works without ISO C predefines], + [gl_cv_header_stdint_without_STDC_macros], + [gl_cv_header_stdint_without_STDC_macros=no AC_COMPILE_IFELSE([ AC_LANG_PROGRAM([[ #define _GL_JUST_INCLUDE_SYSTEM_STDINT_H 1 /* work if build isn't clean */ @@ -315,13 +316,14 @@ gl_STDINT_INCLUDES intmax_t im = INTMAX_MAX; int32_t i32 = INT32_C (0x7fffffff); ]])], - [gl_cv_header_stdint_predates_cxx11_h=no])]) + [gl_cv_header_stdint_without_STDC_macros=yes]) + ]) - if test "$gl_cv_header_stdint_predates_cxx11_h" = yes; then + if test $gl_cv_header_stdint_without_STDC_macros = no; then AC_DEFINE([__STDC_CONSTANT_MACROS], [1], - [Define to 1 if the system predates C++11.]) + [Define to 1 if the system predates C++11.]) AC_DEFINE([__STDC_LIMIT_MACROS], [1], - [Define to 1 if the system predates C++11.]) + [Define to 1 if the system predates C++11.]) fi AC_CACHE_CHECK([whether stdint.h has UINTMAX_WIDTH etc.], [gl_cv_header_stdint_width], -- 2.7.4 --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0008-time_rz-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0008-time_rz-Change-configure-message.patch" >From a1e10e28d2fcc16f8fdcefd26ad2b325f90aff93 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 01:23:55 +0200 Subject: [PATCH 8/9] time_rz: Change configure message. * m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even near extrema..." instead of "checking whether localtime loops forever near extrema...". --- ChangeLog | 7 +++++++ m4/time_rz.m4 | 14 +++++++------- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 06a9514..b832520 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2020-08-26 Bruno Haible + time_rz: Change configure message. + * m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even + near extrema..." instead of "checking whether localtime loops forever + near extrema...". + +2020-08-26 Bruno Haible + stdint: Change configure message. * m4/stdint.m4 (gl_STDINT_H): Say "checking whether stdint.h works without ISO C predefines..." instead of "checking whether stdint.h diff --git a/m4/time_rz.m4 b/m4/time_rz.m4 index 2dd64b2..30161c0 100644 --- a/m4/time_rz.m4 +++ b/m4/time_rz.m4 @@ -13,12 +13,12 @@ AC_DEFUN([gl_TIME_RZ], AC_REQUIRE([gl_HEADER_TIME_H_DEFAULTS]) AC_REQUIRE([AC_STRUCT_TIMEZONE]) - # Mac OS X 10.6 loops forever with some time_t values. + # On Mac OS X 10.6, localtime loops forever with some time_t values. # See Bug#27706, Bug#27736, and # https://lists.gnu.org/r/bug-gnulib/2017-07/msg00142.html - AC_CACHE_CHECK([whether localtime loops forever near extrema], - [gl_cv_func_localtime_infloop_bug], - [gl_cv_func_localtime_infloop_bug=no + AC_CACHE_CHECK([whether localtime works even near extrema], + [gl_cv_func_localtime_works], + [gl_cv_func_localtime_works=yes AC_RUN_IFELSE( [AC_LANG_PROGRAM( [[#include @@ -37,10 +37,10 @@ AC_DEFUN([gl_TIME_RZ], return tm && tm->tm_isdst; ]])], [(TZ=QQQ0 ./conftest$EXEEXT) >/dev/null 2>&1 || - gl_cv_func_localtime_infloop_bug=yes], + gl_cv_func_localtime_works=no], [], - [gl_cv_func_localtime_infloop_bug="guessing no"])]) - if test "$gl_cv_func_localtime_infloop_bug" = yes; then + [gl_cv_func_localtime_works="guessing yes"])]) + if test "$gl_cv_func_localtime_works" = no; then AC_DEFINE([HAVE_LOCALTIME_INFLOOP_BUG], 1, [Define if localtime-like functions can loop forever on extreme arguments.]) -- 2.7.4 --nextPart2152122.udYZP7iYJq Content-Disposition: attachment; filename="0009-stdint-wchar-wctype-h-Change-configure-message.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0009-stdint-wchar-wctype-h-Change-configure-message.patch" >From 37ccbbb9018e2c366ed0b01fba805915a64cc8d9 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 27 Aug 2020 01:27:21 +0200 Subject: [PATCH 9/9] stdint, wchar, wctype-h: Change configure message. * m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large enough..." instead of "checking whether wint_t is too small...". --- ChangeLog | 6 ++++++ m4/wint_t.m4 | 12 ++++++------ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index b832520..309f0cf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2020-08-26 Bruno Haible + stdint, wchar, wctype-h: Change configure message. + * m4/wint_t.m4 (gt_TYPE_WINT_T): Say "checking whether wint_t is large + enough..." instead of "checking whether wint_t is too small...". + +2020-08-26 Bruno Haible + time_rz: Change configure message. * m4/time_rz.m4 (gl_TIME_RZ): Say "checking whether localtime works even near extrema..." instead of "checking whether localtime loops forever diff --git a/m4/wint_t.m4 b/m4/wint_t.m4 index 5e6c178..cf9764d 100644 --- a/m4/wint_t.m4 +++ b/m4/wint_t.m4 @@ -1,4 +1,4 @@ -# wint_t.m4 serial 8 +# wint_t.m4 serial 9 dnl Copyright (C) 2003, 2007-2020 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -32,8 +32,8 @@ AC_DEFUN([gt_TYPE_WINT_T], dnl Determine whether gnulib's or would, if present, dnl override 'wint_t'. - AC_CACHE_CHECK([whether wint_t is too small], - [gl_cv_type_wint_t_too_small], + AC_CACHE_CHECK([whether wint_t is large enough], + [gl_cv_type_wint_t_large_enough], [AC_COMPILE_IFELSE( [AC_LANG_PROGRAM([[ /* Tru64 with Desktop Toolkit C has a bug: must be included before @@ -48,9 +48,9 @@ AC_DEFUN([gt_TYPE_WINT_T], #include int verify[sizeof (wint_t) < sizeof (int) ? -1 : 1]; ]])], - [gl_cv_type_wint_t_too_small=no], - [gl_cv_type_wint_t_too_small=yes])]) - if test $gl_cv_type_wint_t_too_small = yes; then + [gl_cv_type_wint_t_large_enough=yes], + [gl_cv_type_wint_t_large_enough=no])]) + if test $gl_cv_type_wint_t_large_enough = no; then GNULIB_OVERRIDES_WINT_T=1 else GNULIB_OVERRIDES_WINT_T=0 -- 2.7.4 --nextPart2152122.udYZP7iYJq--