www_coderepo: fix read buffering

Our read buffering only worked well with the stdout buffering on
glibc and *BSD libc, but not musl.  When reading the stdout of
git(1), we are likely to get smaller buffers and require more
reads on musl-based systems (tested Alpine Linux 3.19.0).

Thus we must prevent ->translate from being called with an empty
argument list (denoting EOF).  We'll also avoid some local
variable assignments while at it and favor the non-OO ->zflush
dispatch inside RepoAtom and WwwCoderepo subclasses.

1 files changed, 5 insertions, 3 deletions

diff --git a/t/solver_git.t b/t/solver_git.t
index ab8aba15..db672904 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -405,14 +405,16 @@ EOF
                 is($res->code, 200, 'Atom feed');
                 SKIP: {
                         require_mods('XML::TreePP', 1);
-                        my $t = XML::TreePP->new->parse($res->content);
+                        my $t = eval { XML::TreePP->new->parse($res->content) }
+                                or diag explain($res);
                         is(scalar @{$t->{feed}->{entry}}, 50,
-                                'got 50 entries');
+                                'got 50 entries') or diag explain([$t, $res]);
 
                         $res = $cb->(GET('/public-inbox/atom/COPYING'));
                         is($res->code, 200, 'file Atom feed');
                         $t = XML::TreePP->new->parse($res->content);
-                        ok($t->{feed}->{entry}, 'got entry');
+                        ok($t->{feed}->{entry}, 'got entry') or
+                                diag explain([ $t, $res ]);
 
                         $res = $cb->(GET('/public-inbox/atom/README.md'));
                         is($res->code, 404, '404 on missing file Atom feed');