diff options
author | Eric Wong <e@80x24.org> | 2020-09-11 07:32:31 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2020-09-12 20:29:11 +0000 |
commit | d11feea98718f2abb109af4216a36bdbd21b7191 (patch) | |
tree | 1f6f83caf21d52f61524e935fa53dcbb6f789877 /lib/PublicInbox/View.pm | |
parent | 0a1e15ad863782650a36025b9d52a6e9de5eadf3 (diff) | |
download | public-inbox-d11feea98718f2abb109af4216a36bdbd21b7191.tar.gz |
treewide: avoid `goto &NAME' for tail recursion
While Perl implements tail recursion via `goto' which allows avoiding warnings on deep recursion. It doesn't (as of 5.28) optimize the speed of such dispatches, though it may reduce ephemeral memory usage. Make the code less alien to hackers coming from other languages by using normal subroutine dispatch. It's actually slightly faster in micro benchmarks due to the complexity of `goto &NAME'.
Diffstat (limited to 'lib/PublicInbox/View.pm')
-rw-r--r-- | lib/PublicInbox/View.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 3055da20..1d5119cd 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -386,7 +386,7 @@ sub next_in_queue ($$) { sub stream_thread_i { # PublicInbox::WwwStream::getline callback my ($ctx, $eml) = @_; - goto &thread_eml_entry if $eml; # tail recursion + return thread_eml_entry($ctx, $eml) if $eml; return unless exists($ctx->{skel}); my $ghost_ok = $ctx->{nr}++; while (1) { |