about summary refs log tree commit homepage
path: root/lib/PublicInbox/TestCommon.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2023-09-14 20:52:05 +0000
committerEric Wong <e@80x24.org>2023-09-14 21:34:04 +0000
commit83cf082e4f5162c92ae6b4b87e79a6115a9fde6b (patch)
tree53706bd131491c0e60a8c040c8d78814a6c54069 /lib/PublicInbox/TestCommon.pm
parentc35b597daf2de0fe4bb7f752128dc9ded041ff8b (diff)
downloadpublic-inbox-83cf082e4f5162c92ae6b4b87e79a6115a9fde6b.tar.gz
cleanup_task is long gone since all that cleanup work got moved
into DS itself.  Adding a DS->Reset here breaks t/imapd.t (and
possibly other tests), and is actually unlikely to avoid any
cleanup segfaults on OpenBSD since those are only happening
after `END {}' blocks are called.
Diffstat (limited to 'lib/PublicInbox/TestCommon.pm')
-rw-r--r--lib/PublicInbox/TestCommon.pm3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index a8323e4d..4c819a4f 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -365,7 +365,8 @@ sub run_script ($;$$) {
                         chdir $d or die "chdir $d: $!";
                 }
                 _run_sub($sub, $key, \@argv);
-                eval { PublicInbox::Inbox::cleanup_task() };
+                # n.b. all our uses of PublicInbox::DS should be fine
+                # with this and we can't Reset here.
                 die "fchdir(restore): $!" if $cwdfh && !chdir($cwdfh);
                 _undo_redirects($orig_io);
                 select STDOUT;