diff options
author | Eric Wong <e@80x24.org> | 2023-09-11 09:41:27 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2023-09-11 18:51:14 +0000 |
commit | d98a23c63ae1da65b8521fdd6faa9e9fb5f898e9 (patch) | |
tree | c46505bddfb7990c50be65176dd280c814d5bcc1 /lib/PublicInbox/Sigfd.pm | |
parent | 9231d2e7b93f2739c215c51164569347c90c646a (diff) | |
download | public-inbox-d98a23c63ae1da65b8521fdd6faa9e9fb5f898e9.tar.gz |
The awaitpid API turns out to be quite handy for managing long-lived worker processes. This allows us to ensure all our uses of signalfd (and kevent emulation) are non-blocking.
Diffstat (limited to 'lib/PublicInbox/Sigfd.pm')
-rw-r--r-- | lib/PublicInbox/Sigfd.pm | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/lib/PublicInbox/Sigfd.pm b/lib/PublicInbox/Sigfd.pm index 5656baeb..b8a1ddfb 100644 --- a/lib/PublicInbox/Sigfd.pm +++ b/lib/PublicInbox/Sigfd.pm @@ -12,26 +12,22 @@ use POSIX (); # returns a coderef to unblock signals if neither signalfd or kqueue # are available. sub new { - my ($class, $sig, $nonblock) = @_; + my ($class, $sig) = @_; my %signo = map {; # $num => [ $cb, $signame ]; ($SIGNUM{$_} // POSIX->can("SIG$_")->()) => [ $sig->{$_}, $_ ] } keys %$sig; my $self = bless { sig => \%signo }, $class; my $io; - my $fd = signalfd([keys %signo], $nonblock); + my $fd = signalfd([keys %signo]); if (defined $fd && $fd >= 0) { open($io, '+<&=', $fd) or die "open: $!"; } elsif (eval { require PublicInbox::DSKQXS }) { - $io = PublicInbox::DSKQXS->signalfd([keys %signo], $nonblock); + $io = PublicInbox::DSKQXS->signalfd([keys %signo]); } else { return; # wake up every second to check for signals } - if ($nonblock) { # it can go into the event loop - $self->SUPER::new($io, EPOLLIN | EPOLLET); - } else { # master main loop - $self->{sock} = $io; - } + $self->SUPER::new($io, EPOLLIN | EPOLLET); $self->{is_kq} = 1 if tied(*$io); $self; } |