about summary refs log tree commit homepage
path: root/lib/PublicInbox/LeiMailSync.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-08-31 11:21:17 +0000
committerEric Wong <e@80x24.org>2021-08-31 11:29:07 +0000
commita9d5304cfc5c35cd4520fc7f08a1b9d203e1f3eb (patch)
tree0c1464bdc3facd1a71bb179616418485fe95afe1 /lib/PublicInbox/LeiMailSync.pm
parentc5b5453595d291ef825bc3f0b7e043bc86fdd12d (diff)
downloadpublic-inbox-a9d5304cfc5c35cd4520fc7f08a1b9d203e1f3eb.tar.gz
No need to bump refcounts of {dbh} nor declare extra variables
for a rarely-called function.
Diffstat (limited to 'lib/PublicInbox/LeiMailSync.pm')
-rw-r--r--lib/PublicInbox/LeiMailSync.pm10
1 files changed, 4 insertions, 6 deletions
diff --git a/lib/PublicInbox/LeiMailSync.pm b/lib/PublicInbox/LeiMailSync.pm
index b63f8dea..57b56b3c 100644
--- a/lib/PublicInbox/LeiMailSync.pm
+++ b/lib/PublicInbox/LeiMailSync.pm
@@ -403,13 +403,11 @@ EOF
 
 sub forget_folder {
         my ($self, $folder) = @_;
-        my ($fid, $sth);
-        $fid = delete($self->{fmap}->{$folder}) //
+        my $fid = delete($self->{fmap}->{$folder}) //
                 fid_for($self, $folder) // return;
-        my $dbh = $self->{dbh};
-        $dbh->do('DELETE FROM blob2name WHERE fid = ?', undef, $fid);
-        $dbh->do('DELETE FROM blob2num WHERE fid = ?', undef, $fid);
-        $dbh->do('DELETE FROM folders WHERE fid = ?', undef, $fid);
+        for my $t (qw(blob2name blob2num folders)) {
+                $self->{dbh}->do("DELETE FROM $t WHERE fid = ?", undef, $fid);
+        }
 }
 
 # only used for changing canonicalization errors