diff options
| author | Eric Wong <e@80x24.org> | 2023-09-27 06:02:49 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2023-09-28 02:34:58 +0000 |
| commit | 5df0446abcca8ca3d65af14f05808c87d3de5b7f (patch) | |
| tree | ecbf7e991bbc515a2617e71f691be15d92862574 /lib/PublicInbox/LEI.pm | |
| parent | 10ca39f5bddcb414dac2a3fcee4cc53844c74fc1 (diff) | |
| download | public-inbox-5df0446abcca8ca3d65af14f05808c87d3de5b7f.tar.gz | |
Using and memoizing the usability of `--rsyncable' is unsafe since pigz (or GNU gzip) can be uninstalled and leave a user with a non-rsync-aware gzip implementation in the long-running daemon. So we stop passing --rsyncable by default to pigz/gzip and no longer attempt to check for it (since it was a TOCTTOU error, anyways). Specifying --rsyncable explicitly didn't work, either, and ended up passing `1' to the gzip/pigz argv :x Finally, we now test --rsyncable on the CLI by adding support for it in `lei convert' and testing it in t/lei-convert.t
Diffstat (limited to 'lib/PublicInbox/LEI.pm')
| -rw-r--r-- | lib/PublicInbox/LEI.pm | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 2f8d7a96..beb0f897 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -275,7 +275,8 @@ our %CMD = ( # sorted in order of importance/use: qw(all:s mode=s), @net_opt, @c_opt ], 'convert' => [ 'LOCATION...|--stdin', 'one-time conversion from URL or filesystem to another format', - qw(stdin| in-format|F=s out-format|f=s output|mfolder|o=s lock=s@ kw!), + qw(stdin| in-format|F=s out-format|f=s output|mfolder|o=s lock=s@ kw! + rsyncable), @net_opt, @c_opt ], 'p2q' => [ 'LOCATION_OR_COMMIT...|--stdin', "use a patch to generate a query for `lei q --stdin'", |