about summary refs log tree commit homepage
path: root/lib/PublicInbox/Inbox.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2022-08-29 09:26:38 +0000
committerEric Wong <e@80x24.org>2022-08-29 19:05:49 +0000
commitbe55542acc90572da54d828313c2416ae1c902b1 (patch)
tree001d9a6f38a16a023bd6f6b7a32a30403442a1ca /lib/PublicInbox/Inbox.pm
parenta66a2eddda8ffbb7679f4ef80dba7c7d377cda84 (diff)
downloadpublic-inbox-be55542acc90572da54d828313c2416ae1c902b1.tar.gz
treewide: ditch inbox->recent method
It's a needless wrapper, nowadays.  Originally, ->over was added
on experimental basis to optimize for /$INBOX/ where Xapian
->search is slower on gigantic (LKML-sized) inboxes.

Nowadays with extindex, ->over is here to stay given NNTP and
IMAP both benefit from it.  So reduce the interpreter stack
overhead and just access ->over directly.

lxs->recent was never used outside of tests, anyways.

And while we're in the area, avoid needlessly bumping the
refcount of $ctx->{ibx} in View::paginate_recent.
Diffstat (limited to 'lib/PublicInbox/Inbox.pm')
-rw-r--r--lib/PublicInbox/Inbox.pm5
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index acd7f338..8ac7eb30 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -351,11 +351,6 @@ sub msg_by_mid ($$) {
         $smsg ? msg_by_smsg($self, $smsg) : msg_by_path($self, mid2path($mid));
 }
 
-sub recent {
-        my ($self, $opts, $after, $before) = @_;
-        $self->over->recent($opts, $after, $before);
-}
-
 sub modified {
         my ($self) = @_;
         if (my $over = $self->over) {