about summary refs log tree commit homepage
path: root/lib/PublicInbox/HTTPD/Async.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2022-12-23 11:05:13 +0000
committerEric Wong <e@80x24.org>2022-12-23 12:44:23 +0000
commit32d4bd7489d5193f82dee52a6b08eda2c775caf5 (patch)
tree9e46831aef8d730c1f21e894c435cba493f15abe /lib/PublicInbox/HTTPD/Async.pm
parent9ea503ef65426070303fe1929f456b3591d74d93 (diff)
downloadpublic-inbox-32d4bd7489d5193f82dee52a6b08eda2c775caf5.tar.gz
Assigning `undef' to a scalar doesn't free it's memory,
we need to call `undef($var)' in the caller.  It's also
been pointless since we simplified ->async_pass in commit
b7fbffd1f8c12556 (httpd/async: get rid of ephemeral main_cb, 2019-12-25)
Diffstat (limited to 'lib/PublicInbox/HTTPD/Async.pm')
-rw-r--r--lib/PublicInbox/HTTPD/Async.pm4
1 files changed, 0 insertions, 4 deletions
diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm
index 9e592f47..75b3bd50 100644
--- a/lib/PublicInbox/HTTPD/Async.pm
+++ b/lib/PublicInbox/HTTPD/Async.pm
@@ -84,10 +84,6 @@ sub async_pass {
         # *_wcb methods respond to ->write (and ->close), not ->print
         $fh->write($$bref);
 
-        # we're done with this, free this memory up ASAP since the
-        # calls after this may use much memory:
-        $$bref = undef;
-
         $self->{http} = $http;
         $self->{fh} = $fh;
 }