about summary refs log tree commit homepage
path: root/lib/PublicInbox/Git.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2023-11-02 09:35:28 +0000
committerEric Wong <e@80x24.org>2023-11-02 23:46:54 +0000
commitdb47ea523760f7ceef3d38c0008e082e9e7d1c02 (patch)
treec16385b1824df5bc506fbe4c983e8fe3a31d0a48 /lib/PublicInbox/Git.pm
parent52cd1dd47c83f18681bab081db5041f8bfa5dfbe (diff)
downloadpublic-inbox-db47ea523760f7ceef3d38c0008e082e9e7d1c02.tar.gz
treewide: use ->close method rather than CORE::close
It's easier-to-read and should open the door for us to get rid
of `tie' for ProcessIO without performance penalties for
more frequently-used perlop calls and ability to do `stat' directly
on the object instead of the awkward `tied' thing.
Diffstat (limited to 'lib/PublicInbox/Git.pm')
-rw-r--r--lib/PublicInbox/Git.pm6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 191e4eea..3dac32be 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -441,12 +441,12 @@ sub qx {
         my $fh = popen(@_);
         if (wantarray) {
                 my @ret = <$fh>;
-                CORE::close $fh; # caller should check $?
+                $fh->close; # caller should check $?
                 @ret;
         } else {
                 local $/;
                 my $ret = <$fh>;
-                CORE::close $fh; # caller should check $?
+                $fh->close; # caller should check $?
                 $ret;
         }
 }
@@ -621,7 +621,7 @@ sub manifest_entry {
                 }
         }
         $ent->{fingerprint} = sha_all(1, $sr)->hexdigest;
-        CORE::close $sr or return; # empty, uninitialized git repo
+        $sr->close or return; # empty, uninitialized git repo
         $ent->{modified} = modified(undef, $mod);
         chomp($buf = <$own> // '');
         utf8::decode($buf);