about summary refs log tree commit homepage
diff options
authorEric Wong <e@80x24.org>2019-01-19 08:27:44 +0000
committerEric Wong <e@80x24.org>2019-01-20 04:24:54 +0000
commit37aadb7c7913442d470c050170639b37301cd6bf (patch)
parent8e7ce7fb5220a74dc17c07e8dce931d53d1b2c24 (diff)
Applying a 100+ patch series can be a pain and lead to a wayward
client monopolizing the connection.  On the other hand, we'll
also need to be careful and limit the number of in-flight file
descriptors and parallel git-apply processes when we move to an
evented model, here.
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm
index 42bb6033..13065348 100644
--- a/lib/PublicInbox/SolverGit.pm
+++ b/lib/PublicInbox/SolverGit.pm
@@ -358,6 +358,9 @@ sub apply_patches_cb ($$$$$) {
 # recreate $oid_b
 # Returns an array ref: [ ::Git object, oid_full, type, size, di ]
 # or undef if nothing was found.
+# TODO: complete the migration of this and ViewVCS into an evented
+# model for fairness
 sub solve ($$$$) {
         my ($self, $out, $oid_b, $hints) = @_;