From 37aadb7c7913442d470c050170639b37301cd6bf Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 19 Jan 2019 08:27:44 +0000 Subject: solver: add a TODO note about making this fully evented Applying a 100+ patch series can be a pain and lead to a wayward client monopolizing the connection. On the other hand, we'll also need to be careful and limit the number of in-flight file descriptors and parallel git-apply processes when we move to an evented model, here. --- lib/PublicInbox/SolverGit.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm index 42bb6033..13065348 100644 --- a/lib/PublicInbox/SolverGit.pm +++ b/lib/PublicInbox/SolverGit.pm @@ -358,6 +358,9 @@ sub apply_patches_cb ($$$$$) { # recreate $oid_b # Returns an array ref: [ ::Git object, oid_full, type, size, di ] # or undef if nothing was found. +# +# TODO: complete the migration of this and ViewVCS into an evented +# model for fairness sub solve ($$$$) { my ($self, $out, $oid_b, $hints) = @_; -- cgit v1.2.3-24-ge0c7