From: Kyle Meyer <kyle@kyleam.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH v2] watchmaildir: support multiple watchheader values
Date: Mon, 20 Apr 2020 01:13:22 +0000 [thread overview]
Message-ID: <877dybrmbx.fsf@kyleam.com> (raw)
In-Reply-To: <20200420004515.GA67768@dcvr>
Eric Wong <e@80x24.org> writes:
> Kyle Meyer <kyle@kyleam.com> wrote:
>
> <snip> Thanks. Most everything looks good, some minor issues..
>
>> +++ b/t/watch_muliple_headers.t
>
> speling :>
Oops, thanks.
>> +my $num = $ibx->mm->num_for('to@a.com');
>> +ok(defined $num, 'Matched for address in To:');
>> +my $num = $ibx->mm->num_for('cc@a.com');
>
> That `$num' shadows/masks
Ah, sorry. Aside from, er, actually knowing what I'm doing in perl and
seeing that obvious mistake, is there a way I could see the warning when
I run the tests? To run only the tests in that file as I was working on
it, I started with the command I saw when I called 'make test' and
restricted it to just the file, So, with typo included for historical
accuracy :), I was running
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" \
"-MTest::Harness" "-e" \
"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" \
t/watch_muliple_headers.t
> Will squash the following in before pushing:
Thanks!
next prev parent reply other threads:[~2020-04-20 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 4:44 [RFC PATCH] watchmaildir: support multiple watchheader values Kyle Meyer
2020-04-12 21:59 ` Eric Wong
2020-04-20 0:13 ` [PATCH v2] " Kyle Meyer
2020-04-20 0:45 ` Eric Wong
2020-04-20 1:13 ` Kyle Meyer [this message]
2020-04-20 1:32 ` Eric Wong
2020-04-20 7:05 ` [PATCH] doc: HACKING: add a bit about faster testing Eric Wong
2020-04-20 13:26 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dybrmbx.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).