From: Eric Wong <e@80x24.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH v2] watchmaildir: support multiple watchheader values
Date: Mon, 20 Apr 2020 00:45:15 +0000 [thread overview]
Message-ID: <20200420004515.GA67768@dcvr> (raw)
In-Reply-To: <20200420001332.14769-1-kyle@kyleam.com>
Kyle Meyer <kyle@kyleam.com> wrote:
<snip> Thanks. Most everything looks good, some minor issues..
> +++ b/t/watch_muliple_headers.t
speling :>
> +my $num = $ibx->mm->num_for('to@a.com');
> +ok(defined $num, 'Matched for address in To:');
> +my $num = $ibx->mm->num_for('cc@a.com');
That `$num' shadows/masks
Will squash the following in before pushing:
diff --git a/MANIFEST b/MANIFEST
index bfcf26b4..b06aa679 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -307,7 +307,7 @@ t/view.t
t/watch_filter_rubylang.t
t/watch_maildir.t
t/watch_maildir_v2.t
-t/watch_muliple_headers.t
+t/watch_multiple_headers.t
t/www_altid.t
t/www_listing.t
t/www_static.t
diff --git a/t/watch_muliple_headers.t b/t/watch_multiple_headers.t
similarity index 97%
rename from t/watch_muliple_headers.t
rename to t/watch_multiple_headers.t
index 8ea4b306..3a39eba9 100644
--- a/t/watch_muliple_headers.t
+++ b/t/watch_multiple_headers.t
@@ -68,7 +68,7 @@ ok($ibx, 'found inbox by name');
my $num = $ibx->mm->num_for('to@a.com');
ok(defined $num, 'Matched for address in To:');
-my $num = $ibx->mm->num_for('cc@a.com');
+$num = $ibx->mm->num_for('cc@a.com');
ok(defined $num, 'Matched for address in Cc:');
$num = $ibx->mm->num_for('none@a.com');
is($num, undef, 'No match without address in To: or Cc:');
On a side note, some of my private scripts use neither
-w, warnings, nor strict. It's quite liberating, especially
when combined with `do' instead of `require' :>
next prev parent reply other threads:[~2020-04-20 0:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 4:44 [RFC PATCH] watchmaildir: support multiple watchheader values Kyle Meyer
2020-04-12 21:59 ` Eric Wong
2020-04-20 0:13 ` [PATCH v2] " Kyle Meyer
2020-04-20 0:45 ` Eric Wong [this message]
2020-04-20 1:13 ` Kyle Meyer
2020-04-20 1:32 ` Eric Wong
2020-04-20 7:05 ` [PATCH] doc: HACKING: add a bit about faster testing Eric Wong
2020-04-20 13:26 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420004515.GA67768@dcvr \
--to=e@80x24.org \
--cc=kyle@kyleam.com \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).