user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Eric Wong <>
To: Kyle Meyer <>
Subject: Re: [PATCH v2] watchmaildir: support multiple watchheader values
Date: Mon, 20 Apr 2020 01:32:11 +0000
Message-ID: <20200420013211.GA30656@dcvr> (raw)
In-Reply-To: <>

Kyle Meyer <> wrote:
> Eric Wong <> writes:
> > Kyle Meyer <> wrote:
> >
> > <snip> Thanks.  Most everything looks good, some minor issues..
> >
> >> +++ b/t/watch_muliple_headers.t
> >
> > speling :>
> Oops, thanks.
> >> +my $num = $ibx->mm->num_for('');
> >> +ok(defined $num, 'Matched for address in To:');
> >> +my $num = $ibx->mm->num_for('');
> >
> > That `$num' shadows/masks
> Ah, sorry.  Aside from, er, actually knowing what I'm doing in perl and
> seeing that obvious mistake, is there a way I could see the warning when
> I run the tests?  To run only the tests in that file as I was working on
> it, I started with the command I saw when I called 'make test' and
> restricted it to just the file, So, with typo included for historical
> accuracy :), I was running

Ah, oops.  I normally use `make check' (or `check-run' after
being primed by `check').  HACKING needs to be patched, and
maybe a pointer to it in INSTALL.

I definitely want warnings enabled for hackers.  However, since
rare new warnings will surface from Perl(*), I'm less and less
enthusiastic about enabling them for non-hackers.

So I'm moving away from `use warnings' and may even consider
removing `-w' from the default shebangs and rely on PERL5OPT
or `-w' being propagated via `check-run'.

(*) Fwiw, I've hit only hit this 2-3 times in two decades.
    1) each iterator reuse (it was intentional :P)
    2) `{' and `}' in regexps
    I think there was another, but that's all I can think of atm.

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-12  4:44 [RFC PATCH] " Kyle Meyer
2020-04-12 21:59 ` Eric Wong
2020-04-20  0:13   ` [PATCH v2] " Kyle Meyer
2020-04-20  0:45     ` Eric Wong
2020-04-20  1:13       ` Kyle Meyer
2020-04-20  1:32         ` Eric Wong [this message]
2020-04-20  7:05           ` [PATCH] doc: HACKING: add a bit about faster testing Eric Wong
2020-04-20 13:26             ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420013211.GA30656@dcvr \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone