Re: [PATCH v2] watchmaildir: support multiple watchheader values

[Eric Wong <e@80x24.org>]

Kyle Meyer <kyle@kyleam.com> wrote:
> Eric Wong <e@80x24.org> writes:
> 
> > Kyle Meyer <kyle@kyleam.com> wrote:
> >
> > <snip> Thanks.  Most everything looks good, some minor issues..
> >
> >> +++ b/t/watch_muliple_headers.t
> >
> > speling :>
> 
> Oops, thanks.
> 
> >> +my $num = $ibx->mm->num_for('to@a.com');
> >> +ok(defined $num, 'Matched for address in To:');
> >> +my $num = $ibx->mm->num_for('cc@a.com');
> >
> > That `$num' shadows/masks
> 
> Ah, sorry.  Aside from, er, actually knowing what I'm doing in perl and
> seeing that obvious mistake, is there a way I could see the warning when
> I run the tests?  To run only the tests in that file as I was working on
> it, I started with the command I saw when I called 'make test' and
> restricted it to just the file, So, with typo included for historical
> accuracy :), I was running

Ah, oops.  I normally use `make check' (or `check-run' after
being primed by `check').  HACKING needs to be patched, and
maybe a pointer to it in INSTALL.

I definitely want warnings enabled for hackers.  However, since
rare new warnings will surface from Perl(*), I'm less and less
enthusiastic about enabling them for non-hackers.

So I'm moving away from `use warnings' and may even consider
removing `-w' from the default shebangs and rely on PERL5OPT
or `-w' being propagated via `check-run'.


(*) Fwiw, I've hit only hit this 2-3 times in two decades.
    1) each iterator reuse (it was intentional :P)
    2) `{' and `}' in regexps
    I think there was another, but that's all I can think of atm.