user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] t/mime: fix test to work w/o Email::MIME
@ 2020-05-10  9:41 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-05-10  9:41 UTC (permalink / raw)
  To: meta

Although the lazy loading changes were correct, the code
was still using PublicInbox::MIME as a fixed class.  Use
the `$cls' variable from the loop.

Favor ->subparts to ->parts, instead, too, since ->parts is
discouraged by the Email::MIME manpage and not implemented for
Eml.
---
 t/mime.t | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/mime.t b/t/mime.t
index d17ec58e92d..46c1d8d7f5a 100644
--- a/t/mime.t
+++ b/t/mime.t
@@ -16,7 +16,7 @@ use_ok $_ for @classes;
 local $SIG{__WARN__} = sub {}; # needed for old Email::Simple (used by E::M)
 
 for my $cls (@classes) {
-	my $msg = PublicInbox::MIME->new(<<'EOF');
+	my $msg = $cls->new(<<'EOF');
 From:   Richard Hansen <hansenr@google.com>
 To:     git@vger.kernel.org
 Cc:     Richard Hansen <hansenr@google.com>
@@ -49,7 +49,7 @@ dkTlB69771K2eXK4LcHSH/2LqX+VYa3K44vrx1ruzjXdNWzIpKBy0weFNiwnJCGofvCysM2RCSI1
 
 EOF
 
-	my @parts = $msg->parts;
+	my @parts = $msg->subparts;
 	my $exp = <<EOF;
 Richard Hansen (2):
   diff: document behavior of relative diff.orderFile

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10  9:41 [PATCH] t/mime: fix test to work w/o Email::MIME Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git