From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] t/mime: fix test to work w/o Email::MIME
Date: Sun, 10 May 2020 09:41:52 +0000 [thread overview]
Message-ID: <20200510094152.30128-1-e@yhbt.net> (raw)
Although the lazy loading changes were correct, the code
was still using PublicInbox::MIME as a fixed class. Use
the `$cls' variable from the loop.
Favor ->subparts to ->parts, instead, too, since ->parts is
discouraged by the Email::MIME manpage and not implemented for
Eml.
---
t/mime.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/mime.t b/t/mime.t
index d17ec58e92d..46c1d8d7f5a 100644
--- a/t/mime.t
+++ b/t/mime.t
@@ -16,7 +16,7 @@ use_ok $_ for @classes;
local $SIG{__WARN__} = sub {}; # needed for old Email::Simple (used by E::M)
for my $cls (@classes) {
- my $msg = PublicInbox::MIME->new(<<'EOF');
+ my $msg = $cls->new(<<'EOF');
From: Richard Hansen <hansenr@google.com>
To: git@vger.kernel.org
Cc: Richard Hansen <hansenr@google.com>
@@ -49,7 +49,7 @@ dkTlB69771K2eXK4LcHSH/2LqX+VYa3K44vrx1ruzjXdNWzIpKBy0weFNiwnJCGofvCysM2RCSI1
EOF
- my @parts = $msg->parts;
+ my @parts = $msg->subparts;
my $exp = <<EOF;
Richard Hansen (2):
diff: document behavior of relative diff.orderFile
reply other threads:[~2020-05-10 9:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510094152.30128-1-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).