* [PATCH] mbox: do not try to create filename from empty string
@ 2019-12-12 8:03 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-12-12 8:03 UTC (permalink / raw)
To: meta
This was causing warnings to pop up in syslogs for messages with
empty Subject headers.
---
lib/PublicInbox/Mbox.pm | 2 +-
lib/PublicInbox/MboxGz.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Mbox.pm b/lib/PublicInbox/Mbox.pm
index 42cedd15..c50a118b 100644
--- a/lib/PublicInbox/Mbox.pm
+++ b/lib/PublicInbox/Mbox.pm
@@ -18,7 +18,7 @@ use Email::MIME::Encode;
sub subject_fn ($) {
my ($hdr) = @_;
my $fn = $hdr->header('Subject');
- return 'no-subject' unless defined($fn);
+ return 'no-subject' if (!defined($fn) || $fn eq '');
# no need for full Email::MIME, here
if ($fn =~ /=\?/) {
diff --git a/lib/PublicInbox/MboxGz.pm b/lib/PublicInbox/MboxGz.pm
index 1621cff8..ef560426 100644
--- a/lib/PublicInbox/MboxGz.pm
+++ b/lib/PublicInbox/MboxGz.pm
@@ -23,7 +23,7 @@ sub response {
my $body = $class->new($ctx, $cb);
# http://www.iana.org/assignments/media-types/application/gzip
my @h = qw(Content-Type application/gzip);
- if ($fn) {
+ if (defined $fn && $fn ne '') {
$fn = to_filename($fn);
push @h, 'Content-Disposition', "inline; filename=$fn.mbox.gz";
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-12 8:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 8:03 [PATCH] mbox: do not try to create filename from empty string Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).