From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] mbox: do not try to create filename from empty string
Date: Thu, 12 Dec 2019 08:03:39 +0000 [thread overview]
Message-ID: <20191212080339.19030-1-e@80x24.org> (raw)
This was causing warnings to pop up in syslogs for messages with
empty Subject headers.
---
lib/PublicInbox/Mbox.pm | 2 +-
lib/PublicInbox/MboxGz.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Mbox.pm b/lib/PublicInbox/Mbox.pm
index 42cedd15..c50a118b 100644
--- a/lib/PublicInbox/Mbox.pm
+++ b/lib/PublicInbox/Mbox.pm
@@ -18,7 +18,7 @@ use Email::MIME::Encode;
sub subject_fn ($) {
my ($hdr) = @_;
my $fn = $hdr->header('Subject');
- return 'no-subject' unless defined($fn);
+ return 'no-subject' if (!defined($fn) || $fn eq '');
# no need for full Email::MIME, here
if ($fn =~ /=\?/) {
diff --git a/lib/PublicInbox/MboxGz.pm b/lib/PublicInbox/MboxGz.pm
index 1621cff8..ef560426 100644
--- a/lib/PublicInbox/MboxGz.pm
+++ b/lib/PublicInbox/MboxGz.pm
@@ -23,7 +23,7 @@ sub response {
my $body = $class->new($ctx, $cb);
# http://www.iana.org/assignments/media-types/application/gzip
my @h = qw(Content-Type application/gzip);
- if ($fn) {
+ if (defined $fn && $fn ne '') {
$fn = to_filename($fn);
push @h, 'Content-Disposition', "inline; filename=$fn.mbox.gz";
}
reply other threads:[~2019-12-12 8:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212080339.19030-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).