mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Stefan Beller <>
Cc: Heiko Voigt <>,
	"git\" <>,
	Jeff King <>, Jens Lehmann <>,
	Fredrik Gustafsson <>,
	Leandro Lucarella <>
Subject: Re: [PATCH v3 4/4] submodule_needs_pushing() NEEDSWORK when we can not answer this question
Date: Tue, 15 Nov 2016 16:13:51 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Stefan Beller's message of "Tue, 15 Nov 2016 14:39:10 -0800")

Stefan Beller <> writes:

>> "We do not know" ...
> ... because there is no way to check for us as we don't have the
> submodule commits.
>     " We do consider it safe as no one in their sane mind would
>     have changed the submodule pointers without having the
>     submodule around. If a user did however change the submodules
>     without having the submodule commits around, this indicates an
>     expert who knows what they were doing."

I didn't think it through myself to arrive at such a conclusion, but
to me the above sounds like a sensible reasoning [*1*].

>>   We currently
>> +                * proceed pushing here as if the submodules commits are
>> +                * available on a remote. Since we can not check the
>> +                * remote availability for this submodule we should
>> +                * consider changing this behavior to: Stop here and
>> +                * tell the user how to skip this check if wanted.
>> +                */
>>                 return 0;
> Thanks for adding the NEEDSWORK, I just wrote the above lines
> to clarify my thought process, not as a suggestion for change.

One thing I would suggest would be "Stop here, explain the situation
and then tell the user how to skip".  I am not convinced that it
would _help_ users and make it _safer_ if we stopped here, though.

> Overall the series looks good to me; the nits are minor IMHO.



*1* My version was more like "we do not know if they would get into
    a situation where they do not have enough submodule commits if
    we pushed our superproject, but more importantly, we DO KNOW
    that it would not help an iota if we pushed our submodule to
    them, so there is no point stopping the push of superproject
    saying 'no, no, no, you must push the submodule first'".

  reply	other threads:[~2016-11-16  0:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 14:56 [PATCH v3 0/4] Speedup finding of unpushed submodules Heiko Voigt
2016-11-15 14:56 ` [PATCH v3 1/4] serialize collection of changed submodules Heiko Voigt
2016-11-15 22:15   ` Stefan Beller
2016-11-15 14:56 ` [PATCH v3 2/4] serialize collection of refs that contain submodule changes Heiko Voigt
2016-11-15 22:20   ` Stefan Beller
2016-11-15 14:56 ` [PATCH v3 3/4] batch check whether submodule needs pushing into one call Heiko Voigt
2016-11-15 22:28   ` Stefan Beller
2016-11-16 14:29     ` Heiko Voigt
2016-11-15 14:56 ` [PATCH v3 4/4] submodule_needs_pushing() NEEDSWORK when we can not answer this question Heiko Voigt
2016-11-15 22:39   ` Stefan Beller
2016-11-16  0:13     ` Junio C Hamano [this message]
2016-11-16 14:26       ` Heiko Voigt
2016-11-15 17:43 ` [PATCH v3 0/4] Speedup finding of unpushed submodules Stefan Beller
2016-11-15 17:52   ` Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).