From: Stefan Beller <sbeller@google.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Jeff King <peff@peff.net>, Jens Lehmann <Jens.Lehmann@web.de>,
Fredrik Gustafsson <iveqy@iveqy.com>,
Leandro Lucarella <leandro.lucarella@sociomantic.com>
Subject: Re: [PATCH v3 1/4] serialize collection of changed submodules
Date: Tue, 15 Nov 2016 14:15:31 -0800 [thread overview]
Message-ID: <CAGZ79kYBf_B4ZQ7CoTt62ZR-qXhHNBEWem5K-r1eOPrUPYufrw@mail.gmail.com> (raw)
In-Reply-To: <67e11474d4fd8ada2652809cf14f6c4d96be55ff.1479221071.git.hvoigt@hvoigt.net>
On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> @@ -560,6 +575,31 @@ static void find_unpushed_submodule_commits(struct commit *commit,
> diff_tree_combined_merge(commit, 1, &rev);
> }
>
> +struct collect_submodule_from_sha1s_data {
> + char *submodule_path;
> + struct string_list *needs_pushing;
> +};
> +
> +static int collect_submodules_from_sha1s(const unsigned char sha1[20],
> + void *data)
> +{
> + struct collect_submodule_from_sha1s_data *me =
> + (struct collect_submodule_from_sha1s_data *) data;
nit: no explicit cast needed when coming from void* ?
next prev parent reply other threads:[~2016-11-15 22:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:56 [PATCH v3 0/4] Speedup finding of unpushed submodules Heiko Voigt
2016-11-15 14:56 ` [PATCH v3 1/4] serialize collection of changed submodules Heiko Voigt
2016-11-15 22:15 ` Stefan Beller [this message]
2016-11-15 14:56 ` [PATCH v3 2/4] serialize collection of refs that contain submodule changes Heiko Voigt
2016-11-15 22:20 ` Stefan Beller
2016-11-15 14:56 ` [PATCH v3 3/4] batch check whether submodule needs pushing into one call Heiko Voigt
2016-11-15 22:28 ` Stefan Beller
2016-11-16 14:29 ` Heiko Voigt
2016-11-15 14:56 ` [PATCH v3 4/4] submodule_needs_pushing() NEEDSWORK when we can not answer this question Heiko Voigt
2016-11-15 22:39 ` Stefan Beller
2016-11-16 0:13 ` Junio C Hamano
2016-11-16 14:26 ` Heiko Voigt
2016-11-15 17:43 ` [PATCH v3 0/4] Speedup finding of unpushed submodules Stefan Beller
2016-11-15 17:52 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kYBf_B4ZQ7CoTt62ZR-qXhHNBEWem5K-r1eOPrUPYufrw@mail.gmail.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=iveqy@iveqy.com \
--cc=leandro.lucarella@sociomantic.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).