From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Stefan Beller <sbeller@google.com>,
Jens.Lehmann@web.de, Fredrik Gustafsson <iveqy@iveqy.com>,
Leandro Lucarella <leandro.lucarella@sociomantic.com>
Subject: [PATCH v3 4/4] submodule_needs_pushing() NEEDSWORK when we can not answer this question
Date: Tue, 15 Nov 2016 15:56:17 +0100 [thread overview]
Message-ID: <1d87628994df89751afdcc7e180ebcdc29dde722.1479221071.git.hvoigt@hvoigt.net> (raw)
In-Reply-To: <cover.1479221071.git.hvoigt@hvoigt.net>
In-Reply-To: <cover.1479221071.git.hvoigt@hvoigt.net>
Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
submodule.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/submodule.c b/submodule.c
index e1196fd..29efee9 100644
--- a/submodule.c
+++ b/submodule.c
@@ -531,6 +531,14 @@ static int submodule_has_commits(const char *path, struct sha1_array *commits)
static int submodule_needs_pushing(const char *path, struct sha1_array *commits)
{
if (!submodule_has_commits(path, commits))
+ /* NEEDSWORK: The correct answer here is "We do not
+ * know" instead of "No push needed". We currently
+ * proceed pushing here as if the submodules commits are
+ * available on a remote. Since we can not check the
+ * remote availability for this submodule we should
+ * consider changing this behavior to: Stop here and
+ * tell the user how to skip this check if wanted.
+ */
return 0;
if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
--
2.10.1.386.gc503e45
next prev parent reply other threads:[~2016-11-15 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:56 [PATCH v3 0/4] Speedup finding of unpushed submodules Heiko Voigt
2016-11-15 14:56 ` [PATCH v3 1/4] serialize collection of changed submodules Heiko Voigt
2016-11-15 22:15 ` Stefan Beller
2016-11-15 14:56 ` [PATCH v3 2/4] serialize collection of refs that contain submodule changes Heiko Voigt
2016-11-15 22:20 ` Stefan Beller
2016-11-15 14:56 ` [PATCH v3 3/4] batch check whether submodule needs pushing into one call Heiko Voigt
2016-11-15 22:28 ` Stefan Beller
2016-11-16 14:29 ` Heiko Voigt
2016-11-15 14:56 ` Heiko Voigt [this message]
2016-11-15 22:39 ` [PATCH v3 4/4] submodule_needs_pushing() NEEDSWORK when we can not answer this question Stefan Beller
2016-11-16 0:13 ` Junio C Hamano
2016-11-16 14:26 ` Heiko Voigt
2016-11-15 17:43 ` [PATCH v3 0/4] Speedup finding of unpushed submodules Stefan Beller
2016-11-15 17:52 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d87628994df89751afdcc7e180ebcdc29dde722.1479221071.git.hvoigt@hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
--cc=leandro.lucarella@sociomantic.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).