From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff King <peff@peff.net>, Jacob Keller <jacob.keller@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC PATCH] show decorations at the end of the line
Date: Tue, 21 Feb 2017 12:11:08 -0800 [thread overview]
Message-ID: <xmqqpoibfgo3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CA+55aFwdUxCvmi28T3yn1K4rqn2bZmJBdTRr7tSbMa-g5izHbw@mail.gmail.com> (Linus Torvalds's message of "Sun, 19 Feb 2017 17:48:28 -0800")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> That source showing should never have been in "show_decorations()" in
> the first place. It just happened to be a convenient place for it.
>
> So this attached patch is just my original patch updated to split up
> "show_source()" from "show_decorations()", and show it where it used
> to be.
The updated organization smells a lot better to me ;-)
Most of the time it is convenient to have "show source" at the
beginning of a single helper that is to show both, but oneline
format is so special that it makes it inconvenient to have them at
the same place.
I can lose the patch to 4202 (update the expectation for --source)
I added to the previous one, but the patch to 4207 (update the
expectation for --decorate) needs to be kept with this round.
Will replace; thanks.
next prev parent reply other threads:[~2017-02-21 20:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 18:02 [RFC PATCH] show decorations at the end of the line Linus Torvalds
2017-02-11 18:13 ` Linus Torvalds
2017-02-13 8:30 ` Junio C Hamano
2017-02-13 19:33 ` Linus Torvalds
2017-02-13 21:01 ` Junio C Hamano
2017-02-13 22:38 ` Jeff King
2017-02-14 22:11 ` Junio C Hamano
2017-02-15 0:29 ` Jeff King
2017-02-18 5:27 ` Junio C Hamano
2017-02-19 22:33 ` Linus Torvalds
2017-02-19 23:03 ` Jacob Keller
2017-02-20 0:46 ` Jeff King
2017-02-20 1:15 ` Junio C Hamano
2017-02-20 1:48 ` Linus Torvalds
2017-02-21 20:11 ` Junio C Hamano [this message]
2017-02-21 20:40 ` Linus Torvalds
2017-02-21 21:08 ` Jeff King
2017-02-21 21:47 ` Junio C Hamano
2017-02-21 22:24 ` Jeff King
2017-02-14 20:36 ` Stephan Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpoibfgo3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).