From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC PATCH] show decorations at the end of the line
Date: Tue, 14 Feb 2017 19:29:02 -0500 [thread overview]
Message-ID: <20170215002901.gtzegvhyy7d6cvrb@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqr330779h.fsf@gitster.mtv.corp.google.com>
On Tue, Feb 14, 2017 at 02:11:06PM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Thanks. We'd need to update the tests that expects the old style
> > output, though.
>
> The updates to the expectation look like this (already squashed).
> The --source decorations in 4202 are also shown at the end, which
> probably is in line with the way --show-decorations adds them at the
> end of the line, but was somewhat surprising from reading only the
> log message.
Hrm, that does surprise me. I'm not sure if that's desirable or not. I
do think some of the "nobody could possibly be parsing these" arguments
about decorations do not apply to --source (and also, they're harder for
humans to pick out from the end of the line as they lack punctuation and
color).
-Peff
next prev parent reply other threads:[~2017-02-15 0:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 18:02 [RFC PATCH] show decorations at the end of the line Linus Torvalds
2017-02-11 18:13 ` Linus Torvalds
2017-02-13 8:30 ` Junio C Hamano
2017-02-13 19:33 ` Linus Torvalds
2017-02-13 21:01 ` Junio C Hamano
2017-02-13 22:38 ` Jeff King
2017-02-14 22:11 ` Junio C Hamano
2017-02-15 0:29 ` Jeff King [this message]
2017-02-18 5:27 ` Junio C Hamano
2017-02-19 22:33 ` Linus Torvalds
2017-02-19 23:03 ` Jacob Keller
2017-02-20 0:46 ` Jeff King
2017-02-20 1:15 ` Junio C Hamano
2017-02-20 1:48 ` Linus Torvalds
2017-02-21 20:11 ` Junio C Hamano
2017-02-21 20:40 ` Linus Torvalds
2017-02-21 21:08 ` Jeff King
2017-02-21 21:47 ` Junio C Hamano
2017-02-21 22:24 ` Jeff King
2017-02-14 20:36 ` Stephan Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215002901.gtzegvhyy7d6cvrb@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).