From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC PATCH] show decorations at the end of the line
Date: Sat, 11 Feb 2017 10:13:44 -0800 [thread overview]
Message-ID: <CA+55aFw2S14a4_4YK0b6PNK4TH_AUo_+2JN+PTyBTufNeB5t6A@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1702110943460.31350@i7.lan>
On Sat, Feb 11, 2017 at 10:02 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I've signed off on this, because I think it's an "obvious" improvement,
> but I'm putting the "RFC" in the subject line because this is clearly a
> subjective thing.
Side note: the one downside of showing the decorations at the end of
the line is that now they are obviously at the end of the line - and
thus likely to be more hidden by things like line truncation.
The default git settings (LESS=FRX) no longer truncate log output
lines, but if you use "-S" or "--chop-long-lines", you will obviously
be missing the end of long lines.
So moving the decorations to the end does obviously have a real UI
impact, apart from just being "prettier".
I just wanted to point that out. I still prefer decorations at ends of
lines (and yes, that's despite the fact that I actually personally use
the traditional git setting of "LESS=FRSX"), but it is perhaps
something that people should be aware of if this patch causes
discussion.
Linus
next prev parent reply other threads:[~2017-02-11 18:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 18:02 [RFC PATCH] show decorations at the end of the line Linus Torvalds
2017-02-11 18:13 ` Linus Torvalds [this message]
2017-02-13 8:30 ` Junio C Hamano
2017-02-13 19:33 ` Linus Torvalds
2017-02-13 21:01 ` Junio C Hamano
2017-02-13 22:38 ` Jeff King
2017-02-14 22:11 ` Junio C Hamano
2017-02-15 0:29 ` Jeff King
2017-02-18 5:27 ` Junio C Hamano
2017-02-19 22:33 ` Linus Torvalds
2017-02-19 23:03 ` Jacob Keller
2017-02-20 0:46 ` Jeff King
2017-02-20 1:15 ` Junio C Hamano
2017-02-20 1:48 ` Linus Torvalds
2017-02-21 20:11 ` Junio C Hamano
2017-02-21 20:40 ` Linus Torvalds
2017-02-21 21:08 ` Jeff King
2017-02-21 21:47 ` Junio C Hamano
2017-02-21 22:24 ` Jeff King
2017-02-14 20:36 ` Stephan Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFw2S14a4_4YK0b6PNK4TH_AUo_+2JN+PTyBTufNeB5t6A@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).