From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Wong <e@80x24.org>, git@vger.kernel.org
Subject: Re: RFC: Enable delayed responses to Git clean/smudge filter requests
Date: Wed, 16 Nov 2016 19:47:17 +0100 [thread overview]
Message-ID: <2F93C9B4-157C-4F5C-9BD5-A67AA519757A@gmail.com> (raw)
In-Reply-To: <xmqqpolvqoka.fsf@gitster.mtv.corp.google.com>
> On 16 Nov 2016, at 19:15, Junio C Hamano <gitster@pobox.com> wrote:
>
> Lars Schneider <larsxschneider@gmail.com> writes:
>
>>> * You'd need to rein in the maximum parallelism somehow, as you do
>>> not want to see hundreds of competing filter processes starting
>>> only to tell the main loop over an index with hundreds of entries
>>> that they are delayed checkouts.
>>
>> I intend to implement this feature only for the new long running filter
>> process protocol. OK with you?
>
> Do you mean that a long-running filter process interacting with
> convert_to_worktree() called from checkout_entry() will be the only
> codepath that will spawn multiple processes or threads?
>
> That is fine, but it does not change the fact that you still need to
> limit the maximum parallelism there.
Filters using the long running protocol are spawned only once by Git.
The filter process would get all the smudge requests via the pipe
protocol and is supposed to manage the parallelism on its own.
- Lars
next prev parent reply other threads:[~2016-11-16 18:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 21:09 RFC: Enable delayed responses to Git clean/smudge filter requests Lars Schneider
2016-11-15 1:03 ` Eric Wong
2016-11-15 14:29 ` Lars Schneider
2016-11-15 18:03 ` Junio C Hamano
2016-11-16 9:53 ` Lars Schneider
2016-11-16 18:15 ` Junio C Hamano
2016-11-16 18:47 ` Lars Schneider [this message]
2016-11-16 19:19 ` Junio C Hamano
2016-11-16 22:41 ` Jakub Narębski
2016-11-16 23:46 ` Junio C Hamano
2016-11-17 9:19 ` Lars Schneider
2016-11-24 15:45 ` Lars Schneider
2016-11-28 21:48 ` Junio C Hamano
2016-11-15 18:27 ` Eric Wong
2017-01-09 20:44 ` Stefan Beller
2017-01-11 12:57 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2F93C9B4-157C-4F5C-9BD5-A67AA519757A@gmail.com \
--to=larsxschneider@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).