From: Lars Schneider <email@example.com>
To: Stefan Beller <firstname.lastname@example.org>
Cc: Git Mailing List <email@example.com>
Subject: Re: RFC: Enable delayed responses to Git clean/smudge filter requests
Date: Wed, 11 Jan 2017 13:57:49 +0100 [thread overview]
Message-ID: <B46B8E63-4447-4182-B95C-8D1E02D71F6F@gmail.com> (raw)
> On 09 Jan 2017, at 21:44, Stefan Beller <firstname.lastname@example.org> wrote:
> On Mon, Nov 14, 2016 at 1:09 PM, Lars Schneider
> <email@example.com> wrote:
>> Git always performs a clean/smudge filter on files in sequential order.
>> Sometimes a filter operation can take a noticeable amount of time.
>> This blocks the entire Git process.
>> I would like to give a filter process the possibility to answer Git with
>> "I got your request, I am processing it, ask me for the result later!".
>> I see the following way to realize this:
>> In unpack-trees.c:check_updates()  we loop through the cache
>> entries and "ask me later" could be an acceptable return value of the
>> checkout_entry() call. The loop could run until all entries returned
>> success or error.
> Late to this thread, but here is an answer nevertheless.
> I am currently working on getting submodules working
> for working tree modifying commands (prominently checkout, but
> also read-tree -u and any other caller that uses the code in
> Once the submodules are supported and used, I anticipate that
> putting the files in the working tree on disk will become a bottle neck,
> i.e. the checkout taking way too long for an oversized project.
> So in the future we have to do something to make checkout fast
> again, which IMHO is threading. My current vision is to have checkout
> automatically choose a number of threads based on expected workload,
> c.f. preload-index.c, line 18-25.
That sounds interesting! We are using "submodule.fetchjobs=0" to process
submodules in parallel already and it works great! Thanks a lot for
>> The filter machinery is triggered in various other places in Git and
>> all places that want to support "ask me later" would need to be patched
> I think this makes sense, even in a threaded git-checkout.
> I assume this idea is implemented before threading hits checkout,
> so a question on the design:
> Who determines the workload that is acceptable?
> From reading this email, it seems to be solely the filter that uses
> as many threads/processes as it thinks is ok.
> Would it be possible to enhance the protocol further to have
> Git also mingle with the workload, i.e. tell the filter it is
> allowed to use up (N-M) threads, as it itself already uses
> M out of N configured threads?
> (I do not want to discuss the details here, but only if such a thing
> is viable with this approach as well)
Yes, I think we could give a filter these kind of hints. However, it
would, of course, be up to the filter implementation to follow the hints.
In case you curious, here is the discussion on v1 of the delay implementation:
prev parent reply other threads:[~2017-01-11 12:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 21:09 RFC: Enable delayed responses to Git clean/smudge filter requests Lars Schneider
2016-11-15 1:03 ` Eric Wong
2016-11-15 14:29 ` Lars Schneider
2016-11-15 18:03 ` Junio C Hamano
2016-11-16 9:53 ` Lars Schneider
2016-11-16 18:15 ` Junio C Hamano
2016-11-16 18:47 ` Lars Schneider
2016-11-16 19:19 ` Junio C Hamano
2016-11-16 22:41 ` Jakub Narębski
2016-11-16 23:46 ` Junio C Hamano
2016-11-17 9:19 ` Lars Schneider
2016-11-24 15:45 ` Lars Schneider
2016-11-28 21:48 ` Junio C Hamano
2016-11-15 18:27 ` Eric Wong
2017-01-09 20:44 ` Stefan Beller
2017-01-11 12:57 ` Lars Schneider [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).