From: Eric Wong <e@80x24.org>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: RFC: Enable delayed responses to Git clean/smudge filter requests
Date: Tue, 15 Nov 2016 01:03:56 +0000 [thread overview]
Message-ID: <20161115010356.GA29602@starla> (raw)
In-Reply-To: <D10F7C47-14E8-465B-8B7A-A09A1B28A39F@gmail.com>
Lars Schneider <larsxschneider@gmail.com> wrote:
> Hi,
>
> Git always performs a clean/smudge filter on files in sequential order.
> Sometimes a filter operation can take a noticeable amount of time.
> This blocks the entire Git process.
I have the same problem in many places which aren't git :>
> I would like to give a filter process the possibility to answer Git with
> "I got your request, I am processing it, ask me for the result later!".
>
> I see the following way to realize this:
>
> In unpack-trees.c:check_updates() [1] we loop through the cache
> entries and "ask me later" could be an acceptable return value of the
> checkout_entry() call. The loop could run until all entries returned
> success or error.
>
> The filter machinery is triggered in various other places in Git and
> all places that want to support "ask me later" would need to be patched
> accordingly.
That all sounds reasonable.
The filter itself would need to be aware of parallelism
if it lives for multiple objects, right?
> Do you think this could be a viable approach?
It'd probably require a bit of work, but yes, I think it's viable.
We already do this with curl_multi requests for parallel
fetching from dumb HTTP servers, but that's driven by curl
internals operating with a select/poll loop.
Perhaps the curl API could be a good example for doing this.
> Do you see a better way?
Nope, I prefer non-blocking state machines to threads for
debuggability and determinism.
Anyways, I'll plan on doing something similar (in Perl) with the
synchronous parts of public-inbox which relies on "cat-file --batch"
at some point... (my rotational disks are sloooooooow :<)
next prev parent reply other threads:[~2016-11-15 1:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 21:09 RFC: Enable delayed responses to Git clean/smudge filter requests Lars Schneider
2016-11-15 1:03 ` Eric Wong [this message]
2016-11-15 14:29 ` Lars Schneider
2016-11-15 18:03 ` Junio C Hamano
2016-11-16 9:53 ` Lars Schneider
2016-11-16 18:15 ` Junio C Hamano
2016-11-16 18:47 ` Lars Schneider
2016-11-16 19:19 ` Junio C Hamano
2016-11-16 22:41 ` Jakub Narębski
2016-11-16 23:46 ` Junio C Hamano
2016-11-17 9:19 ` Lars Schneider
2016-11-24 15:45 ` Lars Schneider
2016-11-28 21:48 ` Junio C Hamano
2016-11-15 18:27 ` Eric Wong
2017-01-09 20:44 ` Stefan Beller
2017-01-11 12:57 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115010356.GA29602@starla \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).