mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [RFC] Add way to make Git credentials accessible from clean/smudge filter
@ 2016-11-10 11:52 Lars Schneider
  2016-11-10 12:10 ` Matthieu Moy
  0 siblings, 1 reply; 9+ messages in thread
From: Lars Schneider @ 2016-11-10 11:52 UTC (permalink / raw)
  To: git; +Cc: Jeff King, me


we just implemented the first "real-world" user of the new clean/smudge 
"filter protocol" interface (see "convert: add filter.<driver>.process option"
edcc858 for details) and the results are fantastic. Filtering 12,000 files in
my artificial test repo is more than 60x faster (depending on the platform). 
On Windows that means the clean/smudge operations runs in 57 seconds instead 
of 55 minutes [1]!

I have a number of ideas to improve the protocol even further and I am seeking
early feedback on the following - possibly most controversial - idea:

Some filters might want to perform additional network interactions and these
filters would like to use the Git credentials to perform these actions. If
such a filter is configured with "offerCredentials = true" then the filter 
could request the current Git credentials via the "filter-protocol".

A configuration could look like this:
[filter "myfilter"]
    process = my-filter-process
    required = true
    offerCredentials = true

The default would, of course, be "offerCredentials = false".

I haven't looked at an implemenation approach at all. I wonder if this could
be OK from a conceptional point of view or if there are obvious security 
problems that I am missing.



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-11-12 13:58 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-10 11:52 [RFC] Add way to make Git credentials accessible from clean/smudge filter Lars Schneider
2016-11-10 12:10 ` Matthieu Moy
2016-11-10 16:08   ` Jeff King
2016-11-11  9:28     ` Lars Schneider
2016-11-11  9:31       ` Jeff King
2016-11-11  9:40         ` Lars Schneider
2016-11-11 20:02           ` Dennis Kaarsemaker
2016-11-11 20:27             ` Jeff King
2016-11-12 13:57               ` Lars Schneider

Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).