mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Lars Schneider <>
To: Jeff King <>
Cc: Matthieu Moy <>,
	git <>,
Subject: Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter
Date: Fri, 11 Nov 2016 10:28:56 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 10 Nov 2016, at 17:08, Jeff King <> wrote:

> On Thu, Nov 10, 2016 at 01:10:17PM +0100, Matthieu Moy wrote:
>> Lars Schneider <> writes:
>>> I haven't looked at an implemenation approach at all. I wonder if this could
>>> be OK from a conceptional point of view or if there are obvious security 
>>> problems that I am missing.
>> Did you consider just running "git credential" from the filter? It may
>> not be the perfect solution, but it should work. I already used it to
>> get credential from a remote-helper (git-remote-mediawiki). When
>> prompting credentials interactively, it grabs the terminal directly, so
>> it work even if stdin/stdout are used for the protocol.
> Yeah, that is the solution I was going to suggest. The credentials are
> totally orthogonal to the filters, and I would rather not shove them
> into the protocol. It's an extra process, but with the new multi-use
> smudge filter, it's one per git invocation, not one per file.

The trouble with "git credential" is that it works only if the credential 
helper is setup correctly. Although I assume that most people have setup this, 
I have also worked with a number of people who prefer to enter their passwords 
every time Git makes a network connection.

- Lars

  reply	other threads:[~2016-11-11  9:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10 11:52 [RFC] Add way to make Git credentials accessible from clean/smudge filter Lars Schneider
2016-11-10 12:10 ` Matthieu Moy
2016-11-10 16:08   ` Jeff King
2016-11-11  9:28     ` Lars Schneider [this message]
2016-11-11  9:31       ` Jeff King
2016-11-11  9:40         ` Lars Schneider
2016-11-11 20:02           ` Dennis Kaarsemaker
2016-11-11 20:27             ` Jeff King
2016-11-12 13:57               ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).