From: Theodore Tso <tytso@mit.edu>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Daniel Berlin <dberlin@dberlin.org>,
David Miller <davem@davemloft.net>,
ismail@pardus.org.tr, gcc@gcc.gnu.org, git@vger.kernel.org,
gitster@pobox.com
Subject: Re: [PATCH] gc --aggressive: make it really aggressive
Date: Thu, 6 Dec 2007 08:42:44 -0500 [thread overview]
Message-ID: <20071206134243.GA17037@thunk.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712061201580.27959@racer.site>
On Thu, Dec 06, 2007 at 12:03:38PM +0000, Johannes Schindelin wrote:
>
> The default was not to change the window or depth at all. As suggested
> by Jon Smirl, Linus Torvalds and others, default to
>
> --window=250 --depth=250
I'd also suggest adding a comment in the man pages that this should
only be done rarely, and that it can potentially take a *long* time
(i.e., overnight) for big repositories, and in general it's not worth
the effort to use --aggressive.
Apologies to Linus and to the gcc folks, since I was the one who
originally coded up gc --aggressive, and at the time my intent was
"rarely does it make sense, and it may take a long time". The reason
why I didn't make the default --window and --depth larger is because
at the time the biggest repo I had easy access to was the Linux
kernel's, and there you rapidly hit diminishing returns at much
smaller numbers, so there was no real point in using --window=250
--depth=250.
Linus later pointed out that what we *really* should do is at some
point was to change repack -f to potentially retry to find a better
delta, but to reuse the existing delta if it was no worse. That
automatically does the right thing in the case where you had
previously done a repack with --window=<large n> --depth=<large n>,
but then later try using "gc --agressive", which ends up doing a worse
job and throwing away the information from the previous repack with
large window and depth sizes. Unfortunately no one ever got around to
implementing that.
Regards,
- Ted
next prev parent reply other threads:[~2007-12-06 13:43 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4aca3dc20712051108s216d3331t8061ef45b9aa324a@mail.gmail.com>
2007-12-06 2:28 ` Git and GCC David Miller
2007-12-06 2:41 ` Daniel Berlin
2007-12-06 2:52 ` David Miller
2007-12-06 3:47 ` Daniel Berlin
2007-12-06 4:20 ` David Miller
2007-12-06 4:28 ` Harvey Harrison
2007-12-06 4:32 ` Daniel Berlin
2007-12-06 4:48 ` David Miller
2007-12-06 5:11 ` Daniel Berlin
2007-12-06 5:15 ` Harvey Harrison
2007-12-06 5:17 ` Daniel Berlin
2007-12-06 6:47 ` Jon Smirl
2007-12-06 7:15 ` Jeff King
2007-12-06 14:18 ` Nicolas Pitre
2007-12-06 17:39 ` Jeff King
2007-12-06 18:02 ` Nicolas Pitre
2007-12-07 6:50 ` Jeff King
2007-12-07 7:27 ` Jeff King
2007-12-06 18:35 ` Linus Torvalds
2007-12-06 18:55 ` Jon Smirl
2007-12-06 19:08 ` Nicolas Pitre
2007-12-06 21:39 ` Jon Smirl
2007-12-06 22:08 ` Nicolas Pitre
2007-12-06 22:11 ` Jon Smirl
2007-12-06 22:22 ` Jon Smirl
2007-12-06 22:30 ` Nicolas Pitre
2007-12-06 22:44 ` Jon Smirl
2007-12-07 7:31 ` Jeff King
2007-12-08 0:47 ` Harvey Harrison
2007-12-10 9:54 ` Gabriel Paubert
2007-12-10 15:35 ` Nicolas Pitre
2007-12-07 3:31 ` David Miller
2007-12-07 6:38 ` Jeff King
2007-12-07 7:10 ` Jon Smirl
2007-12-07 12:53 ` David Miller
2007-12-07 17:23 ` Linus Torvalds
2007-12-07 20:26 ` Giovanni Bajo
2007-12-07 22:14 ` Jakub Narebski
2007-12-07 23:04 ` Luke Lu
2007-12-07 23:14 ` Giovanni Bajo
2007-12-07 23:33 ` Daniel Berlin
2007-12-08 12:00 ` Johannes Schindelin
2007-12-08 1:55 ` David Miller
2007-12-10 9:57 ` David Miller
2007-12-06 6:09 ` Linus Torvalds
2007-12-06 7:49 ` Harvey Harrison
2007-12-06 8:11 ` David Brown
2007-12-06 14:01 ` Nicolas Pitre
2007-12-06 12:03 ` [PATCH] gc --aggressive: make it really aggressive Johannes Schindelin
2007-12-06 13:42 ` Theodore Tso [this message]
2007-12-06 14:15 ` Nicolas Pitre
2007-12-06 14:22 ` Pierre Habouzit
2007-12-06 15:55 ` Johannes Schindelin
2007-12-06 17:05 ` David Kastrup
2007-12-06 15:30 ` Harvey Harrison
2007-12-06 15:56 ` Johannes Schindelin
2007-12-06 16:19 ` Linus Torvalds
2009-03-18 16:01 ` Johannes Schindelin
2009-03-18 16:27 ` Teemu Likonen
2009-03-18 18:02 ` Nicolas Pitre
2007-12-06 18:04 ` Git and GCC Daniel Berlin
2007-12-06 18:29 ` Linus Torvalds
2007-12-07 2:42 ` Harvey Harrison
2007-12-07 3:01 ` Linus Torvalds
2007-12-07 4:06 ` Jon Smirl
2007-12-07 4:21 ` Nicolas Pitre
2007-12-07 5:21 ` Linus Torvalds
2007-12-07 7:08 ` Jon Smirl
2007-12-07 19:36 ` Nicolas Pitre
2007-12-06 18:24 ` NightStrike
2007-12-06 18:45 ` Linus Torvalds
2007-12-07 5:36 ` NightStrike
2007-12-06 19:12 ` Jon Loeliger
2007-12-06 19:39 ` Linus Torvalds
2007-12-07 0:29 ` Jakub Narebski
2007-12-06 20:04 ` Junio C Hamano
2007-12-06 21:02 ` Junio C Hamano
2007-12-06 22:26 ` David Kastrup
2007-12-06 22:38 ` [OT] " Randy Dunlap
2007-12-06 4:25 ` Harvey Harrison
2007-12-06 4:54 ` Linus Torvalds
2007-12-06 5:04 ` Harvey Harrison
2007-12-06 11:57 ` Johannes Schindelin
2007-12-06 12:04 ` Ismail Dönmez
[not found] ` <2007-12-05-21-23-14+trackit+sam@rfc1149.net>
[not found] ` <1196891451.10408.54.camel@brick>
[not found] ` <jeeje0ogvk.fsf@sykes.suse.de>
[not found] ` <1196897840.10408.57.camel@brick>
[not found] ` <38a0d8450712130640p1b5d74d6nfa124ad0b0110d64@mail.gmail.com>
[not found] ` <1197572755.898.15.camel@brick>
2007-12-17 22:15 ` "Argument list too long" in git remote update (Was: Git and GCC) Geert Bosch
2007-12-17 22:59 ` Johannes Schindelin
2007-12-17 23:01 ` Linus Torvalds
2007-12-18 1:34 ` Derek Fawcus
2007-12-18 1:52 ` Shawn O. Pearce
2007-12-06 19:07 [PATCH] gc --aggressive: make it really aggressive J.C. Pizarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071206134243.GA17037@thunk.org \
--to=tytso@mit.edu \
--cc=Johannes.Schindelin@gmx.de \
--cc=davem@davemloft.net \
--cc=dberlin@dberlin.org \
--cc=gcc@gcc.gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ismail@pardus.org.tr \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).