From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH 1/2] files_read_raw_ref: avoid infinite loop on broken symlinks
Date: Thu, 6 Oct 2016 21:31:22 +0200 [thread overview]
Message-ID: <1c39b371-eb41-05d9-3c48-bd41764c9c9a@kdbg.org> (raw)
In-Reply-To: <20161006164825.otms5ovz2vzanimw@sigill.intra.peff.net>
Am 06.10.2016 um 18:48 schrieb Jeff King:
> +test_expect_success SYMLINKS 'ref resolution not confused by broken symlinks' '
> + ln -s does-not-exist .git/broken &&
> + test_must_fail git rev-parse --verify broken
Hm, lower-case named refs directly in .git are frowned upon, no? If we
ever decide to forbid them outright, this ref-parse might still fail,
but for the wrong reason. Should you not better pick an example below ref/?
-- Hannes
next prev parent reply other threads:[~2016-10-06 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 16:47 [PATCH 0/2] fix infinite loop in ref resolution Jeff King
2016-10-06 16:48 ` [PATCH 1/2] files_read_raw_ref: avoid infinite loop on broken symlinks Jeff King
2016-10-06 19:31 ` Johannes Sixt [this message]
2016-10-06 19:41 ` [PATCH v2 " Jeff King
2016-10-10 10:32 ` Michael Haggerty
2016-10-06 16:48 ` [PATCH 2/2] files_read_raw_ref: prevent infinite retry loops in general Jeff King
2016-10-10 10:34 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c39b371-eb41-05d9-3c48-bd41764c9c9a@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).