From: Michael Haggerty <mhagger@alum.mit.edu>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] files_read_raw_ref: prevent infinite retry loops in general
Date: Mon, 10 Oct 2016 12:34:05 +0200 [thread overview]
Message-ID: <d01fa7f9-827c-fc56-2d4d-69ba87ae851a@alum.mit.edu> (raw)
In-Reply-To: <20161006164842.yzrdigfimzvgkubv@sigill.intra.peff.net>
On 10/06/2016 06:48 PM, Jeff King wrote:
> Limit the number of retries to 3. That should be adequate to
> prevent any races, while preventing the possibility of
> infinite loops if the logic fails to handle any other
> possible error modes correctly.
>
> After the fix in the previous commit, there's no known way
> to trigger an infinite loop, but I did manually verify that
> this fixes the test in that commit even when the code change
> is not applied.
> [...]
This patch is
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Michael
prev parent reply other threads:[~2016-10-10 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 16:47 [PATCH 0/2] fix infinite loop in ref resolution Jeff King
2016-10-06 16:48 ` [PATCH 1/2] files_read_raw_ref: avoid infinite loop on broken symlinks Jeff King
2016-10-06 19:31 ` Johannes Sixt
2016-10-06 19:41 ` [PATCH v2 " Jeff King
2016-10-10 10:32 ` Michael Haggerty
2016-10-06 16:48 ` [PATCH 2/2] files_read_raw_ref: prevent infinite retry loops in general Jeff King
2016-10-10 10:34 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d01fa7f9-827c-fc56-2d4d-69ba87ae851a@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).