From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 966C5207EC for ; Thu, 6 Oct 2016 19:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934851AbcJFTba (ORCPT ); Thu, 6 Oct 2016 15:31:30 -0400 Received: from bsmtp.bon.at ([213.33.87.14]:48860 "EHLO bsmtp.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934820AbcJFTbZ (ORCPT ); Thu, 6 Oct 2016 15:31:25 -0400 Received: from dx.site (unknown [93.83.142.38]) by bsmtp.bon.at (Postfix) with ESMTPSA id 3sqjSW1PkZz5tlB; Thu, 6 Oct 2016 21:31:23 +0200 (CEST) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id 8FA675311; Thu, 6 Oct 2016 21:31:22 +0200 (CEST) Subject: Re: [PATCH 1/2] files_read_raw_ref: avoid infinite loop on broken symlinks To: Jeff King References: <20161006164723.ocg2nbgtulpjcksp@sigill.intra.peff.net> <20161006164825.otms5ovz2vzanimw@sigill.intra.peff.net> Cc: git@vger.kernel.org, Michael Haggerty From: Johannes Sixt Message-ID: <1c39b371-eb41-05d9-3c48-bd41764c9c9a@kdbg.org> Date: Thu, 6 Oct 2016 21:31:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161006164825.otms5ovz2vzanimw@sigill.intra.peff.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 06.10.2016 um 18:48 schrieb Jeff King: > +test_expect_success SYMLINKS 'ref resolution not confused by broken symlinks' ' > + ln -s does-not-exist .git/broken && > + test_must_fail git rev-parse --verify broken Hm, lower-case named refs directly in .git are frowned upon, no? If we ever decide to forbid them outright, this ref-parse might still fail, but for the wrong reason. Should you not better pick an example below ref/? -- Hannes