git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Brandon Casey <drafnel@gmail.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Ramkumar Ramachandra <artagnon@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH 2/2] Move sequencer to builtin
Date: Fri,  7 Jun 2013 17:16:49 -0500	[thread overview]
Message-ID: <1370643409-3431-3-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1370643409-3431-1-git-send-email-felipe.contreras@gmail.com>

This code is only useful for cherry-pick and revert built-ins, nothing
else, so let's make it a builtin object, but make sure 'git-sequencer'
is not generated.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 Makefile                           | 9 ++++++---
 sequencer.c => builtin/sequencer.c | 0
 sequencer.h => builtin/sequencer.h | 0
 3 files changed, 6 insertions(+), 3 deletions(-)
 rename sequencer.c => builtin/sequencer.c (100%)
 rename sequencer.h => builtin/sequencer.h (100%)

diff --git a/Makefile b/Makefile
index 03524d0..d28bf7f 100644
--- a/Makefile
+++ b/Makefile
@@ -583,7 +583,8 @@ TEST_PROGRAMS = $(patsubst %,%$X,$(TEST_PROGRAMS_NEED_X))
 
 # List built-in command $C whose implementation cmd_$C() is not in
 # builtin/$C.o but is linked in as part of some other command.
-BUILT_INS += $(patsubst builtin/%.o,git-%$X,$(BUILTIN_OBJS))
+BUILT_INS_OBJS = $(filter-out $(BUILTIN_HELPER_OBJS),$(BUILTIN_OBJS))
+BUILT_INS += $(patsubst builtin/%.o,git-%$X,$(BUILT_INS_OBJS))
 
 BUILT_INS += git-cherry$X
 BUILT_INS += git-cherry-pick$X
@@ -714,7 +715,6 @@ LIB_H += resolve-undo.h
 LIB_H += revision.h
 LIB_H += run-command.h
 LIB_H += send-pack.h
-LIB_H += sequencer.h
 LIB_H += sha1-array.h
 LIB_H += sha1-lookup.h
 LIB_H += shortlog.h
@@ -856,7 +856,6 @@ LIB_OBJS += resolve-undo.o
 LIB_OBJS += revision.o
 LIB_OBJS += run-command.o
 LIB_OBJS += send-pack.o
-LIB_OBJS += sequencer.o
 LIB_OBJS += server-info.o
 LIB_OBJS += setup.o
 LIB_OBJS += sha1-array.o
@@ -894,6 +893,8 @@ LIB_OBJS += wt-status.o
 LIB_OBJS += xdiff-interface.o
 LIB_OBJS += zlib.o
 
+BUILTIN_HELPER_OBJS += builtin/sequencer.o
+
 BUILTIN_OBJS += builtin/add.o
 BUILTIN_OBJS += builtin/annotate.o
 BUILTIN_OBJS += builtin/apply.o
@@ -990,6 +991,8 @@ BUILTIN_OBJS += builtin/verify-pack.o
 BUILTIN_OBJS += builtin/verify-tag.o
 BUILTIN_OBJS += builtin/write-tree.o
 
+BUILTIN_OBJS += $(BUILTIN_HELPER_OBJS)
+
 GITLIBS = $(LIB_FILE) $(XDIFF_LIB)
 EXTLIBS =
 
diff --git a/sequencer.c b/builtin/sequencer.c
similarity index 100%
rename from sequencer.c
rename to builtin/sequencer.c
diff --git a/sequencer.h b/builtin/sequencer.h
similarity index 100%
rename from sequencer.h
rename to builtin/sequencer.h
-- 
1.8.3.698.g079b096

  parent reply	other threads:[~2013-06-07 22:18 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 22:16 [PATCH 0/2] Move sequencer Felipe Contreras
2013-06-07 22:16 ` [PATCH 1/2] log-tree: remove dependency from sequencer Felipe Contreras
2013-06-07 22:16 ` Felipe Contreras [this message]
2013-06-08  2:35   ` [PATCH 2/2] Move sequencer to builtin Duy Nguyen
2013-06-08 10:14     ` Felipe Contreras
2013-06-08 11:42       ` Duy Nguyen
2013-06-08 12:25         ` Felipe Contreras
2013-06-08 12:34           ` Duy Nguyen
2013-06-08 12:55             ` Ramkumar Ramachandra
2013-06-08 13:15               ` Duy Nguyen
2013-06-08 13:32                 ` Felipe Contreras
2013-06-08 13:34                 ` Ramkumar Ramachandra
2013-06-08 14:10                   ` Felipe Contreras
2013-06-08 14:10                   ` Duy Nguyen
2013-06-08 14:20                     ` Felipe Contreras
2013-06-09  4:34                       ` Jeff King
2013-06-09  9:58                         ` Ramkumar Ramachandra
2013-06-09 17:55                           ` Jeff King
2013-06-09 18:06                             ` Ramkumar Ramachandra
2013-06-09 18:11                               ` Felipe Contreras
2013-06-09 18:22                               ` Jeff King
2013-06-09 18:29                                 ` Felipe Contreras
2013-06-09 18:44                                 ` Ramkumar Ramachandra
2013-06-09 18:49                                   ` Jeff King
2013-06-09 18:54                                     ` Felipe Contreras
2013-06-09 18:07                             ` Felipe Contreras
2013-06-09 12:09                         ` Felipe Contreras
2013-06-08 13:28             ` Felipe Contreras
2013-06-08 16:49         ` Jonathan Nieder
2013-06-08 17:06           ` Felipe Contreras
2013-06-08 17:34             ` Jonathan Nieder
2013-06-08 17:44               ` Felipe Contreras
2013-06-08 19:15               ` Felipe Contreras
2013-06-09  1:40                 ` Jonathan Nieder
2013-06-09  2:17                   ` Felipe Contreras
2013-06-09  3:21                     ` Jonathan Nieder
2013-06-09  3:34                       ` Felipe Contreras
2013-06-09  5:26                     ` Jeff King
2013-06-09 12:15                       ` Felipe Contreras
2013-06-09 17:40                         ` Jeff King
2013-06-09 18:01                           ` Felipe Contreras
2013-06-09 18:10                             ` Jeff King
2013-06-09 18:16                               ` Felipe Contreras
2013-06-09 19:11                                 ` Johan Herland
2013-06-09 19:29                                   ` Felipe Contreras
2013-06-09 21:42                                   ` Michael Haggerty
2013-06-09 23:40                                     ` Stefano Lattarini
2013-06-10  5:15                                       ` Felipe Contreras
2013-06-10  9:05                                         ` Bad attitudes and problems in the Git community (was: Re: [PATCH 2/2] Move sequencer to builtin) Stefano Lattarini
2013-06-10 16:58                                           ` Felipe Contreras
2013-06-10 18:11                                             ` Martin von Zweigbergk
2013-06-10 18:33                                               ` Martin Langhoff
2013-06-10 18:40                                                 ` Martin von Zweigbergk
2013-06-10 21:34                                               ` Felipe Contreras
2013-06-10  5:12                                     ` [PATCH 2/2] Move sequencer to builtin Felipe Contreras
2013-06-11  9:18                             ` Andres Freund
2013-06-11  9:29                               ` Felipe Contreras
2013-06-20 21:11                                 ` Thiago Farina
2013-06-09 17:53                         ` Thomas Rast
2013-06-09 18:03                           ` Felipe Contreras
2013-06-09 12:48                       ` Ramkumar Ramachandra
2013-06-09 13:08                         ` Felipe Contreras
2013-06-09 18:04                         ` Jeff King
2013-06-09 18:32                           ` Ramkumar Ramachandra
2013-06-09 18:45                             ` Jeff King
2013-06-09 19:57                               ` Jonathan Nieder
2013-06-09 20:07                                 ` Felipe Contreras
2013-06-09 20:34                                 ` Ramkumar Ramachandra
2013-06-09 21:39                               ` Junio C Hamano
2013-06-10  5:06                                 ` Felipe Contreras
2013-06-10  8:32                                   ` Junio C Hamano
2013-06-10 16:53                                     ` Felipe Contreras
2013-06-10 16:55                                       ` Felipe Contreras
2013-06-10 17:34                                       ` Matthieu Moy
2013-06-10 18:09                                         ` Ramkumar Ramachandra
2013-06-10 21:43                                         ` Felipe Contreras
2013-06-09 18:48                             ` Felipe Contreras
2013-06-09 19:25                             ` Thomas Rast
2013-06-09 19:54                               ` Ramkumar Ramachandra
2013-06-09 20:02                                 ` Felipe Contreras
2013-06-08  3:35 ` [PATCH 0/2] Move sequencer Ramkumar Ramachandra
2013-06-08 10:26   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370643409-3431-3-git-send-email-felipe.contreras@gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=artagnon@gmail.com \
    --cc=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).