[ sox-Patches-3607111 ] [patch] Ogg Opus support (read-only)

[ sox-Patches-3607111 ] [patch] Ogg Opus support (read-only)

[SourceForge.net]

Patches item #3607111, was opened at 2013-03-06 19:24
Message generated for change (Tracker Item Submitted) made by jstump91
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310706&aid=3607111&group_id=10706

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: John Stumpo (jstump91)
Assigned to: Nobody/Anonymous (nobody)
Summary: [patch] Ogg Opus support (read-only)

Initial Comment:
Here's a patch adding read-only support for Xiph's new Opus codec in an Ogg container (by convention, file extension .opus) using libopusfile. I based it on the existing Ogg Vorbis code; libopusfile and libvorbisfile have a lot in common about their APIs.

I was going to give it write support too, but there are numerous annoying things about doing this (for example, you must serialize the stream headers and packetize the audio yourself), and I didn't feel like doing that (or swiping opus-tools's code for it). All I really wanted to do was become able to play .opus files using play anyway, so I gave up on the write support. Maybe I might do it later (or someone else could).

Note that I had to add -Wno-long-long to CFLAGS to get it to build without warnings. The warnings without it are all due to the Opus header files, so there isn't really anything else I can do. They aren't treated as system headers since they're found using a -I option obtained from pkg-config.

My modifications to each file may be used under the same license as the respective original files. For opus.c, this is the same permissive license as vorbis.c.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310706&aid=3607111&group_id=10706

------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev

[ sox-Patches-3607111 ] [patch] Ogg Opus support (read-only)

[SourceForge.net]

Patches item #3607111, was opened at 2013-03-06 19:24
Message generated for change (Comment added) made by uklauer
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310706&aid=3607111&group_id=10706

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: John Stumpo (jstump91)
Assigned to: Nobody/Anonymous (nobody)
Summary: [patch] Ogg Opus support (read-only)

Initial Comment:
Here's a patch adding read-only support for Xiph's new Opus codec in an Ogg container (by convention, file extension .opus) using libopusfile. I based it on the existing Ogg Vorbis code; libopusfile and libvorbisfile have a lot in common about their APIs.

I was going to give it write support too, but there are numerous annoying things about doing this (for example, you must serialize the stream headers and packetize the audio yourself), and I didn't feel like doing that (or swiping opus-tools's code for it). All I really wanted to do was become able to play .opus files using play anyway, so I gave up on the write support. Maybe I might do it later (or someone else could).

Note that I had to add -Wno-long-long to CFLAGS to get it to build without warnings. The warnings without it are all due to the Opus header files, so there isn't really anything else I can do. They aren't treated as system headers since they're found using a -I option obtained from pkg-config.

My modifications to each file may be used under the same license as the respective original files. For opus.c, this is the same permissive license as vorbis.c.


----------------------------------------------------------------------

>Comment By: Ulrich Klauer (uklauer)
Date: 2013-03-08 03:44

Message:
Thank you for providing this patch! It is now in the main repo.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310706&aid=3607111&group_id=10706

------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev