From: Pander <pander@users.sourceforge.net>
To: sox-devel@lists.sourceforge.net
Subject: Re: Review patch for average power spectrum
Date: Tue, 23 Dec 2014 20:05:51 +0100 [thread overview]
Message-ID: <5499BD0F.70702@users.sourceforge.net> (raw)
In-Reply-To: <5498A2F9.2010500@free.fr>
On 12/23/2014 12:02 AM, Cedric Roux wrote:
> On 12/22/2014 11:14 PM, Eric Wong wrote:
>> ...otherwise, free may be called on an uninitialized value:
>>
>>> + if (re_average) {
>>> + free(re_average);
>>> + }
>
> Just for you information,
> if a pointer is null free(p) is fine and does nothing.
> The "if" is not required.
Thanks. Could the person implementing or applying the patch take this
into account?
Question for another unrelated patch, is non-linear interpolation
available in SoX via the C libraries which are already included?
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming! The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net
> _______________________________________________
> SoX-devel mailing list
> SoX-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/sox-devel
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
prev parent reply other threads:[~2014-12-23 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 21:50 Review patch for average power spectrum Pander
2014-12-22 22:14 ` Eric Wong
2014-12-22 22:59 ` Pander
2014-12-22 23:02 ` Cedric Roux
2014-12-23 19:05 ` Pander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.sourceforge.net/lists/listinfo/sox-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5499BD0F.70702@users.sourceforge.net \
--to=sox-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/sox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).