From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pander Newsgroups: gmane.comp.audio.sox.devel Subject: Re: Review patch for average power spectrum Date: Tue, 23 Dec 2014 20:05:51 +0100 Message-ID: <5499BD0F.70702@users.sourceforge.net> References: <54989213.5000201@users.sourceforge.net> <20141222221450.GA28373@dcvr.yhbt.net> <5498A2F9.2010500@free.fr> Reply-To: sox-devel@lists.sourceforge.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1419361577 16979 80.91.229.3 (23 Dec 2014 19:06:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Dec 2014 19:06:17 +0000 (UTC) To: sox-devel@lists.sourceforge.net Original-X-From: sox-devel-bounces@lists.sourceforge.net Tue Dec 23 20:06:10 2014 Return-path: Envelope-to: gcasd-sox-devel@m.gmane.org X-ACL-Warn: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 In-Reply-To: <5498A2F9.2010500@free.fr> X-Spam-Score: 0.0 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. X-Headers-End: 1Y3UmM-0003rT-J7 X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: sox-devel-bounces@lists.sourceforge.net Xref: news.gmane.org gmane.comp.audio.sox.devel:387 Archived-At: Received: from lists.sourceforge.net ([216.34.181.88]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y3UmT-0003tZ-3d for gcasd-sox-devel@m.gmane.org; Tue, 23 Dec 2014 20:06:05 +0100 Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Y3UmQ-0006gO-IC; Tue, 23 Dec 2014 19:06:02 +0000 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Y3UmP-0006gG-FY for sox-devel@lists.sourceforge.net; Tue, 23 Dec 2014 19:06:01 +0000 Received: from nodachi.mjopr.nl ([83.96.169.215]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1Y3UmM-0003rT-J7 for sox-devel@lists.sourceforge.net; Tue, 23 Dec 2014 19:06:01 +0000 Received: from [192.168.1.9] (ip235-130-212-87.adsl2.static.versatel.nl [87.212.130.235]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sander) by nodachi.mjopr.nl (Postfix) with ESMTPSA id 883E21F979 for ; Tue, 23 Dec 2014 20:11:57 +0100 (CET) On 12/23/2014 12:02 AM, Cedric Roux wrote: > On 12/22/2014 11:14 PM, Eric Wong wrote: >> ...otherwise, free may be called on an uninitialized value: >> >>> + if (re_average) { >>> + free(re_average); >>> + } > > Just for you information, > if a pointer is null free(p) is fine and does nothing. > The "if" is not required. Thanks. Could the person implementing or applying the patch take this into account? Question for another unrelated patch, is non-linear interpolation available in SoX via the C libraries which are already included? > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming! The Go Parallel Website, > sponsored by Intel and developed in partnership with Slashdot Media, is your > hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials and more. Take a > look and join the conversation now. http://goparallel.sourceforge.net > _______________________________________________ > SoX-devel mailing list > SoX-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sox-devel > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net