Re: Modification to spectrogram.c for log frequency axis and setting lower/upper chart frequency

[Eric Wong <normalperson@yhbt.net>]

Joe Desbonnet <jdesbonnet@gmail.com> wrote:
> If this code is worth contributing please advise what are the next steps
> (if any). Consider this code contributed under whatever terms that are
> required to have it added to the project.

You mentioned there was already an open feature request?  uploading the
patch to the bugtracker should be a start.  AFAIK, most of the sox
developers are busy at the moment with real-life stuff.

I just cloned your blog and looked at it (a diff/cloned sox.git repo
would've been better), and it looks mostly OK...
Did you make sure log10_high_freq != log10_low_freq anywhere?  Otherwise
you might divide by zero:

   float log_scale = (float)p->rows/(log10_high_freq - log10_low_freq);

I'm only a simple C programmer and don't know the math behind
spectrograms, though.

(*) not sure how pick sox devs are about trailing whitespace,
    but other projects I work tend to be very picky :)

------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk