From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.audio.sox.devel Subject: Re: Modification to spectrogram.c for log frequency axis and setting lower/upper chart frequency Date: Mon, 17 Feb 2014 06:14:47 +0000 Message-ID: <20140217061447.GA7537@dcvr.yhbt.net> References: Reply-To: sox-devel@lists.sourceforge.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1392617694 24436 80.91.229.3 (17 Feb 2014 06:14:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Feb 2014 06:14:54 +0000 (UTC) To: sox-devel@lists.sourceforge.net Original-X-From: sox-devel-bounces@lists.sourceforge.net Mon Feb 17 07:15:02 2014 Return-path: Envelope-to: gcasd-sox-devel@m.gmane.org X-ACL-Warn: Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -0.6 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1WFHTh-0000Ks-9d X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: sox-devel-bounces@lists.sourceforge.net Xref: news.gmane.org gmane.comp.audio.sox.devel:356 Archived-At: Received: from lists.sourceforge.net ([216.34.181.88]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WFHTp-0008Rb-KS for gcasd-sox-devel@m.gmane.org; Mon, 17 Feb 2014 07:15:01 +0100 Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WFHTj-00075z-JP; Mon, 17 Feb 2014 06:14:55 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WFHTi-00075s-1Q for sox-devel@lists.sourceforge.net; Mon, 17 Feb 2014 06:14:54 +0000 Received: from dcvr.yhbt.net ([64.71.152.64]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1WFHTh-0000Ks-9d for sox-devel@lists.sourceforge.net; Mon, 17 Feb 2014 06:14:54 +0000 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B0FBB21A04; Mon, 17 Feb 2014 06:14:47 +0000 (UTC) Joe Desbonnet wrote: > If this code is worth contributing please advise what are the next steps > (if any). Consider this code contributed under whatever terms that are > required to have it added to the project. You mentioned there was already an open feature request? uploading the patch to the bugtracker should be a start. AFAIK, most of the sox developers are busy at the moment with real-life stuff. I just cloned your blog and looked at it (a diff/cloned sox.git repo would've been better), and it looks mostly OK... Did you make sure log10_high_freq != log10_low_freq anywhere? Otherwise you might divide by zero: float log_scale = (float)p->rows/(log10_high_freq - log10_low_freq); I'm only a simple C programmer and don't know the math behind spectrograms, though. (*) not sure how pick sox devs are about trailing whitespace, but other projects I work tend to be very picky :) ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk