* [ruby-dev:50403] [Ruby trunk Feature#14255] Deprecate $SAFE support from ERB
[not found] <redmine.issue-14255.20171228053551@ruby-lang.org>
@ 2017-12-28 5:35 ` takashikkbn
2017-12-28 5:53 ` [ruby-dev:50404] [Ruby trunk Feature#14255][Closed] Deprecate $SAFE support in ERB takashikkbn
1 sibling, 0 replies; 2+ messages in thread
From: takashikkbn @ 2017-12-28 5:35 UTC (permalink / raw)
To: ruby-dev
Issue #14255 has been reported by k0kubun (Takashi Kokubun).
----------------------------------------
Feature #14255: Deprecate $SAFE support from ERB
https://bugs.ruby-lang.org/issues/14255
* Author: k0kubun (Takashi Kokubun)
* Status: Open
* Priority: Normal
* Assignee: k0kubun (Takashi Kokubun)
* Target version: 2.6
----------------------------------------
See https://bugs.ruby-lang.org/issues/14250.
Proc-level $SAFE change does no longer make sense. This should be deprecated and then removed. But the problem is that the position of safe_level argument is in the middle of argument list of ERB#initialize.
So to remove it safely, we should make them keyword arguments and deprecate the current non-keyword-argument interface. Having both interfaces would be backward-compatible because all of arguments don't take {}.
## before
```
ERB.new("<%= 'foo' %>", 1, '%', '_erbout')
```
## after
```
ERB.new("<%= 'foo' %>", 1, '%', '_erbout') # print deprecation in 2.6, and removed in 2.7
ERB.new("<%= 'foo' %>", trim_mode: '%', eoutvar: '_erbout') # no safe_level support from first
```
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
* [ruby-dev:50404] [Ruby trunk Feature#14255][Closed] Deprecate $SAFE support in ERB
[not found] <redmine.issue-14255.20171228053551@ruby-lang.org>
2017-12-28 5:35 ` [ruby-dev:50403] [Ruby trunk Feature#14255] Deprecate $SAFE support from ERB takashikkbn
@ 2017-12-28 5:53 ` takashikkbn
1 sibling, 0 replies; 2+ messages in thread
From: takashikkbn @ 2017-12-28 5:53 UTC (permalink / raw)
To: ruby-dev
Issue #14255 has been updated by k0kubun (Takashi Kokubun).
Status changed from Open to Closed
Changed from ruby-dev to ruby-core https://bugs.ruby-lang.org/issues/14256
----------------------------------------
Feature #14255: Deprecate $SAFE support in ERB
https://bugs.ruby-lang.org/issues/14255#change-69076
* Author: k0kubun (Takashi Kokubun)
* Status: Closed
* Priority: Normal
* Assignee: k0kubun (Takashi Kokubun)
* Target version: 2.6
----------------------------------------
See https://bugs.ruby-lang.org/issues/14250.
Proc-level $SAFE change does no longer make sense. This should be deprecated and then removed. But the problem is that the position of safe_level argument is in the middle of argument list of ERB#initialize.
So to remove it safely, we should make them keyword arguments and deprecate the current non-keyword-argument interface. Having both interfaces would be backward-compatible because all of arguments don't take {}.
## before
```
ERB.new("<%= 'foo' %>", 1, '%', '_erbout')
```
## after
```
ERB.new("<%= 'foo' %>", 1, '%', '_erbout') # print deprecation in 2.6, and removed in 2.7
ERB.new("<%= 'foo' %>", trim_mode: '%', eoutvar: '_erbout') # no safe_level support from first
```
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-28 5:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <redmine.issue-14255.20171228053551@ruby-lang.org>
2017-12-28 5:35 ` [ruby-dev:50403] [Ruby trunk Feature#14255] Deprecate $SAFE support from ERB takashikkbn
2017-12-28 5:53 ` [ruby-dev:50404] [Ruby trunk Feature#14255][Closed] Deprecate $SAFE support in ERB takashikkbn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).