ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:97731] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl
@ 2020-04-06 17:12 v.ondruch
  2020-10-09 10:44 ` [ruby-core:100347] " v.ondruch
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: v.ondruch @ 2020-04-06 17:12 UTC (permalink / raw)
  To: ruby-core

Issue #16762 has been reported by vo.x (Vit Ondruch).

----------------------------------------
Bug #16762: Ruby is not properly fortified on armv7hl
https://bugs.ruby-lang.org/issues/16762

* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.8.0dev (2020-04-03 master 810d66f3e7) [armv7hl-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
The issue is similar to #15335 and the fix is also similar:

~~~
diff --git a/coroutine/arm32/Context.S b/coroutine/arm32/Context.S
index b66db29622..596284b5cf 100644
--- a/coroutine/arm32/Context.S
+++ b/coroutine/arm32/Context.S
@@ -24,3 +24,7 @@ coroutine_transfer:
 	
 	# Restore callee state (8 registers program counter)
 	pop {r4-r11,pc}
+
+#if defined(__linux__) && defined(__ELF__)
+.section .note.GNU-stack,"",%progbits
+#endif
~~~

It seems to be introduced by https://github.com/ruby/ruby/pull/2995



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [ruby-core:100347] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl
  2020-04-06 17:12 [ruby-core:97731] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl v.ondruch
@ 2020-10-09 10:44 ` v.ondruch
  2020-10-09 14:23 ` [ruby-core:100349] " mame
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: v.ondruch @ 2020-10-09 10:44 UTC (permalink / raw)
  To: ruby-core

Issue #16762 has been updated by vo.x (Vit Ondruch).


I'd still love to see this fixed.

----------------------------------------
Bug #16762: Ruby is not properly fortified on armv7hl
https://bugs.ruby-lang.org/issues/16762#change-87959

* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.8.0dev (2020-04-03 master 810d66f3e7) [armv7hl-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
The issue is similar to #15335 and the fix is also similar:

~~~
diff --git a/coroutine/arm32/Context.S b/coroutine/arm32/Context.S
index b66db29622..596284b5cf 100644
--- a/coroutine/arm32/Context.S
+++ b/coroutine/arm32/Context.S
@@ -24,3 +24,7 @@ coroutine_transfer:
 	
 	# Restore callee state (8 registers program counter)
 	pop {r4-r11,pc}
+
+#if defined(__linux__) && defined(__ELF__)
+.section .note.GNU-stack,"",%progbits
+#endif
~~~

It seems to be introduced by https://github.com/ruby/ruby/pull/2995



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [ruby-core:100349] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl
  2020-04-06 17:12 [ruby-core:97731] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl v.ondruch
  2020-10-09 10:44 ` [ruby-core:100347] " v.ondruch
@ 2020-10-09 14:23 ` mame
  2020-12-08  8:22 ` [ruby-core:101310] " samuel
  2020-12-08 10:38 ` [ruby-core:101314] " samuel
  3 siblings, 0 replies; 5+ messages in thread
From: mame @ 2020-10-09 14:23 UTC (permalink / raw)
  To: ruby-core

Issue #16762 has been updated by mame (Yusuke Endoh).

Assignee set to ioquatix (Samuel Williams)
Status changed from Open to Assigned

----------------------------------------
Bug #16762: Ruby is not properly fortified on armv7hl
https://bugs.ruby-lang.org/issues/16762#change-87961

* Author: vo.x (Vit Ondruch)
* Status: Assigned
* Priority: Normal
* Assignee: ioquatix (Samuel Williams)
* ruby -v: ruby 2.8.0dev (2020-04-03 master 810d66f3e7) [armv7hl-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
The issue is similar to #15335 and the fix is also similar:

~~~
diff --git a/coroutine/arm32/Context.S b/coroutine/arm32/Context.S
index b66db29622..596284b5cf 100644
--- a/coroutine/arm32/Context.S
+++ b/coroutine/arm32/Context.S
@@ -24,3 +24,7 @@ coroutine_transfer:
 	
 	# Restore callee state (8 registers program counter)
 	pop {r4-r11,pc}
+
+#if defined(__linux__) && defined(__ELF__)
+.section .note.GNU-stack,"",%progbits
+#endif
~~~

It seems to be introduced by https://github.com/ruby/ruby/pull/2995



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [ruby-core:101310] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl
  2020-04-06 17:12 [ruby-core:97731] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl v.ondruch
  2020-10-09 10:44 ` [ruby-core:100347] " v.ondruch
  2020-10-09 14:23 ` [ruby-core:100349] " mame
@ 2020-12-08  8:22 ` samuel
  2020-12-08 10:38 ` [ruby-core:101314] " samuel
  3 siblings, 0 replies; 5+ messages in thread
From: samuel @ 2020-12-08  8:22 UTC (permalink / raw)
  To: ruby-core

Issue #16762 has been updated by ioquatix (Samuel Williams).


https://github.com/ruby/ruby/pull/3866

----------------------------------------
Bug #16762: Ruby is not properly fortified on armv7hl
https://bugs.ruby-lang.org/issues/16762#change-89005

* Author: vo.x (Vit Ondruch)
* Status: Assigned
* Priority: Normal
* Assignee: ioquatix (Samuel Williams)
* ruby -v: ruby 2.8.0dev (2020-04-03 master 810d66f3e7) [armv7hl-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
The issue is similar to #15335 and the fix is also similar:

~~~
diff --git a/coroutine/arm32/Context.S b/coroutine/arm32/Context.S
index b66db29622..596284b5cf 100644
--- a/coroutine/arm32/Context.S
+++ b/coroutine/arm32/Context.S
@@ -24,3 +24,7 @@ coroutine_transfer:
 	
 	# Restore callee state (8 registers program counter)
 	pop {r4-r11,pc}
+
+#if defined(__linux__) && defined(__ELF__)
+.section .note.GNU-stack,"",%progbits
+#endif
~~~

It seems to be introduced by https://github.com/ruby/ruby/pull/2995



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [ruby-core:101314] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl
  2020-04-06 17:12 [ruby-core:97731] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl v.ondruch
                   ` (2 preceding siblings ...)
  2020-12-08  8:22 ` [ruby-core:101310] " samuel
@ 2020-12-08 10:38 ` samuel
  3 siblings, 0 replies; 5+ messages in thread
From: samuel @ 2020-12-08 10:38 UTC (permalink / raw)
  To: ruby-core

Issue #16762 has been updated by ioquatix (Samuel Williams).


It passed arm32 on travis (as expected), so I merged it. Thanks everyone!

----------------------------------------
Bug #16762: Ruby is not properly fortified on armv7hl
https://bugs.ruby-lang.org/issues/16762#change-89007

* Author: vo.x (Vit Ondruch)
* Status: Assigned
* Priority: Normal
* Assignee: ioquatix (Samuel Williams)
* ruby -v: ruby 2.8.0dev (2020-04-03 master 810d66f3e7) [armv7hl-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
The issue is similar to #15335 and the fix is also similar:

~~~
diff --git a/coroutine/arm32/Context.S b/coroutine/arm32/Context.S
index b66db29622..596284b5cf 100644
--- a/coroutine/arm32/Context.S
+++ b/coroutine/arm32/Context.S
@@ -24,3 +24,7 @@ coroutine_transfer:
 	
 	# Restore callee state (8 registers program counter)
 	pop {r4-r11,pc}
+
+#if defined(__linux__) && defined(__ELF__)
+.section .note.GNU-stack,"",%progbits
+#endif
~~~

It seems to be introduced by https://github.com/ruby/ruby/pull/2995



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-08 10:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 17:12 [ruby-core:97731] [Ruby master Bug#16762] Ruby is not properly fortified on armv7hl v.ondruch
2020-10-09 10:44 ` [ruby-core:100347] " v.ondruch
2020-10-09 14:23 ` [ruby-core:100349] " mame
2020-12-08  8:22 ` [ruby-core:101310] " samuel
2020-12-08 10:38 ` [ruby-core:101314] " samuel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).