ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:98323] [Ruby master Bug#16854] Using (...) when the method name is a keyword generates error
@ 2020-05-13 16:42 james
  2020-05-13 17:32 ` [ruby-core:98325] " shevegen
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: james @ 2020-05-13 16:42 UTC (permalink / raw)
  To: ruby-core

Issue #16854 has been reported by jamesnakagawa (James Nakagawa).

----------------------------------------
Bug #16854: Using (...) when the method name is a keyword generates error
https://bugs.ruby-lang.org/issues/16854

* Author: jamesnakagawa (James Nakagawa)
* Status: Open
* Priority: Normal
* ruby -v: 2.7.0
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Although I wouldn't generally recommend it, naming a method `true` is allowed. However, in combination with the new argument forwarding keyword `...`, a syntax error is generated which does not occur with other argument choices.

This came up for me on my Rails project where an enumerated database column was defined to allow the values `:true`, `:false` (not an unreasonable request in itself). Active Record's generated class tried to contain methods by these names.

Try this code for yourself:

```ruby
class Works
  def true(*args)
    puts(*args)
  end
end

Works.new.true 1, 2, 3
# => 1, 2, 3

class WontWork
  def true(...)
    puts(...)
  end
end

# => freezes
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ruby-core:98325] [Ruby master Bug#16854] Using (...) when the method name is a keyword generates error
  2020-05-13 16:42 [ruby-core:98323] [Ruby master Bug#16854] Using (...) when the method name is a keyword generates error james
@ 2020-05-13 17:32 ` shevegen
  2020-05-15  6:00 ` [ruby-core:98379] " nobu
  2020-07-25  4:41 ` [ruby-core:99325] " nagachika00
  2 siblings, 0 replies; 4+ messages in thread
From: shevegen @ 2020-05-13 17:32 UTC (permalink / raw)
  To: ruby-core

Issue #16854 has been updated by shevegen (Robert A. Heiler).


Interesting find and explanation.

----------------------------------------
Bug #16854: Using (...) when the method name is a keyword generates error
https://bugs.ruby-lang.org/issues/16854#change-85563

* Author: jamesnakagawa (James Nakagawa)
* Status: Open
* Priority: Normal
* ruby -v: 2.7.0
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Although I wouldn't generally recommend it, naming a method `true` is allowed. However, in combination with the new argument forwarding keyword `...`, a syntax error is generated which does not occur with other argument choices.

This came up for me on my Rails project where an enumerated database column was defined to allow the values `:true`, `:false` (not an unreasonable request in itself). Active Record's generated class tried to contain methods by these names.

Try this code for yourself:

```ruby
class Works
  def true(*args)
    puts(*args)
  end
end

Works.new.true 1, 2, 3
# => 1, 2, 3

class WontWork
  def true(...)
    puts(...)
  end
end

# => freezes
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ruby-core:98379] [Ruby master Bug#16854] Using (...) when the method name is a keyword generates error
  2020-05-13 16:42 [ruby-core:98323] [Ruby master Bug#16854] Using (...) when the method name is a keyword generates error james
  2020-05-13 17:32 ` [ruby-core:98325] " shevegen
@ 2020-05-15  6:00 ` nobu
  2020-07-25  4:41 ` [ruby-core:99325] " nagachika00
  2 siblings, 0 replies; 4+ messages in thread
From: nobu @ 2020-05-15  6:00 UTC (permalink / raw)
  To: ruby-core

Issue #16854 has been updated by nobu (Nobuyoshi Nakada).


It results in a syntax error, right?

https://github.com/ruby/ruby/pull/3112

----------------------------------------
Bug #16854: Using (...) when the method name is a keyword generates error
https://bugs.ruby-lang.org/issues/16854#change-85647

* Author: jamesnakagawa (James Nakagawa)
* Status: Open
* Priority: Normal
* ruby -v: 2.7.0
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Although I wouldn't generally recommend it, naming a method `true` is allowed. However, in combination with the new argument forwarding keyword `...`, a syntax error is generated which does not occur with other argument choices.

This came up for me on my Rails project where an enumerated database column was defined to allow the values `:true`, `:false` (not an unreasonable request in itself). Active Record's generated class tried to contain methods by these names.

Try this code for yourself:

```ruby
class Works
  def true(*args)
    puts(*args)
  end
end

Works.new.true 1, 2, 3
# => 1, 2, 3

class WontWork
  def true(...)
    puts(...)
  end
end

# => freezes
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ruby-core:99325] [Ruby master Bug#16854] Using (...) when the method name is a keyword generates error
  2020-05-13 16:42 [ruby-core:98323] [Ruby master Bug#16854] Using (...) when the method name is a keyword generates error james
  2020-05-13 17:32 ` [ruby-core:98325] " shevegen
  2020-05-15  6:00 ` [ruby-core:98379] " nobu
@ 2020-07-25  4:41 ` nagachika00
  2 siblings, 0 replies; 4+ messages in thread
From: nagachika00 @ 2020-07-25  4:41 UTC (permalink / raw)
  To: ruby-core

Issue #16854 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 2.5: DONTNEED, 2.6: DONTNEED, 2.7: REQUIRED to 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONE

ruby_2_7 be359442cb07c25fdc769431ffed3249b9016829 merged revision(s) 71c166e11e761dcaaa943f9b94da38f86ada1bdb.

----------------------------------------
Bug #16854: Using (...) when the method name is a keyword generates error
https://bugs.ruby-lang.org/issues/16854#change-86720

* Author: jamesnakagawa (James Nakagawa)
* Status: Closed
* Priority: Normal
* ruby -v: 2.7.0
* Backport: 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONE
----------------------------------------
Although I wouldn't generally recommend it, naming a method `true` is allowed. However, in combination with the new argument forwarding keyword `...`, a syntax error is generated which does not occur with other argument choices.

This came up for me on my Rails project where an enumerated database column was defined to allow the values `:true`, `:false` (not an unreasonable request in itself). Active Record's generated class tried to contain methods by these names.

Try this code for yourself:

```ruby
class Works
  def true(*args)
    puts(*args)
  end
end

Works.new.true 1, 2, 3
# => 1, 2, 3

class WontWork
  def true(...)
    puts(...)
  end
end

# => freezes
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-25  4:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 16:42 [ruby-core:98323] [Ruby master Bug#16854] Using (...) when the method name is a keyword generates error james
2020-05-13 17:32 ` [ruby-core:98325] " shevegen
2020-05-15  6:00 ` [ruby-core:98379] " nobu
2020-07-25  4:41 ` [ruby-core:99325] " nagachika00

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).