ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: matz@ruby.or.jp
To: ruby-core@ruby-lang.org
Subject: [ruby-core:96891] [Ruby master Bug#8841] Module#included_modules and prepended modules
Date: Thu, 16 Jan 2020 06:19:51 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-83904.20200116061951.105b03605776ad72@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-8841.20130831081739@ruby-lang.org

Issue #8841 has been updated by matz (Yukihiro Matsumoto).

Status changed from Open to Closed

This intentional.

Matz.


----------------------------------------
Bug #8841: Module#included_modules and prepended modules
https://bugs.ruby-lang.org/issues/8841#change-83904

* Author: marcandre (Marc-Andre Lafortune)
* Status: Closed
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
* ruby -v: r42735
* Backport: 
----------------------------------------
The documentation for Module#included_modules currently states "Returns the list of modules included in +mod+."

This was never perfectly accurate, as the list also contains modules included in +mod+'s ancestors.

It now also includes prepended modules.

This is consistent with `include?` that returns true for prepended modules, but not quite consistent with `included` that does not get called for prepended modules.

Matz, could you confirm that current behavior is what you want?

If so, we should fix the documentation of `include?` and `included_modules`.



-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2020-01-16  6:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 23:17 [ruby-core:56898] [ruby-trunk - Bug #8841][Open] Module#included_modules and prepended modules marcandre (Marc-Andre Lafortune)
2019-12-20  0:56 ` [ruby-core:96348] [Ruby master Bug#8841] " mame
2019-12-20 14:33 ` [ruby-core:96376] " jean.boussier
2020-01-16  6:19 ` matz [this message]
2020-01-16 19:32 ` [ruby-core:96916] " ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-83904.20200116061951.105b03605776ad72@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).